From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754004AbcERVYh (ORCPT ); Wed, 18 May 2016 17:24:37 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:51789 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752009AbcERVYe (ORCPT ); Wed, 18 May 2016 17:24:34 -0400 From: Arnd Bergmann To: Felipe Balbi Cc: Arnd Bergmann , Andy Gross , David Brown , Peter Chen , Greg Kroah-Hartman , Alan Stern , Mark Brown , Bjorn Andersson , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-usb@vger.kernel.org Subject: [RFC 0/8] usb: phy: msm: various cleanups Date: Wed, 18 May 2016 23:24:05 +0200 Message-Id: <1463606653-325131-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:ae5RroekVeeYVCxkqoUW6RIFneDA3FBcN3h4LxVTyOIHJA9cuzN BmYNxyKtVBdS5KxjDQppAnMcyI2I14Us9HnRD2IQ4Oubz7X6WgisKtO3M1EDcd+qeeZnxlE qMS64zBlyCM8VjjGH1hq7aKn4YoTZwaoZWU9qoSIMnmOiiG5CXCJIQDISmED9Dca12+3NXf P6gJuvStImWGIZw38JQgA== X-UI-Out-Filterresults: notjunk:1;V01:K0:8kiPKpAf6bY=:a1FrK2emFPIrw3TRjJJM3z 5d4ejW5gtA8gN35lHWT1dKEgsmAB9zsB/QlLzmfgIDUD+90Dyki8EzRUA7GdzzMgiy7g/Fbyb /9Q560OwSh/MNr1ged8+uAxcLrinfWOChZrxfX2IsiuM61V2luLDnxuylddUhQS3GtxQj48Rm PbK08actRxC4rNlIAqaW6bJ6nMq0uw5oGwfEFPD6JIv87klgwejezWc0D4phBI51WvQpQxMcy qQcqpWcC2Dod+B23gWk2Gt8Wf02n1DeThKPBN+lQNrE4OA58OqwrTOXkMM/EiFnxZ45coEohC BJRGvHRlGeNRU8EyZsNs8vOqHg/6QzwFF/DJjncpno19yRax0ou1G+osBWeGCGRB0ABJB33mQ ZMR0YPv2YxN2lNsQTr5JkVruNOUDI4MgO34iqAG0cYaU/PAxm+Q+yIN/tuNazxiHpDjORhJV9 F689g+wHE/pz2jEseE7DOMCzLtWbyaiGveA+A0N00c6qDrL/cVJrPyiBUjwhNv6aVQuqt3xrT m8ezpYz27ZxjxA/qPzn6EAAnnXbi7s2yQ+sMyb+oB2zKyPZaM6feWW5tBLa9bUIFb2akVCEQV A6D3U/LC8UKiF5APdGmrsDqx9cEyQmddBA4Q4gNgADD80tY969kYp2VAsRSj2bjPjWHARtJtY yygkfl+jeE3JlqxvPdrnmadD0eoK/zELa41Gzk3jC3EwdZbZg+Ot1AXTGrVJxr4ZF58U= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I stumbled over this warning last week, which showed up after I had removed an incorrect patch from my randconfig build setup: drivers/usb/phy/phy-msm-usb.c: In function 'msm_otg_probe': drivers/usb/phy/phy-msm-usb.c:1735:14: error: 'regs[0].consumer' may be used uninitialized in this function [-Werror=maybe-uninitialized] motg->vddcx = regs[0].consumer; ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ drivers/usb/phy/phy-msm-usb.c:1736:14: error: 'regs[1].consumer' may be used uninitialized in this function [-Werror=maybe-uninitialized] motg->v3p3 = regs[1].consumer; ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ drivers/usb/phy/phy-msm-usb.c:1737:14: error: 'regs[2].consumer' may be used uninitialized in this function [-Werror=maybe-uninitialized] motg->v1p8 = regs[2].consumer; ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ Having already fixed the same problem in the phy-qcom-8x16-usb.c driver before, I tried to do the same thing here, but it turned out to be somewhat different, and I ended up running into several unrelated issues in the driver that I now try to fix up. The series is not tested beyond verifying that it no longer causes randconfig warnings, and some patches are not entirely obvious. In particular the ehci-msm and chipidea changes are probably a good idea, but they actually change the behavior of the drivers in a way that I cannot verify through inspection alone. The last patch in the series probably requires some changes to the devicetree files to go along with it. Please have a look and test this, provided the patches make sense conceptually. Arnd Arnd Bergmann (8): usb: phy: move msm_hsusb.h into driver usb: ehci-msm: call usb_phy_init instead of open-coding it usb: chipidea: msm: remove open-coded phy init usb: phy: move TCSR driver into new file usb: phy: msm: move register definitions into driver usb: phy: qcom: use bulk regulator interfaces usb: phy: msm: remove v1p8/v3p3 voltage setting usb: phy: msm: disable regulator for remove() drivers/soc/qcom/Kconfig | 6 + drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/qcom-tcsr.c | 57 +++++ drivers/usb/chipidea/ci_hdrc_msm.c | 6 - drivers/usb/host/ehci-msm.c | 17 +- drivers/usb/phy/Kconfig | 1 + drivers/usb/phy/phy-msm-usb.c | 432 ++++++++++++++++++++++++------------- include/linux/soc/qcom/tcsr.h | 13 ++ include/linux/usb/msm_hsusb.h | 200 ----------------- include/linux/usb/msm_hsusb_hw.h | 77 ------- 10 files changed, 367 insertions(+), 443 deletions(-) create mode 100644 drivers/soc/qcom/qcom-tcsr.c create mode 100644 include/linux/soc/qcom/tcsr.h delete mode 100644 include/linux/usb/msm_hsusb.h delete mode 100644 include/linux/usb/msm_hsusb_hw.h -- 2.7.0 Cc: Andy Gross Cc: David Brown Cc: Peter Chen Cc: Greg Kroah-Hartman Cc: Alan Stern Cc: Felipe Balbi Cc: Arnd Bergmann Cc: Mark Brown Cc: Bjorn Andersson Cc: linux-kernel@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org Cc: linux-soc@vger.kernel.org Cc: linux-usb@vger.kernel.org