From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752180AbcEVJwr (ORCPT <rfc822;w@1wt.eu>);
	Sun, 22 May 2016 05:52:47 -0400
Received: from mail-wm0-f65.google.com ([74.125.82.65]:35481 "EHLO
	mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751898AbcEVJwp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 22 May 2016 05:52:45 -0400
Message-ID: <1463910760.3698.3.camel@gmail.com>
Subject: Re: [patch] sched/fair: Move se->vruntime normalization state into
 struct sched_entity
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
        Pavan Kondeti <pkondeti@codeaurora.org>,
        Ben Segall <bsegall@google.com>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Paul Turner <pjt@google.com>, Thomas Gleixner <tglx@linutronix.de>,
        byungchul.park@lge.com, Andrew Hunter <ahh@google.com>
Date: Sun, 22 May 2016 11:52:40 +0200
In-Reply-To: <20160522093638.GL3193@twins.programming.kicks-ass.net>
References: <20160510174314.355953085@infradead.org>
	 <20160510174613.902178264@infradead.org>
	 <1463839488.24578.45.camel@suse.de> <1463857236.10353.5.camel@gmail.com>
	 <1463900401.30072.6.camel@gmail.com>
	 <20160522093638.GL3193@twins.programming.kicks-ass.net>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 2016-05-22 at 11:36 +0200, Peter Zijlstra wrote:
> On Sun, May 22, 2016 at 09:00:01AM +0200, Mike Galbraith wrote:
> > On Sat, 2016-05-21 at 21:00 +0200, Mike Galbraith wrote:
> > > On Sat, 2016-05-21 at 16:04 +0200, Mike Galbraith wrote:
> > > 
> > > > Wakees that were not migrated/normalized eat an unwanted min_vruntime,
> > > > and likely take a size XXL latency hit.  Big box running master bled
> > > > profusely under heavy load until I turned TTWU_QUEUE off.
> > 
> > May as well make it official and against master.today.  Fly or die
> > little patchlet.
> > 
> > sched/fair: Move se->vruntime normalization state into struct sched_entity
> 
> Yeah, I used to have a patch like this; but for debugging. I don't
> particularly like carrying this information other than for verification
> because it means we either do too much or too little normalization.
> 
> I'll try and have a look on Monday, but I got some real-life things to
> sort out first..

Ok (flush, say hi to the goldfish little patchlet). I don't care how it
gets fixed, only that it does, and yours will likely be prettier :)

	-Mike