From: "Pali Rohár" <pali.rohar@gmail.com>
To: "Matthew Garrett" <mjg59@srcf.ucam.org>,
"Darren Hart" <dvhart@infradead.org>,
"Gabriele Mazzotta" <gabriele.mzt@gmail.com>,
"Michał Kępień" <kernel@kempniu.pl>,
"Mario Limonciello" <mario_limonciello@dell.com>,
"Andy Lutomirski" <luto@kernel.org>,
"Alex Hung" <alex.hung@canonical.com>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, "Pali Rohár" <pali.rohar@gmail.com>,
"Matthew Garrett" <mjg@redhat.com>
Subject: [PATCH 1/4] dell-wmi: Ignore WMI event code 0xe045
Date: Sun, 22 May 2016 13:36:20 +0200 [thread overview]
Message-ID: <1463916983-12562-2-git-send-email-pali.rohar@gmail.com> (raw)
In-Reply-To: <1463916983-12562-1-git-send-email-pali.rohar@gmail.com>
>From Dell we know that WMI event code 0xe045 is for Num Lock key, but it is
unclear due to message in commit 0b3f6109f0c9 ("dell-wmi: new driver for
hotkey control").
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Mario Limonciello <mario_limonciello@dell.com>
Link: https://lkml.org/lkml/2015/7/7/830
---
drivers/platform/x86/dell-wmi.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index 15c6f11..4d23c91 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -88,7 +88,6 @@ static const struct dmi_system_id dell_wmi_smbios_list[] __initconst = {
static const struct key_entry dell_wmi_legacy_keymap[] __initconst = {
{ KE_IGNORE, 0x003a, { KEY_CAPSLOCK } },
- { KE_KEY, 0xe045, { KEY_PROG1 } },
{ KE_KEY, 0xe009, { KEY_EJECTCD } },
/* These also contain the brightness level at offset 6 */
@@ -130,7 +129,19 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = {
{ KE_IGNORE, 0xe033, { KEY_KBDILLUMUP } },
{ KE_IGNORE, 0xe034, { KEY_KBDILLUMDOWN } },
{ KE_IGNORE, 0xe03a, { KEY_CAPSLOCK } },
+
+ /*
+ * This entry is very suspicious!
+ * Originally Matthew Garrett created this dell-wmi driver specially for
+ * "button with a picture of a battery" which has event code 0xe045.
+ * Later Mario Limonciello from Dell told us that event code 0xe045 is
+ * reported by Num Lock and should be ignored because key is send also
+ * by keyboard controller.
+ * So for now we will ignore this event to prevent potential double
+ * Num Lock key press.
+ */
{ KE_IGNORE, 0xe045, { KEY_NUMLOCK } },
+
{ KE_IGNORE, 0xe046, { KEY_SCROLLLOCK } },
{ KE_IGNORE, 0xe0f7, { KEY_MUTE } },
{ KE_IGNORE, 0xe0f8, { KEY_VOLUMEDOWN } },
--
1.7.9.5
next prev parent reply other threads:[~2016-05-22 11:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-22 11:36 [PATCH 0/4] dell-wmi: Changes in WMI event code handling Pali Rohár
2016-05-22 11:36 ` Pali Rohár [this message]
2016-05-22 11:36 ` [PATCH 2/4] dell-wmi: Sort WMI event codes and update comments Pali Rohár
2016-06-02 10:41 ` Michał Kępień
2016-06-07 22:03 ` Pali Rohár
2016-06-08 19:48 ` Darren Hart
2016-06-08 19:57 ` Pali Rohár
2016-06-08 20:15 ` Darren Hart
2016-06-08 20:27 ` Pali Rohár
2016-06-08 20:43 ` Darren Hart
2016-06-08 20:49 ` Pali Rohár
2016-05-22 11:36 ` [PATCH 3/4] dell-wmi: Add information about other WMI event codes Pali Rohár
2016-05-26 22:04 ` Gabriele Mazzotta
2016-06-07 23:00 ` Pali Rohár
2016-06-08 6:02 ` Mario_Limonciello
2016-06-08 10:44 ` Gabriele Mazzotta
2016-06-15 19:51 ` Pali Rohár
2016-06-21 19:51 ` Mario_Limonciello
2016-06-22 7:56 ` Pali Rohár
2016-06-22 13:40 ` Mario_Limonciello
2016-06-22 14:12 ` Pali Rohár
2016-06-22 14:21 ` Mario_Limonciello
2016-06-22 14:24 ` Pali Rohár
2016-06-22 14:28 ` Mario_Limonciello
2016-06-22 14:31 ` Pali Rohár
2016-06-22 14:34 ` Mario_Limonciello
2016-06-22 14:38 ` Pali Rohár
2016-06-22 14:39 ` Gabriele Mazzotta
2016-06-22 14:46 ` Mario_Limonciello
2016-06-02 10:41 ` Michał Kępień
2016-06-07 22:06 ` Pali Rohár
2016-05-22 11:36 ` [PATCH 4/4] dell-wmi: Rework code for generating sparse keymap and processing WMI events Pali Rohár
2016-05-23 17:07 ` Andy Lutomirski
2016-06-02 10:42 ` Michał Kępień
2016-06-07 22:30 ` Pali Rohár
2016-06-02 10:52 ` [PATCH 0/4] dell-wmi: Changes in WMI event code handling Michał Kępień
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463916983-12562-2-git-send-email-pali.rohar@gmail.com \
--to=pali.rohar@gmail.com \
--cc=alex.hung@canonical.com \
--cc=dvhart@infradead.org \
--cc=gabriele.mzt@gmail.com \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mario_limonciello@dell.com \
--cc=mjg59@srcf.ucam.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).