From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753330AbcEWK0k (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 May 2016 06:26:40 -0400
Received: from mail-wm0-f67.google.com ([74.125.82.67]:35141 "EHLO
	mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752702AbcEWK0i (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 May 2016 06:26:38 -0400
Message-ID: <1463999193.4537.106.camel@gmail.com>
Subject: Re: [patch] sched/fair: Move se->vruntime normalization state into
 struct sched_entity
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Pavan Kondeti <pkondeti@codeaurora.org>,
        Ben Segall <bsegall@google.com>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Paul Turner <pjt@google.com>, Thomas Gleixner <tglx@linutronix.de>,
        Byungchul Park <byungchul.park@lge.com>,
        Andrew Hunter <ahh@google.com>
Date: Mon, 23 May 2016 12:26:33 +0200
In-Reply-To: <CANRm+CyO6SRn5vXv=ENi7V54RD9mWv_1_W5WAs9SGPcWWFk+Jg@mail.gmail.com>
References: <20160510174314.355953085@infradead.org>
	 <20160510174613.902178264@infradead.org>
	 <1463839488.24578.45.camel@suse.de> <1463857236.10353.5.camel@gmail.com>
	 <1463900401.30072.6.camel@gmail.com>
	 <20160523091907.GD15728@worktop.ger.corp.intel.com>
	 <1463996435.4537.97.camel@gmail.com>
	 <CANRm+CyO6SRn5vXv=ENi7V54RD9mWv_1_W5WAs9SGPcWWFk+Jg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2016-05-23 at 18:13 +0800, Wanpeng Li wrote:
> 2016-05-23 17:40 GMT+08:00 Mike Galbraith <umgwanakikbuti@gmail.com>:
> > On Mon, 2016-05-23 at 11:19 +0200, Peter Zijlstra wrote:
> > > On Sun, May 22, 2016 at 09:00:01AM +0200, Mike Galbraith wrote:
> > > > On Sat, 2016-05-21 at 21:00 +0200, Mike Galbraith wrote:
> > > > > On Sat, 2016-05-21 at 16:04 +0200, Mike Galbraith wrote:
> > > > > 
> > > > > > Wakees that were not migrated/normalized eat an unwanted
> > > > > > min_vruntime,
> > > > > > and likely take a size XXL latency hit.  Big box running
> > > > > > master bled
> > > > > > profusely under heavy load until I turned TTWU_QUEUE off.
> > > > 
> > > > May as well make it official and against master.today.  Fly or
> > > > die
> > > > little patchlet.
> > > > 
> > > > sched/fair: Move se->vruntime normalization state into struct
> > > > sched_entity
> > > 
> > > Does this work?
> > 
> > Yup, bugs--.  Kinda funny, I considered ~this way first, but
> > thought
> > you'd not that approach.. dang, got it back-assward ;-)
> > 
> 
> Nicer this one.

Well, the wakeup is a remote wakeup whether the flag is set or not, so
in that regard it's not _squeaky_ clean, but is dinky, works (yay)..
and doesn't invent helpers with funny names vs what they actually do.

	-Mike