From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932232AbcEWLBB (ORCPT ); Mon, 23 May 2016 07:01:01 -0400 Received: from foss.arm.com ([217.140.101.70]:50150 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754378AbcEWK6g (ORCPT ); Mon, 23 May 2016 06:58:36 -0400 From: Morten Rasmussen To: peterz@infradead.org, mingo@redhat.com Cc: dietmar.eggemann@arm.com, yuyang.du@intel.com, vincent.guittot@linaro.org, mgalbraith@suse.de, linux-kernel@vger.kernel.org, Morten Rasmussen Subject: [PATCH 07/16] sched: Make SD_BALANCE_WAKE a topology flag Date: Mon, 23 May 2016 11:58:49 +0100 Message-Id: <1464001138-25063-8-git-send-email-morten.rasmussen@arm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464001138-25063-1-git-send-email-morten.rasmussen@arm.com> References: <1464001138-25063-1-git-send-email-morten.rasmussen@arm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For systems with the SD_ASYM_CPUCAPACITY flag set on higher level in the sched_domain hierarchy we need a way to enable wake-up balancing for the lower levels as well as we may want to balance tasks that don't fit the capacity of the previous cpu. We have the option of introducing a new topology flag to express this requirement, or let the existing SD_BALANCE_WAKE flag be set by the architecture as a topology flag. The former means introducing yet another flag, the latter breaks the current meaning of topology flags. None of the options are really desirable. cc: Ingo Molnar cc: Peter Zijlstra Signed-off-by: Morten Rasmussen --- kernel/sched/core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 558ec4a..8014b4a 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -5658,6 +5658,7 @@ static int sd_degenerate(struct sched_domain *sd) SD_BALANCE_NEWIDLE | SD_BALANCE_FORK | SD_BALANCE_EXEC | + SD_BALANCE_WAKE | SD_SHARE_CPUCAPACITY | SD_ASYM_CPUCAPACITY | SD_SHARE_PKG_RESOURCES | @@ -5690,6 +5691,7 @@ sd_parent_degenerate(struct sched_domain *sd, struct sched_domain *parent) SD_BALANCE_NEWIDLE | SD_BALANCE_FORK | SD_BALANCE_EXEC | + SD_BALANCE_WAKE | SD_ASYM_CPUCAPACITY | SD_SHARE_CPUCAPACITY | SD_SHARE_PKG_RESOURCES | @@ -6308,6 +6310,7 @@ static int sched_domains_curr_level; * Odd ones out: * SD_ASYM_PACKING - describes SMT quirks * SD_ASYM_CPUCAPACITY - describes mixed capacity topologies + * SD_BALANCE_WAKE - controls wake-up balancing (expensive) */ #define TOPOLOGY_SD_FLAGS \ (SD_SHARE_CPUCAPACITY | \ @@ -6315,6 +6318,7 @@ static int sched_domains_curr_level; SD_NUMA | \ SD_ASYM_PACKING | \ SD_ASYM_CPUCAPACITY | \ + SD_BALANCE_WAKE | \ SD_SHARE_POWERDOMAIN) static struct sched_domain * -- 1.9.1