From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Bryant G Ly <bryantly@linux.vnet.ibm.com>
Cc: Michael Cyr <mikecyr@linux.vnet.ibm.com>,
rjui@broadcom.com, sbranden@broadcom.com, jonmason@broadcom.com,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix for hang of Ordered task in TCM
Date: Mon, 23 May 2016 22:47:34 -0700 [thread overview]
Message-ID: <1464068854.22249.69.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <20160523191735.Horde.6wmWQ7EiiPavHDD7pNfVtQ1@ltc.linux.ibm.com>
Hi Bryant,
On Mon, 2016-05-23 at 19:17 -0400, Bryant G Ly wrote:
> Quoting "Nicholas A. Bellinger" <nab@linux-iscsi.org>:
>
> <SNIP>
> >
> > So AFAICT for delayed commands, the above patch ends up skipping these
> > three checks subsequently when doing __target_execute_cmd() directly
> > from target_restart_delayed_cmds(), no..?
> >
> > After pondering this some more, what about moving these checks into
> > __target_execute_cmd() to handle both target_core_transport.c cases
> > instead..?
> >
> > We'll also need a parameter for internal COMPARE_AND_WRITE usage
> > within compare_and_write_callback(), to bypass checks upon secondary
> > ->execute_cmd() WRITE payload submission after READ + COMPARE has
> > completed successfully.
<SNIP>
> Looks good to me.
Thanks for the review!
> Nick just to let you know I've been working with
> Mike on VSCSI Target Fabric and we need this patch in kernel 4.4 do
> you know of the process in getting that there?
So pending a bit more list feedback + testing across multiple fabric
drivers, it's been added for the moment to target-pending/queue as post
-rc1 material.
As it merged into target-pending/master next week, the extra stable CC'
can be added to be picked up for linux-4.4.y stable and friends.
Also AFAIK, we've not had reports of other SCSI host environments
triggering this bug, but it's still a good idea to consider it for
linux-3.x.y backport at some point as well.
prev parent reply other threads:[~2016-05-24 5:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 22:15 [PATCH] Fix for hang of Ordered task in TCM Michael Cyr
2016-05-18 5:53 ` Nicholas A. Bellinger
2016-05-18 19:35 ` Michael Cyr
2016-05-24 5:31 ` Nicholas A. Bellinger
2016-06-08 19:43 ` [PATCH] target: " Bryant G. Ly
2016-06-09 5:38 ` Nicholas A. Bellinger
2016-05-23 23:17 ` [PATCH] " Bryant G Ly
2016-05-24 5:47 ` Nicholas A. Bellinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464068854.22249.69.camel@haakon3.risingtidesystems.com \
--to=nab@linux-iscsi.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bryantly@linux.vnet.ibm.com \
--cc=jonmason@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mikecyr@linux.vnet.ibm.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).