From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755920AbcEYCZ6 (ORCPT ); Tue, 24 May 2016 22:25:58 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([207.82.80.143]:60404 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932285AbcEYCZv convert rfc822-to-8bit (ORCPT ); Tue, 24 May 2016 22:25:51 -0400 From: Huang Shijie To: CC: , , , , Huang Shijie Subject: [PATCH 3/4] samples/kretprobe: convert the printk to pr_info/pr_err Date: Wed, 25 May 2016 10:24:42 +0800 Message-ID: <1464143083-3877-3-git-send-email-shijie.huang@arm.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1464143083-3877-1-git-send-email-shijie.huang@arm.com> References: <1464143083-3877-1-git-send-email-shijie.huang@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:217.140.96.140;IPV:CAL;SCL:-1;CTRY:GB;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(189002)(199003)(2950100001)(6806005)(86362001)(2906002)(5008740100001)(4326007)(104016004)(106466001)(11100500001)(87936001)(33646002)(50226002)(1220700001)(77096005)(586003)(19580395003)(47776003)(19580405001)(189998001)(36756003)(5003600100002)(8936002)(50986999)(76176999)(8676002)(110136002)(2351001)(229853001)(92566002)(5003940100001)(48376002)(50466002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR08MB0207;H:nebula.arm.com;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;AM1FFO11FD020;1:AVmyOZsepEbqsDMJO4FlLALIMmTAnfKtbT1GkZjja8jqBrX5VJDEr3mwn3U0pXeJDcdQS3U/3QVRjSbYWUXRB58O/+1nPFUEG1zwlz/oSJnA9qINE6h953pqobHTVCEG032g67rULmEP7v9kQHsENhhBGSaRts6Hy+M/rc/kYEvfxZEKCg4sT+5QlZK40w6KhWiMT4L8AaUYA6REH/qQqVkXIfmf4dx9EYYpRBICTxDs3fWpwDTE3LVqyvPMTxQLHkEKc4dv4hXGa21b3h6ysXNStFD4CCjj5SPJdgc2RZDI6H/srLtBsbMqsf1YfDL+Gy0FmI5Biq3gr91kgyZHeNkHnacgx8DXimRyyUBKbGqpy1T5TeyS8Fd0/ZLFcaToP6HjOW63NQkIQeNpAdlxFyecvuhjt+rdiMjY395dskPYKtWBwqIHCFfcN2Xu8c15+GnPJHibBNmiRsaIPnb0h9jazzHw9Hqnqi84mi6OuHozgwgCPkXXc+bxGPjdwF+RYDxjE/Ua2JBZsFzqnpZlvbPpmkNDA0gIfpk3ucD1ETk= X-MS-Office365-Filtering-Correlation-Id: 6ee3a3c4-6717-4ee3-cdde-08d38443e007 X-Microsoft-Exchange-Diagnostics: 1;DB4PR08MB0207;2:rto8kCoHusrSwbIcZg2Nd0t7C9fZsxXkN+3l2FSf4/Vnja5++CAkuVSMb082wueGiwMml4NVT5wTZMoryL80y5YcOmfeSO/E05LWixsKMWG/PAqdpGeuO3Pyc5YnDSsGH3tOYcGAUsrXxJXGUoI3S6sS4gazsw97G+9p8BzIWXxPCuThAgRSHQidrvL2Rjtd;3:+0Cu+it2wX64NnrER4CpmE2NekN4rsr6A5myS774zgnSREDQGJJ/M6yTt9OljLe7LsvpYP1nmtIgv+EYut8b2ShfYj45fPWTdicJ1jLGRbEPJzRHxWqLN+XAi48R0w74vFwk2ZIhYSHIliPLa1CIEzpaKTJpE+o1pIEWpdQ5PfPNzXK/22/nFqrQ8eO/voHlLQM0OPlzOD9cRVHdq1uUg0i0D4yOjostlJRmmthJeSuPgELTv7MuGI9g3ERR198uTiy+IMqxdEixHL0DgFUPdw==;25:ptVTvUrsxutpOLgrLwOK1KUqNX40/znaFRxwH2baCAeky0hrg6gDxMvup56ImSg07Dy4Dmg/I8YRKOqOFx2TKvrl3SWTSooF0CIUFYsnR5Pd9YU+W/qv3DTvUaUreL9+PnKwuO+zPT4981hZjAshdmwc/i458Kq5gYFhebikXcZua+Vn9T+1MSk9AfgqrDQQWz5DHIXnacL4cPIRo0GJaIMuSV76HDfGhEj60daWdodnVt1wp4Uyl4lzyyv+dS/JGinjP1T+WbJ7O1vjxol3o0rQm34n9+l/OOlJkqzIU26V19OIvcXRPLb0xg901kh+JL0nROgx5ewdTWYnzXOu6MdYSL1go3Xm8+yYy8dLdKN4nBjWgkBCTnT86ncvk3+o5IB5T0/5j7umc8qO3AAsvj7Zxfh35nBzO6AIBEHcn08= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:DB4PR08MB0207; NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;DB4PR08MB0207;20:pXMw8WW+z+/VEjGYCKNJeaQnROMFDLuR/vJVCoziTyEFgSJVH5FXjnC1Oh1Vx6am+bHVH5YRut+qG39tWlibX0ZWmSt2lo2GWEQz5Yd2gvNX1XP2lD1tE5B8va0T3mO1Moa58tOeqUiuzEzt5obP7/6XwBBah2kCDiqLzDgJFnsP5aALbdorrv+6eYLa09Hl3FNAuBW6SLoEhWt/nH/Whkd/X4UWgwxd0VekfiRVz/h6ZWcLhFRquZF4g+yMB4fd;4:E3/rAY21iFAjZIjlroNcEPMZME2Gmr0lMYsmbVgU+Myl+nsvfO25rhNxt/q8SoRpjRDwS6Rc96r543AvJe8kTlZhRZf2bKXDJG1Sb7SJCR/gvM85cLw5pijAmv8TTXyZWZltI7iDxgEeSIaNgp0mY3xkWSt+RSj01KvTKT1uLLElokMY2tCt3IFsYR+FjQHCp5BF2kFRuvpRtnjZi/Omse6hNTTYurnzxS07IM1y4fAVRH1KTJ95caJaV6ptMXvfip82G28fG1L8cNhOVrCaOVaBVR5QHaBStwknnSlSybslttF8rK47lL2TRZ5GxHjyqAxX72QelSA8sMZB0lv2f2AIpFRA4RJM+cWopd10aGC8E2O11tywg1Ikwv7RMW1sBDWBBIMNtqunCXX5Q26AcQxBHG7ulw458jFUqehKuxdoFd7xxcyVAPSucFsf0HRPT7W5xDH2OhySiIppHUvNvQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13024025)(13023025)(13020025)(13013025)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:DB4PR08MB0207;BCL:0;PCL:0;RULEID:;SRVR:DB4PR08MB0207; X-Forefront-PRVS: 09538D3531 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB4PR08MB0207;23:agA0ozmLMPj3YVUKiHDEuu7xn2lhrLazjU1rxRxZs?= =?us-ascii?Q?Tp6QyiANaKme1pk3FdGn/BEDvTZi94m2oTCzfYN5tCUoiU5q/SSmFZQ3MlYz?= =?us-ascii?Q?8PYgeMwFoC6YsWtusPaQaBRp0KWeFqnbx1rIWDRtmQcyFWrtpCrcWnGv3nGo?= =?us-ascii?Q?8/5WAqhx5BSllrArbWnsvfM1QBoVds+Fq/8wu+JF9jAalKrS3016GIV0WSJn?= =?us-ascii?Q?w3tRTCay2epDCpo3cVzTpPep3ntNQYyWD1OgvwukUC9E6rI5QIyX0q35hKG0?= =?us-ascii?Q?LjQJkTfLzv6ffU4uAe98HsF/wncz7RGvYtSKIAJEGeCd1uI74B+Ng9zzgVC0?= =?us-ascii?Q?PQkKtmdWIt7pgctCAlUCKcO48zsrD5RAgV+GkmkA7z+QVqeqDLAVl+SImHH3?= =?us-ascii?Q?i8XmiZ4/V4QPv0oTSqWaiA4yhxLHZcx47J8JubXcPUO9ZktTNzEgWXUKFWZN?= =?us-ascii?Q?aN4VdsHVUvQAmaJv+bRQ537VARzcMDeO4qBRti+6ypkLDgxJzSEKFLsv1LCc?= =?us-ascii?Q?LfHXyOIDBLxsqZDT/ejrQGfakX9X01vTZDa4enRGWjdGQS4pA5ItClzTz7X8?= =?us-ascii?Q?Z6nEXg2iSmja5448aFqi+IedzigJ22krRYWlkhcQ00Y7tkJF0mOSdDSdR6RG?= =?us-ascii?Q?yQXxbZdmaxh+U2Iwzm+aD9JvKvagZNxhJGWsOncOsBj4vfNc1rRxSRJqcaZZ?= =?us-ascii?Q?w5OZvF4td5v9LO1opouluNxmQh5ieCRlLqlL8EHHhwzNYqRamZ7FR+xrFlSd?= =?us-ascii?Q?qkzd+uaEzlo5QrgknAXfqE4YGHAZsQm/OVOzYCsRNPdPL9Ycnd4aZ7M+fSV8?= =?us-ascii?Q?pcLUWNxS4N7sUndFJTRc8DQqHnxSv9kJbGlFLjrZmyNJBH98/1Nisjogh4Y4?= =?us-ascii?Q?pHCC5PVrxHnmP2ZlJ0owojGYysr0MHKnoo5KPpxSYpHtP9KkMzFMkl7sn2wm?= =?us-ascii?Q?YC9vbFB5IxuYC2Wj3mH050uNpLSoEJTvR4y2EWlLjlxPLQ0f4cta3wR8Fl/p?= =?us-ascii?Q?+A=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB4PR08MB0207;5:a0qe9qnDJM9zsKDtJFG/kogNC6ufq3zVD1HvsxCfouBdzii8P17e7yqTbx0ek7GQa0fQfsPzT8jhyOhs8rqQX7iQV+jxxNT0cy3e6EjIYBAsYSUB+iYQeMM2f/WtxiPmPQdwwRUHxB1NYhNNlMjeAw==;24:1XA92uo/3RHlOe0nLB+r/NPbVXdFebHlLvM4sB+3w3axoL4/T0rrRb7fB5TuWBu3dCMOJuNQLcLoBZKK/jcMLeSkEnDFY5eQnZyigPkntn0=;7:KJ++dpse0XwHCYBR57DVrCEz2Efl405VisMXaoLkz35gz8fqtBVXz4DKXebeQ1yYmqWT5SMuYFnJfpsFhFkj1f+ReLl9uhj3lxDG3aI81wQl2JIbQR2AQk/G5AYV4yhWieyi/b58cHW0tQaUpXculKq8Ciqua1kwm3jLd2rZE9zwhcU7znLHd4LUTLydCAps;20:U4PdXBrgKwgjEWqVHrOfIR/9EQwCPSuZheo6/vk7qzHBuKXvs/IUi05wygH0asQqD1um/9XF2qrdBlG9Zq3d7dxmyM90GvHHYph6drgjZ0T+/qbJDDeG4PYFdNgqQUSY9ysvm+HEPl+ojyFbKvhSNpxiJPnkhNw+Ak/ZIHIJdZI= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2016 02:25:44.3158 (UTC) X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[217.140.96.140];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB0207 X-MC-Unique: 2yCZzxWlQyWFAvq-0gqZ4A-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We prefer to use the pr_* to print out the log now, this patch converts the printk to pr_info. In the error path, use the pr_err to replace the printk. Signed-off-by: Huang Shijie --- samples/kprobes/kretprobe_example.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c index ebb1d1a..adc83e9 100644 --- a/samples/kprobes/kretprobe_example.c +++ b/samples/kprobes/kretprobe_example.c @@ -62,7 +62,7 @@ static int ret_handler(struct kretprobe_instance *ri, struct pt_regs *regs) now = ktime_get(); delta = ktime_to_ns(ktime_sub(now, data->entry_stamp)); - printk(KERN_INFO "%s returned %d and took %lld ns to execute\n", + pr_info("%s returned %d and took %lld ns to execute\n", func_name, retval, (long long)delta); return 0; } @@ -82,11 +82,10 @@ static int __init kretprobe_init(void) my_kretprobe.kp.symbol_name = func_name; ret = register_kretprobe(&my_kretprobe); if (ret < 0) { - printk(KERN_INFO "register_kretprobe failed, returned %d\n", - ret); + pr_err("register_kretprobe failed, returned %d\n", ret); return -1; } - printk(KERN_INFO "Planted return probe at %s: %p\n", + pr_info("Planted return probe at %s: %p\n", my_kretprobe.kp.symbol_name, my_kretprobe.kp.addr); return 0; } @@ -94,11 +93,10 @@ static int __init kretprobe_init(void) static void __exit kretprobe_exit(void) { unregister_kretprobe(&my_kretprobe); - printk(KERN_INFO "kretprobe at %p unregistered\n", - my_kretprobe.kp.addr); + pr_info("kretprobe at %p unregistered\n", my_kretprobe.kp.addr); /* nmissed > 0 suggests that maxactive was set too low. */ - printk(KERN_INFO "Missed probing %d instances of %s\n", + pr_info("Missed probing %d instances of %s\n", my_kretprobe.nmissed, my_kretprobe.kp.symbol_name); } -- 2.5.5