From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754846AbcEYOor (ORCPT <rfc822;w@1wt.eu>);
	Wed, 25 May 2016 10:44:47 -0400
Received: from smtprelay0069.hostedemail.com ([216.40.44.69]:36336 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751853AbcEYOoo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 25 May 2016 10:44:44 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3868:4321:5007:7576:10004:10400:10848:11232:11658:11783:11914:12043:12517:12519:12679:12740:13069:13311:13357:13439:13894:14181:14659:14721:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none
X-HE-Tag: drain52_45ea881ddc548
X-Filterd-Recvd-Size: 2014
Message-ID: <1464187479.16344.14.camel@perches.com>
Subject: Re: [PATCH 3/3] ibmvscsis: clean up functions
From: Joe Perches <joe@perches.com>
To: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>, tyreld@linux.vnet.ibm.com,
        bart.vanassche@sandisk.com
Cc: martin.petersen@oracle.com, akpm@linux-foundation.org,
        kvalo@codeaurora.org, davem@davemloft.net, mchehab@osg.samsung.com,
        jslaby@suse.com, bp@suse.de, linux-kernel@vger.kernel.org,
        linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Date: Wed, 25 May 2016 07:44:39 -0700
In-Reply-To: <1464185854-19761-3-git-send-email-bryantly@linux.vnet.ibm.com>
References: <1464097978-88457-1-git-send-email-bryantly@linux.vnet.ibm.com>
	 <1464185854-19761-1-git-send-email-bryantly@linux.vnet.ibm.com>
	 <1464185854-19761-3-git-send-email-bryantly@linux.vnet.ibm.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.2-0ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2016-05-25 at 09:17 -0500, Bryant G. Ly wrote:
> From: bryantly <bryantly@linux.vnet.ibm.com>

Please use your whole name here and for your sign-off like:

From: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>

> This patch removes forward declarations and re-organizes the
> functions within the driver. This patch also fixes MAINTAINERS
> for ibmvscsis.

trivial note:

> diff --git a/drivers/scsi/ibmvscsi/ibmvscsis.c b/drivers/scsi/ibmvscsi/ibmvscsis.c
[]
>  static inline long h_copy_rdma(s64 length, u64 sliobn, u64 slioba,
>  			       u64 dliobn, u64 dlioba)
>  {
> 

Functions like this would be less indented and less
line wrapped for 80 columns if they were written:

	if (!se_cmd->residual_count)
		return;

	[unindented one level...]

etc...