From: Julien Desfossez <jdesfossez@efficios.com>
To: tglx@linutronix.de, rostedt@goodmis.org, mathieu.desnoyers@efficios.com
Cc: linux-kernel@vger.kernel.org, Julien Desfossez <jdesfossez@efficios.com>
Subject: [RFC PATCH 1/2] sched: encapsulate priority changes in a sched_set_prio static function
Date: Fri, 27 May 2016 11:16:07 -0400 [thread overview]
Message-ID: <1464362168-17064-1-git-send-email-jdesfossez@efficios.com> (raw)
Currently, the priority of tasks is modified directly in the scheduling
functions. Encapsulate priority updates to enable instrumentation of
priority changes. This will enable analysis of real-time scheduling
delays per thread priority, which cannot be performed accurately if we
only trace the priority of the currently scheduled processes.
The call sites that modify the priority of a task are mostly system
calls: sched_setscheduler, sched_setattr, sched_process_fork and
set_user_nice. Priority can also be dynamically boosted through
priority inheritance of rt_mutex by rt_mutex_setprio.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
---
include/linux/sched.h | 3 ++-
kernel/sched/core.c | 19 +++++++++++++------
2 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 52c4847..48b35c0 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1409,7 +1409,8 @@ struct task_struct {
#endif
int on_rq;
- int prio, static_prio, normal_prio;
+ int prio; /* Updated through sched_set_prio() */
+ int static_prio, normal_prio;
unsigned int rt_priority;
const struct sched_class *sched_class;
struct sched_entity se;
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index d1f7149..6946b8f 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2230,6 +2230,11 @@ int sysctl_schedstats(struct ctl_table *table, int write,
#endif
#endif
+static void sched_set_prio(struct task_struct *p, int prio)
+{
+ p->prio = prio;
+}
+
/*
* fork()/clone()-time setup:
*/
@@ -2249,7 +2254,7 @@ int sched_fork(unsigned long clone_flags, struct task_struct *p)
/*
* Make sure we do not leak PI boosting priority to the child.
*/
- p->prio = current->normal_prio;
+ sched_set_prio(p, current->normal_prio);
/*
* Revert to default priority/policy on fork if requested.
@@ -2262,7 +2267,8 @@ int sched_fork(unsigned long clone_flags, struct task_struct *p)
} else if (PRIO_TO_NICE(p->static_prio) < 0)
p->static_prio = NICE_TO_PRIO(0);
- p->prio = p->normal_prio = __normal_prio(p);
+ p->normal_prio = __normal_prio(p);
+ sched_set_prio(p, p->normal_prio);
set_load_weight(p);
/*
@@ -3477,7 +3483,7 @@ void rt_mutex_setprio(struct task_struct *p, int prio)
p->sched_class = &fair_sched_class;
}
- p->prio = prio;
+ sched_set_prio(p, prio);
if (running)
p->sched_class->set_curr_task(rq);
@@ -3524,7 +3530,7 @@ void set_user_nice(struct task_struct *p, long nice)
p->static_prio = NICE_TO_PRIO(nice);
set_load_weight(p);
old_prio = p->prio;
- p->prio = effective_prio(p);
+ sched_set_prio(p, effective_prio(p));
delta = p->prio - old_prio;
if (queued) {
@@ -3731,9 +3737,10 @@ static void __setscheduler(struct rq *rq, struct task_struct *p,
* sched_setscheduler().
*/
if (keep_boost)
- p->prio = rt_mutex_get_effective_prio(p, normal_prio(p));
+ sched_set_prio(p, rt_mutex_get_effective_prio(p,
+ normal_prio(p)));
else
- p->prio = normal_prio(p);
+ sched_set_prio(p, normal_prio(p));
if (dl_prio(p->prio))
p->sched_class = &dl_sched_class;
--
1.9.1
next reply other threads:[~2016-05-27 15:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 15:16 Julien Desfossez [this message]
2016-05-27 15:16 ` [RFC PATCH 2/2] tracing: add sched_set_prio tracepoint Julien Desfossez
2016-05-30 13:18 ` Mathieu Desnoyers
2016-06-06 19:52 ` Mathieu Desnoyers
2016-06-06 21:03 ` Peter Zijlstra
2016-06-08 0:18 ` Daniel Bristot de Oliveira
2016-05-30 13:18 ` [RFC PATCH 1/2] sched: encapsulate priority changes in a sched_set_prio static function Mathieu Desnoyers
2016-06-06 21:47 ` Mathieu Desnoyers
2016-06-07 7:11 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464362168-17064-1-git-send-email-jdesfossez@efficios.com \
--to=jdesfossez@efficios.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).