From: Rhyland Klein <rklein@nvidia.com>
To: Peter De Schrijver <pdeschrijver@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Alexandre Courbot <gnurou@gmail.com>, <linux-clk@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Rhyland Klein <rklein@nvidia.com>
Subject: [PATCH v2 11/11] clk: tegra: WARN if clk in the init_table has enable
Date: Fri, 27 May 2016 16:38:14 -0400 [thread overview]
Message-ID: <1464381494-27096-12-git-send-email-rklein@nvidia.com> (raw)
In-Reply-To: <1464381494-27096-1-git-send-email-rklein@nvidia.com>
Enabling clocks through the init_table mechanism is deprecated. Clocks
that need to be enabled early and stay on should be marked as CRITICAL.
Signed-off-by: Rhyland Klein <rklein@nvidia.com>
---
drivers/clk/tegra/clk.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c
index b2cdd9a235f4..898fe922c742 100644
--- a/drivers/clk/tegra/clk.c
+++ b/drivers/clk/tegra/clk.c
@@ -262,6 +262,11 @@ void __init tegra_init_from_table(struct tegra_clk_init_table *tbl,
WARN_ON(1);
}
+ /* Using the init_table to enable clks at boot is
+ * deprecated. Clks that need to be enabled through early
+ * boot, they should be marked as CLK_IS_CRITICAL
+ */
+ WARN_ON_ONCE(tbl->state);
if (tbl->state)
if (clk_prepare_enable(clk)) {
pr_err("%s: Failed to enable %s\n", __func__,
--
1.9.1
next prev parent reply other threads:[~2016-05-27 20:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 20:38 [PATCH v2 00/11] Switch to using CRITICAL clks for Tegra Rhyland Klein
2016-05-27 20:38 ` [PATCH v2 01/11] clk: tegra: Switch to using critical clks Rhyland Klein
2016-06-22 12:16 ` Thierry Reding
2016-06-27 8:35 ` Peter De Schrijver
2016-07-05 22:07 ` Rhyland Klein
2016-05-27 20:38 ` [PATCH v2 02/11] clk: tegra20: Mark required clks as CRITICAL Rhyland Klein
2016-05-27 20:38 ` [PATCH v2 03/11] clk: tegra20: clean up init_table Rhyland Klein
2016-05-27 20:38 ` [PATCH v2 04/11] clk: tegra30: Mark certain clks as critical Rhyland Klein
2016-05-27 20:38 ` [PATCH v2 05/11] clk: tegra30: clean up init_table Rhyland Klein
2016-05-27 20:38 ` [PATCH v2 06/11] clk: tegra114: " Rhyland Klein
2016-05-27 20:38 ` [PATCH v2 07/11] clk: tegra124: " Rhyland Klein
2016-05-27 20:38 ` [PATCH v2 08/11] clk: tegra210: Mark required clks as CRITICAL Rhyland Klein
2016-05-27 20:38 ` [PATCH v2 09/11] clk: tegra210: clean up init_table Rhyland Klein
2016-05-27 20:38 ` [PATCH v2 10/11] clk: Show CRITICAL clks in clk_summary output Rhyland Klein
2016-06-22 12:24 ` Thierry Reding
2016-06-22 15:31 ` Rhyland Klein
2016-06-28 17:40 ` Stephen Boyd
2016-06-30 20:13 ` Rhyland Klein
2016-05-27 20:38 ` Rhyland Klein [this message]
2016-06-21 18:05 ` [PATCH v2 00/11] Switch to using CRITICAL clks for Tegra Rhyland Klein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464381494-27096-12-git-send-email-rklein@nvidia.com \
--to=rklein@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=sboyd@codeaurora.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).