From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753774AbcE3FwQ (ORCPT ); Mon, 30 May 2016 01:52:16 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:42617 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751114AbcE3FwO (ORCPT ); Mon, 30 May 2016 01:52:14 -0400 X-Sasl-enc: NXt6mJCwgU2uazGHHWVXosB2+qZm1YUfGXngHoBGPDuy 1464587532 Message-ID: <1464587527.3025.6.camel@themaw.net> Subject: Re: [PATCH] autofs: don't stuck in a loop if vfs_write returns an error From: Ian Kent To: Andrei Vagin Cc: autofs@vger.kernel.org, LKML , akpm@linux-foundation.org Date: Mon, 30 May 2016 13:52:07 +0800 In-Reply-To: <1464053664.3108.21.camel@themaw.net> References: <1459487558-21258-1-git-send-email-avagin@gmail.com> <1459496266.2974.1.camel@themaw.net> <1464053664.3108.21.camel@themaw.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 (3.16.5-3.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-05-24 at 09:34 +0800, Ian Kent wrote: > On Mon, 2016-05-23 at 14:50 -0700, Andrei Vagin wrote: > > Hi Ian, > > > > When are you going to apply this patch? We can't test linux-next without it. > > I though I sent this with the last series but I can't see that I have. > > I have the rest of that series to send over to Andrew which I was planning to > do > after the current merge window closes (which is about now I guess). > > I'll include it in that series. > Sorry for the hold up, ;) Some bad news I'm afraid. I was getting ready to send these over to Andrew and found that opendir(3) is failing on a number of tests (51 of 230, 9 fails are expected) with 4.6.0. It's not the patches, yours or mine and it doesn't happen with 4.4.x kernels. Looks like I'm going to have to bisect to work out what's going on and that will take a while. > > Ian > > > > > Thanks, > > Andrew > > > > > > On Fri, Apr 1, 2016 at 12:37 AM, Ian Kent wrote: > > > On Thu, 2016-03-31 at 22:12 -0700, Andrey Vagin wrote: > > > > From: Andrey Vagin > > > > > > > > __vfs_write() returns a negative value in a error case. > > > > > > Ha, right, I'll send this along to Andrew with my next series which > > > should be soon. > > > > > > > > > > > Cc: Ian Kent > > > > Signed-off-by: Andrey Vagin > > > > --- > > > > fs/autofs4/waitq.c | 7 ++++--- > > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c > > > > index 0146d91..631f155 100644 > > > > --- a/fs/autofs4/waitq.c > > > > +++ b/fs/autofs4/waitq.c > > > > @@ -66,11 +66,12 @@ static int autofs4_write(struct autofs_sb_info > > > > *sbi, > > > > set_fs(KERNEL_DS); > > > > > > > > mutex_lock(&sbi->pipe_mutex); > > > > - wr = __vfs_write(file, data, bytes, &file->f_pos); > > > > - while (bytes && wr) { > > > > + while (bytes) { > > > > + wr = __vfs_write(file, data, bytes, &file->f_pos); > > > > + if (wr <= 0) > > > > + break; > > > > data += wr; > > > > bytes -= wr; > > > > - wr = __vfs_write(file, data, bytes, &file->f_pos); > > > > } > > > > mutex_unlock(&sbi->pipe_mutex);