From: John Stultz <john.stultz@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: John Stultz <john.stultz@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Baolin Wang <baolin.wang@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Shuah Khan <shuahkh@osg.samsung.com>,
Arnd Bergmann <arnd@arndb.de>, Ingo Molnar <mingo@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Prarit Bhargava <prarit@redhat.com>
Subject: [RFC][PATCH 0/2] Fix for settimeofday() error checking regression
Date: Tue, 31 May 2016 14:32:13 -0700 [thread overview]
Message-ID: <1464730335-21427-1-git-send-email-john.stultz@linaro.org> (raw)
As reported by Mika Westerberg here:
https://lkml.org/lkml/2016/5/30/413
A regression in the settimeofday error checking snuck in via
86d3473224b0 ("time: Introduce do_sys_settimeofday64()"),
effecting cases where the timeval is null but the timezone
was set.
This patchset contains my proposed fix and an addition to
the kselftests to add checks for this case.
Testing/feedback would be greatly appreciated!
thanks
-john
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Baolin Wang <baolin.wang@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Richard Cochran <richardcochran@gmail.com>
Cc: Prarit Bhargava <prarit@redhat.com>
John Stultz (2):
time: Fix problematic change in settimeofday error checking
kselftests: timers: Add set-tz test case
include/linux/timekeeping.h | 3 +
tools/testing/selftests/timers/Makefile | 3 +-
tools/testing/selftests/timers/set-tz.c | 119 ++++++++++++++++++++++++++++++++
3 files changed, 124 insertions(+), 1 deletion(-)
create mode 100644 tools/testing/selftests/timers/set-tz.c
--
1.9.1
next reply other threads:[~2016-05-31 21:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 21:32 John Stultz [this message]
2016-05-31 21:32 ` [RFC][PATCH 1/2] time: Fix problematic change in settimeofday error checking John Stultz
2016-06-01 2:16 ` Dima Stepanov
2016-06-01 10:49 ` Mika Westerberg
2016-05-31 21:32 ` [RFC][PATCH 2/2] kselftests: timers: Add set-tz test case John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464730335-21427-1-git-send-email-john.stultz@linaro.org \
--to=john.stultz@linaro.org \
--cc=arnd@arndb.de \
--cc=baolin.wang@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mingo@kernel.org \
--cc=prarit@redhat.com \
--cc=richardcochran@gmail.com \
--cc=shuahkh@osg.samsung.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).