From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757710AbcFAIfc (ORCPT ); Wed, 1 Jun 2016 04:35:32 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:35494 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757467AbcFAIf2 (ORCPT ); Wed, 1 Jun 2016 04:35:28 -0400 From: Daniel Lezcano To: daniel.lezcano@linaro.org, tglx@linutronix.de Cc: linux-kernel@vger.kernel.org Subject: [PATCH 0/9] clocksource/drivers/clksrc-of: Improve error handling Date: Wed, 1 Jun 2016 10:34:43 +0200 Message-Id: <1464770093-12667-1-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The macro CLOCKSOURCE_OF_DECLARE is widely used in the timer drivers. Basically, this macro is defined to insert in a table a tuple name,function. This function is an init function called when the name matches the DT node and its signature is: typedef void (*of_init_fn_1)(struct device_node *); It does not return an error code. That results in the clocksource-probe not being able to figure out if the driver was correctly initialized or not, the different drivers to act as they were the only ones on the system (panic, instead of failing gracefully), and duplicated code for error reporting. This series initiates the logic change and centralize the error handling in the clocksource probe code. In order to do the changes little by little, a new macro was introduced: CLOCKSOURCE_OF_DECLARE_RET() It expect an init function signature: typedef int (*of_init_ret_fn_1)(struct device_node *); As soon as all drivers will have their init functions signature changed to return a value, CLOCKSOURCE_OF_DECLARE_RET will change its name back to CLOCKSOURCE_OF_DECLARE. Daniel Lezcano (9): of: Add a new macro to declare_of for one parameter function returning a value clocksource/drivers/clksrc-probe: Introduce init functions with return code clocksource/drivers/rockchip_timer: Convert init function to return error clocksource/drivers/mkt_timer: Convert init function to return error clocksource/drivers/exynos_mct: Convert init function to return error clocksource/drivers/asm9260: Convert init function to return error clocksource/drivers/cadence_ttc: Convert init function to return error clocksource/drivers/st_lpc: Convert init function to return error clocksource/drivers/dw_apb_timer: Convert init function to return error drivers/clocksource/asm9260_timer.c | 24 ++++++---- drivers/clocksource/cadence_ttc_timer.c | 82 +++++++++++++++++++-------------- drivers/clocksource/clksrc-probe.c | 22 +++++++++ drivers/clocksource/clksrc_st_lpc.c | 22 +++++---- drivers/clocksource/dw_apb_timer_of.c | 12 +++-- drivers/clocksource/exynos_mct.c | 36 ++++++++++----- drivers/clocksource/mtk_timer.c | 10 ++-- drivers/clocksource/rockchip_timer.c | 12 +++-- include/asm-generic/vmlinux.lds.h | 2 + include/linux/clocksource.h | 3 ++ include/linux/of.h | 3 ++ 11 files changed, 151 insertions(+), 77 deletions(-) -- 1.9.1