From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932163AbcFBIDU (ORCPT ); Thu, 2 Jun 2016 04:03:20 -0400 Received: from wolverine02.qualcomm.com ([199.106.114.251]:9776 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721AbcFBIDP convert rfc822-to-8bit (ORCPT ); Thu, 2 Jun 2016 04:03:15 -0400 X-IronPort-AV: E=Sophos;i="5.26,405,1459839600"; d="scan'208";a="292744571" X-IronPort-AV: E=McAfee;i="5700,7163,8183"; a="709902559" From: "Pan, Miaoqing" To: Sudip Mukherjee , Kalle Valo CC: Stephen Rothwell , ath9k-devel , "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "ath9k-devel@lists.ath9k.org" , "netdev@vger.kernel.org" , Miaoqing Pan Subject: Re: ath9k gpio request Thread-Topic: ath9k gpio request Thread-Index: AQHRuw5qZUYpLTroXEmbqMln9rQM6Z/SIa0AgAIMTrL//8LcgIAAEluAgAHLaKA= Date: Thu, 2 Jun 2016 08:02:50 +0000 Message-ID: <1464854569880.79341@qti.qualcomm.com> References: <20160530132225.4d297678@canb.auug.org.au> <574C4851.9090201@gmail.com> <87fusy3cqx.fsf_-_@kamboji.qca.qualcomm.com>,<574D3EAA.3060102@gmail.com> <1464764036580.70506@qti.qualcomm.com> <574EC331.1080901@gmail.com>,<574ED297.4080004@gmail.com> In-Reply-To: <574ED297.4080004@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [199.106.107.6] Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Seems there are something wrong in the datasheet, try --- a/drivers/net/wireless/ath/ath9k/reg.h +++ b/drivers/net/wireless/ath/ath9k/reg.h @@ -1122,8 +1122,8 @@ enum { #define AR9300_NUM_GPIO 16 #define AR9330_NUM_GPIO 16 #define AR9340_NUM_GPIO 23 -#define AR9462_NUM_GPIO 10 -#define AR9485_NUM_GPIO 12 +#define AR9462_NUM_GPIO 14 +#define AR9485_NUM_GPIO 11 #define AR9531_NUM_GPIO 18 #define AR9550_NUM_GPIO 24 #define AR9561_NUM_GPIO 23 @@ -1139,8 +1139,8 @@ enum { #define AR9300_GPIO_MASK 0x0000F4FF #define AR9330_GPIO_MASK 0x0000F4FF #define AR9340_GPIO_MASK 0x0000000F -#define AR9462_GPIO_MASK 0x000003FF -#define AR9485_GPIO_MASK 0x00000FFF +#define AR9462_GPIO_MASK 0x00003FFF +#define AR9485_GPIO_MASK 0x000007FF #define AR9531_GPIO_MASK 0x0000000F #define AR9550_GPIO_MASK 0x0000000F #define AR9561_GPIO_MASK 0x0000000F Thanks, Miaoqing ________________________________________ From: Sudip Mukherjee Sent: Wednesday, June 1, 2016 8:18 PM To: Pan, Miaoqing; Kalle Valo Cc: Stephen Rothwell; ath9k-devel; linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; linux-wireless@vger.kernel.org; ath9k-devel@lists.ath9k.org; netdev@vger.kernel.org; Miaoqing Pan Subject: Re: ath9k gpio request On Wednesday 01 June 2016 04:42 PM, Sudip Mukherjee wrote: > On Wednesday 01 June 2016 12:24 PM, Pan, Miaoqing wrote: >> which chip ? And what's the GPIO number ? > > lspci -v reports: > 09:00.0 Network controller: Qualcomm Atheros AR9462 Wireless Network > Adapter (rev 01) > Subsystem: Foxconn International, Inc. Device e052 > Flags: bus master, fast devsel, latency 0, IRQ 19 > Memory at c0500000 (64-bit, non-prefetchable) [size=512K] > Expansion ROM at c0580000 [disabled] [size=64K] > Capabilities: [40] Power Management version 2 > Capabilities: [50] MSI: Enable- Count=1/4 Maskable+ 64bit+ > Capabilities: [70] Express Endpoint, MSI 00 > Capabilities: [100] Advanced Error Reporting > Capabilities: [140] Virtual Channel > Capabilities: [160] Device Serial Number 00-00-00-00-00-00-00-00 > Kernel driver in use: ath9k > > Any easy way to find out the gpio number or i can modify the module to > find that out. Its trying for GPIO 11 with label ath9k-rfkill. The attached dmesg is with some modification as below. diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c index 8b2895f9..23deea7 100644 --- a/drivers/net/wireless/ath/ath9k/hw.c +++ b/drivers/net/wireless/ath/ath9k/hw.c @@ -2729,14 +2729,16 @@ static void ath9k_hw_gpio_cfg_wmac(struct ath_hw *ah, u32 gpio, bool out, static void ath9k_hw_gpio_request(struct ath_hw *ah, u32 gpio, bool out, const char *label, u32 ah_signal_type) { - WARN_ON(gpio >= ah->caps.num_gpio_pins); +// WARN_ON(gpio >= ah->caps.num_gpio_pins); + + pr_err("sudip: %d %s\n", gpio, label); if (BIT(gpio) & ah->caps.gpio_mask) ath9k_hw_gpio_cfg_wmac(ah, gpio, out, ah_signal_type); else if (AR_SREV_SOC(ah)) ath9k_hw_gpio_cfg_soc(ah, gpio, out, label); - else - WARN_ON(1); +// else +// WARN_ON(1); } Regards Sudip