From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@intel.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-samsung-soc@vger.kernel.org,
intel-gfx@lists.freedesktop.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Alexey Brodkin <abrodkin@synopsys.com>,
Inki Dae <inki.dae@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Stefan Agner <stefan@agner.ch>,
Alison Wang <alison.wang@freescale.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Clark <robdclark@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mark Yao <mark.yao@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Vincent Abriou <vincent.abriou@st.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>,
Thierry Reding <thierry.reding@gmail.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Alexandre Courbot <gnurou@gmail.com>,
Eric Anholt <eric@anholt.net>, Gerd Hoffmann <kraxel@redhat.com>,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Boris Brezillon <boris.brezillon@free-electrons.com>
Subject: [PATCH 02/20] drm: arc: Rely on the default ->best_encoder() behavior
Date: Thu, 2 Jun 2016 16:31:29 +0200 [thread overview]
Message-ID: <1464877907-27723-3-git-send-email-boris.brezillon@free-electrons.com> (raw)
In-Reply-To: <1464877907-27723-1-git-send-email-boris.brezillon@free-electrons.com>
We have a 1:1 relationship between connectors and encoders and the
driver is relying on the atomic helpers: we can drop the custom
->best_encoder(), and let the core call drm_atomic_helper_best_encoder()
for us.
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
---
drivers/gpu/drm/arc/arcpgu_hdmi.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/gpu/drm/arc/arcpgu_hdmi.c b/drivers/gpu/drm/arc/arcpgu_hdmi.c
index 08b6bae..b7a8b2a 100644
--- a/drivers/gpu/drm/arc/arcpgu_hdmi.c
+++ b/drivers/gpu/drm/arc/arcpgu_hdmi.c
@@ -46,23 +46,6 @@ static int arcpgu_drm_connector_get_modes(struct drm_connector *connector)
return sfuncs->get_modes(&slave->base, connector);
}
-struct drm_encoder *
-arcpgu_drm_connector_best_encoder(struct drm_connector *connector)
-{
- struct drm_encoder_slave *slave;
- struct arcpgu_drm_connector *con =
- container_of(connector, struct arcpgu_drm_connector, connector);
-
- slave = con->encoder_slave;
- if (slave == NULL) {
- dev_err(connector->dev->dev,
- "connector_best_encoder: cannot find slave encoder for connector\n");
- return NULL;
- }
-
- return &slave->base;
-}
-
static enum drm_connector_status
arcpgu_drm_connector_detect(struct drm_connector *connector, bool force)
{
@@ -97,7 +80,6 @@ static void arcpgu_drm_connector_destroy(struct drm_connector *connector)
static const struct drm_connector_helper_funcs
arcpgu_drm_connector_helper_funcs = {
.get_modes = arcpgu_drm_connector_get_modes,
- .best_encoder = arcpgu_drm_connector_best_encoder,
};
static const struct drm_connector_funcs arcpgu_drm_connector_funcs = {
--
2.7.4
next prev parent reply other threads:[~2016-06-02 14:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 14:31 [PATCH 00/20] drm/atomic: Provide default ->best_encoder() behavior Boris Brezillon
2016-06-02 14:31 ` [PATCH 01/20] drm/atomic: Fix remaining places where !funcs->best_encoder is valid Boris Brezillon
2016-06-02 21:05 ` Laurent Pinchart
2016-06-02 21:57 ` Daniel Vetter
2016-06-02 22:40 ` [Intel-gfx] " Chris Wilson
2016-06-03 7:37 ` Boris Brezillon
2016-06-03 19:01 ` Daniel Vetter
2016-06-03 7:36 ` Boris Brezillon
2016-06-02 14:31 ` Boris Brezillon [this message]
2016-06-02 14:31 ` [PATCH 03/20] drm: atmel-hlcdc: Rely on the default ->best_encoder() behavior Boris Brezillon
2016-06-02 14:31 ` [PATCH 04/20] drm: exynos: " Boris Brezillon
2016-06-02 14:31 ` [PATCH 05/20] drm: fsl-dcu: " Boris Brezillon
2016-06-02 14:31 ` [PATCH 06/20] drm: i915: Rely on the default ->best_encoder() behavior where appropriate Boris Brezillon
2016-06-02 14:31 ` [PATCH 07/20] drm: mediatek: Rely on the default ->best_encoder() behavior Boris Brezillon
2016-06-02 14:31 ` [PATCH 08/20] drm: msm: Rely on the default ->best_encoder() behavior where appropriate Boris Brezillon
2016-06-02 14:31 ` [PATCH 09/20] drm: rcar-du: Rely on the default ->best_encoder() behavior Boris Brezillon
2016-06-02 20:57 ` Laurent Pinchart
2016-06-03 7:38 ` Boris Brezillon
2016-06-02 14:31 ` [PATCH 10/20] drm: rockchip: " Boris Brezillon
2016-06-07 0:51 ` Mark yao
2016-06-02 14:31 ` [PATCH 11/20] drm: sti: " Boris Brezillon
2016-06-02 14:31 ` [PATCH 12/20] drm: sun4i: " Boris Brezillon
2016-06-02 14:31 ` [PATCH 13/20] drm: tegra: " Boris Brezillon
2016-06-02 14:31 ` [PATCH 14/20] drm: vc4: " Boris Brezillon
2016-06-02 14:31 ` [PATCH 15/20] drm: virtgpu: " Boris Brezillon
2016-06-02 14:31 ` [PATCH 16/20] drm: omap: " Boris Brezillon
2016-06-02 21:00 ` Laurent Pinchart
2016-06-02 14:31 ` [PATCH 17/20] drm/bridge: anx78xx: " Boris Brezillon
2016-06-02 14:31 ` [PATCH 18/20] drm/bridge: ptn3460: " Boris Brezillon
2016-06-02 14:31 ` [PATCH 19/20] drm/bridge: ps8622: " Boris Brezillon
2016-06-02 14:31 ` [PATCH 20/20] drm/bridge: dw-hdmi: Use drm_atomic_helper_best_encoder() Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464877907-27723-3-git-send-email-boris.brezillon@free-electrons.com \
--to=boris.brezillon@free-electrons.com \
--cc=abrodkin@synopsys.com \
--cc=airlied@linux.ie \
--cc=alison.wang@freescale.com \
--cc=benjamin.gaignard@linaro.org \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=freedreno@lists.freedesktop.org \
--cc=gnurou@gmail.com \
--cc=heiko@sntech.de \
--cc=inki.dae@samsung.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jy0922.shim@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kraxel@redhat.com \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.yao@rock-chips.com \
--cc=matthias.bgg@gmail.com \
--cc=maxime.ripard@free-electrons.com \
--cc=robdclark@gmail.com \
--cc=stefan@agner.ch \
--cc=sw0312.kim@samsung.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=vincent.abriou@st.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).