* [PATCH 1/6] clk: Add missing clk_get_sys() stub
@ 2016-06-02 21:41 Daniel Lezcano
2016-06-02 21:41 ` [PATCH 2/6] clocksource/drivers/bcm_kona: Remove useless header <asm/mach/time.h> Daniel Lezcano
` (7 more replies)
0 siblings, 8 replies; 10+ messages in thread
From: Daniel Lezcano @ 2016-06-02 21:41 UTC (permalink / raw)
To: daniel.lezcano, tglx; +Cc: linux-kernel, Russell King, open list:CLK API
When compiling with the COMPILE_TEST option set, the clps711x does not
compile because of the clk_get_sys() noop stub missing.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
include/linux/clk.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/linux/clk.h b/include/linux/clk.h
index 0df4a51..834179f 100644
--- a/include/linux/clk.h
+++ b/include/linux/clk.h
@@ -461,6 +461,10 @@ static inline struct clk *clk_get_parent(struct clk *clk)
return NULL;
}
+static inline struct clk *clk_get_sys(const char *dev_id, const char *con_id)
+{
+ return NULL;
+}
#endif
/* clk_prepare_enable helps cases using clk_enable in non-atomic context. */
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/6] clocksource/drivers/bcm_kona: Remove useless header <asm/mach/time.h>
2016-06-02 21:41 [PATCH 1/6] clk: Add missing clk_get_sys() stub Daniel Lezcano
@ 2016-06-02 21:41 ` Daniel Lezcano
2016-06-02 21:41 ` [PATCH 3/6] clocksource/drivers/bcm2835: Add the COMPILE_TEST option Daniel Lezcano
` (6 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Daniel Lezcano @ 2016-06-02 21:41 UTC (permalink / raw)
To: daniel.lezcano, tglx
Cc: linux-kernel, Florian Fainelli, Ray Jui, Scott Branden,
open list:BROADCOM BCM281XX...
The driver includes the <asm/mach/time.h> header but it is pointless.
Remove it.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/clocksource/bcm_kona_timer.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clocksource/bcm_kona_timer.c b/drivers/clocksource/bcm_kona_timer.c
index e717e87..fd11d59 100644
--- a/drivers/clocksource/bcm_kona_timer.c
+++ b/drivers/clocksource/bcm_kona_timer.c
@@ -20,7 +20,6 @@
#include <linux/clk.h>
#include <linux/io.h>
-#include <asm/mach/time.h>
#include <linux/of.h>
#include <linux/of_address.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/6] clocksource/drivers/bcm2835: Add the COMPILE_TEST option
2016-06-02 21:41 [PATCH 1/6] clk: Add missing clk_get_sys() stub Daniel Lezcano
2016-06-02 21:41 ` [PATCH 2/6] clocksource/drivers/bcm_kona: Remove useless header <asm/mach/time.h> Daniel Lezcano
@ 2016-06-02 21:41 ` Daniel Lezcano
2016-06-02 21:41 ` [PATCH 4/6] clocksource/drivers/armv7m_systick: " Daniel Lezcano
` (5 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Daniel Lezcano @ 2016-06-02 21:41 UTC (permalink / raw)
To: daniel.lezcano, tglx
Cc: linux-kernel, Florian Fainelli, Ray Jui, Scott Branden,
Russell King, moderated list:ARM SUB-ARCHITECT...,
open list:BROADCOM BCM281XX...
Change the Kconfig option logic to fullfil with the current approach.
A new Kconfig option is added, CONFIG_BCM2835_TIMER and is selected by the
platform. Then the clocksource's Kconfig is changed to make this option
selectable by the user if the COMPILE_TEST option is set. Otherwise, it
is up to the platform's Kconfig to select the timer.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
arch/arm/mach-bcm/Kconfig | 1 +
drivers/clocksource/Kconfig | 7 +++++++
drivers/clocksource/Makefile | 2 +-
3 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index 7ef1214..b7414df 100644
--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig
@@ -143,6 +143,7 @@ config ARCH_BCM2835
select ARM_TIMER_SP804
select HAVE_ARM_ARCH_TIMER if ARCH_MULTI_V7
select CLKSRC_OF
+ select BCM2835_TIMER
select PINCTRL
select PINCTRL_BCM2835
help
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 6ff327a..34053ab 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -27,6 +27,13 @@ config CLKBLD_I8253
config CLKSRC_MMIO
bool
+config BCM2835_TIMER
+ bool "BCM2835 timer driver" if COMPILE_TEST
+ depends on GENERIC_CLOCKEVENTS
+ select CLKSRC_MMIO
+ help
+ Enables the support for the BCM2835 timer driver.
+
config DIGICOLOR_TIMER
bool "Digicolor timer driver" if COMPILE_TEST
depends on GENERIC_CLOCKEVENTS
diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile
index b0a3c96..6e278d4 100644
--- a/drivers/clocksource/Makefile
+++ b/drivers/clocksource/Makefile
@@ -19,7 +19,7 @@ obj-$(CONFIG_CLKSRC_NOMADIK_MTU) += nomadik-mtu.o
obj-$(CONFIG_CLKSRC_DBX500_PRCMU) += clksrc-dbx500-prcmu.o
obj-$(CONFIG_ARMADA_370_XP_TIMER) += time-armada-370-xp.o
obj-$(CONFIG_ORION_TIMER) += time-orion.o
-obj-$(CONFIG_ARCH_BCM2835) += bcm2835_timer.o
+obj-$(CONFIG_BCM2835_TIMER) += bcm2835_timer.o
obj-$(CONFIG_ARCH_CLPS711X) += clps711x-timer.o
obj-$(CONFIG_ARCH_ATLAS7) += timer-atlas7.o
obj-$(CONFIG_ARCH_MOXART) += moxart_timer.o
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/6] clocksource/drivers/armv7m_systick: Add the COMPILE_TEST option
2016-06-02 21:41 [PATCH 1/6] clk: Add missing clk_get_sys() stub Daniel Lezcano
2016-06-02 21:41 ` [PATCH 2/6] clocksource/drivers/bcm_kona: Remove useless header <asm/mach/time.h> Daniel Lezcano
2016-06-02 21:41 ` [PATCH 3/6] clocksource/drivers/bcm2835: Add the COMPILE_TEST option Daniel Lezcano
@ 2016-06-02 21:41 ` Daniel Lezcano
2016-06-03 5:14 ` kbuild test robot
2016-06-02 21:41 ` [PATCH 5/6] clocksource/drivers/bcm_kona: " Daniel Lezcano
` (4 subsequent siblings)
7 siblings, 1 reply; 10+ messages in thread
From: Daniel Lezcano @ 2016-06-02 21:41 UTC (permalink / raw)
To: daniel.lezcano, tglx; +Cc: linux-kernel
In order to increase the compilation test coverage, add the COMPILE_TEST
so the driver can be compiled even if it does not belong to the platform
or the architecture.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/clocksource/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 34053ab..a1e0cf9 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -240,7 +240,7 @@ config CLKSRC_ARM_GLOBAL_TIMER_SCHED_CLOCK
Use ARM global timer clock source as sched_clock
config ARMV7M_SYSTICK
- bool
+ bool "Support for the ARMv7M system time" if COMPILE_TEST
select CLKSRC_OF if OF
select CLKSRC_MMIO
help
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 5/6] clocksource/drivers/bcm_kona: Add the COMPILE_TEST option
2016-06-02 21:41 [PATCH 1/6] clk: Add missing clk_get_sys() stub Daniel Lezcano
` (2 preceding siblings ...)
2016-06-02 21:41 ` [PATCH 4/6] clocksource/drivers/armv7m_systick: " Daniel Lezcano
@ 2016-06-02 21:41 ` Daniel Lezcano
2016-06-02 21:41 ` [PATCH 6/6] clocksource/drivers/clps_711x: " Daniel Lezcano
` (3 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Daniel Lezcano @ 2016-06-02 21:41 UTC (permalink / raw)
To: daniel.lezcano, tglx
Cc: linux-kernel, Florian Fainelli, Ray Jui, Scott Branden,
Russell King, moderated list:ARM SUB-ARCHITECT...,
open list:BROADCOM BCM281XX...
Change the Kconfig option logic to fullfil with the current approach.
A new Kconfig option is added, CONFIG_BCM_KONA_TIMER and is selected by the
platform. Then the clocksource's Kconfig is changed to make this option
selectable by the user if the COMPILE_TEST option is set. Otherwise, it is
up to the platform's Kconfig to select the timer.
The timer uses <asm/mach/time.h>, which is now only for ARM, so this
driver will depend on ARM.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
arch/arm/mach-bcm/Kconfig | 1 +
drivers/clocksource/Kconfig | 7 +++++++
drivers/clocksource/Makefile | 2 +-
3 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index b7414df..e32ef5b 100644
--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig
@@ -89,6 +89,7 @@ config ARCH_BCM_MOBILE
select HAVE_ARM_ARCH_TIMER
select PINCTRL
select ARCH_BCM_MOBILE_SMP if SMP
+ select BCM_KONA_TIMER
help
This enables support for systems based on Broadcom mobile SoCs.
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index a1e0cf9..6714a22 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -34,6 +34,13 @@ config BCM2835_TIMER
help
Enables the support for the BCM2835 timer driver.
+config BCM_KONA_TIMER
+ bool "BCM mobile timer driver" if COMPILE_TEST
+ depends on GENERIC_CLOCKEVENTS
+ select CLKSRC_MMIO
+ help
+ Enables the support for the BCM Kona mobile timer driver.
+
config DIGICOLOR_TIMER
bool "Digicolor timer driver" if COMPILE_TEST
depends on GENERIC_CLOCKEVENTS
diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile
index 6e278d4..662a87c 100644
--- a/drivers/clocksource/Makefile
+++ b/drivers/clocksource/Makefile
@@ -33,7 +33,7 @@ obj-$(CONFIG_MESON6_TIMER) += meson6_timer.o
obj-$(CONFIG_TEGRA_TIMER) += tegra20_timer.o
obj-$(CONFIG_VT8500_TIMER) += vt8500_timer.o
obj-$(CONFIG_ARCH_NSPIRE) += zevio-timer.o
-obj-$(CONFIG_ARCH_BCM_MOBILE) += bcm_kona_timer.o
+obj-$(CONFIG_BCM_KONA_TIMER) += bcm_kona_timer.o
obj-$(CONFIG_CADENCE_TTC_TIMER) += cadence_ttc_timer.o
obj-$(CONFIG_CLKSRC_EFM32) += time-efm32.o
obj-$(CONFIG_CLKSRC_STM32) += timer-stm32.o
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 6/6] clocksource/drivers/clps_711x: Add the COMPILE_TEST option
2016-06-02 21:41 [PATCH 1/6] clk: Add missing clk_get_sys() stub Daniel Lezcano
` (3 preceding siblings ...)
2016-06-02 21:41 ` [PATCH 5/6] clocksource/drivers/bcm_kona: " Daniel Lezcano
@ 2016-06-02 21:41 ` Daniel Lezcano
2016-06-06 7:19 ` [PATCH 1/6] clk: Add missing clk_get_sys() stub Daniel Lezcano
` (2 subsequent siblings)
7 siblings, 0 replies; 10+ messages in thread
From: Daniel Lezcano @ 2016-06-02 21:41 UTC (permalink / raw)
To: daniel.lezcano, tglx; +Cc: linux-kernel, Russell King, moderated list:ARM PORT
Change the Kconfig option logic to fullfil with the current approach.
A new Kconfig option is added, CONFIG_BCM_KONA_TIMER and is selected by the
platform. Then the clocksource's Kconfig is changed to make this option
selectable by the user if the COMPILE_TEST option is set. Otherwise, it is
up to the platform's Kconfig to select the timer.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
arch/arm/Kconfig | 2 +-
drivers/clocksource/Kconfig | 7 +++++++
drivers/clocksource/Makefile | 2 +-
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index cdfa6c2..0c1f546 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -356,10 +356,10 @@ config ARCH_CLPS711X
bool "Cirrus Logic CLPS711x/EP721x/EP731x-based"
select ARCH_REQUIRE_GPIOLIB
select AUTO_ZRELADDR
- select CLKSRC_MMIO
select COMMON_CLK
select CPU_ARM720T
select GENERIC_CLOCKEVENTS
+ select CLPS711X_TIMER
select MFD_SYSCON
select SOC_BUS
help
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 6714a22..e92a814 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -155,6 +155,13 @@ config CLKSRC_DBX500_PRCMU
help
Use the always on PRCMU Timer as clocksource
+config CLPS711X_TIMER
+ bool "Cirrus logic timer driver" if COMPILE_TEST
+ depends on GENERIC_CLOCKEVENTS
+ select CLKSRC_MMIO
+ help
+ Enables support for the Cirrus Logic PS711 timer.
+
config CLKSRC_DBX500_PRCMU_SCHED_CLOCK
bool "Clocksource PRCMU Timer sched_clock"
depends on (CLKSRC_DBX500_PRCMU && !CLKSRC_NOMADIK_MTU_SCHED_CLOCK)
diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile
index 662a87c..ae6c09f 100644
--- a/drivers/clocksource/Makefile
+++ b/drivers/clocksource/Makefile
@@ -20,7 +20,7 @@ obj-$(CONFIG_CLKSRC_DBX500_PRCMU) += clksrc-dbx500-prcmu.o
obj-$(CONFIG_ARMADA_370_XP_TIMER) += time-armada-370-xp.o
obj-$(CONFIG_ORION_TIMER) += time-orion.o
obj-$(CONFIG_BCM2835_TIMER) += bcm2835_timer.o
-obj-$(CONFIG_ARCH_CLPS711X) += clps711x-timer.o
+obj-$(CONFIG_CLPS711X_TIMER) += clps711x-timer.o
obj-$(CONFIG_ARCH_ATLAS7) += timer-atlas7.o
obj-$(CONFIG_ARCH_MOXART) += moxart_timer.o
obj-$(CONFIG_ARCH_MXS) += mxs_timer.o
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 4/6] clocksource/drivers/armv7m_systick: Add the COMPILE_TEST option
2016-06-02 21:41 ` [PATCH 4/6] clocksource/drivers/armv7m_systick: " Daniel Lezcano
@ 2016-06-03 5:14 ` kbuild test robot
0 siblings, 0 replies; 10+ messages in thread
From: kbuild test robot @ 2016-06-03 5:14 UTC (permalink / raw)
To: Daniel Lezcano; +Cc: kbuild-all, daniel.lezcano, tglx, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2669 bytes --]
Hi,
[auto build test ERROR on tip/timers/core]
[also build test ERROR on v4.7-rc1 next-20160602]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Daniel-Lezcano/clk-Add-missing-clk_get_sys-stub/20160603-054643
config: um-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
# save the attached .config to linux build tree
make ARCH=um
All errors (new ones prefixed by >>):
drivers/clocksource/armv7m_systick.c: In function 'system_timer_of_register':
>> drivers/clocksource/armv7m_systick.c:74:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration]
iounmap(base);
^~~~~~~
cc1: some warnings being treated as errors
vim +/iounmap +74 drivers/clocksource/armv7m_systick.c
4958ebb3 Maxime Coquelin 2015-05-09 58 pr_err("failed to init clocksource (%d)\n", ret);
4958ebb3 Maxime Coquelin 2015-05-09 59 if (clk)
4958ebb3 Maxime Coquelin 2015-05-09 60 goto out_clk_disable;
4958ebb3 Maxime Coquelin 2015-05-09 61 else
4958ebb3 Maxime Coquelin 2015-05-09 62 goto out_unmap;
4958ebb3 Maxime Coquelin 2015-05-09 63 }
4958ebb3 Maxime Coquelin 2015-05-09 64
4958ebb3 Maxime Coquelin 2015-05-09 65 pr_info("ARM System timer initialized as clocksource\n");
4958ebb3 Maxime Coquelin 2015-05-09 66
4958ebb3 Maxime Coquelin 2015-05-09 67 return;
4958ebb3 Maxime Coquelin 2015-05-09 68
4958ebb3 Maxime Coquelin 2015-05-09 69 out_clk_disable:
4958ebb3 Maxime Coquelin 2015-05-09 70 clk_disable_unprepare(clk);
4958ebb3 Maxime Coquelin 2015-05-09 71 out_clk_put:
4958ebb3 Maxime Coquelin 2015-05-09 72 clk_put(clk);
4958ebb3 Maxime Coquelin 2015-05-09 73 out_unmap:
4958ebb3 Maxime Coquelin 2015-05-09 @74 iounmap(base);
4958ebb3 Maxime Coquelin 2015-05-09 75 pr_warn("ARM System timer register failed (%d)\n", ret);
4958ebb3 Maxime Coquelin 2015-05-09 76 }
4958ebb3 Maxime Coquelin 2015-05-09 77
4958ebb3 Maxime Coquelin 2015-05-09 78 CLOCKSOURCE_OF_DECLARE(arm_systick, "arm,armv7m-systick",
4958ebb3 Maxime Coquelin 2015-05-09 79 system_timer_of_register);
:::::: The code at line 74 was first introduced by commit
:::::: 4958ebb3d027886c46b936453745dba59b09c578 clocksource/drivers/armv7m_systick: Add ARM System timer driver
:::::: TO: Maxime Coquelin <mcoquelin.stm32@gmail.com>
:::::: CC: Daniel Lezcano <daniel.lezcano@linaro.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 17713 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/6] clk: Add missing clk_get_sys() stub
2016-06-02 21:41 [PATCH 1/6] clk: Add missing clk_get_sys() stub Daniel Lezcano
` (4 preceding siblings ...)
2016-06-02 21:41 ` [PATCH 6/6] clocksource/drivers/clps_711x: " Daniel Lezcano
@ 2016-06-06 7:19 ` Daniel Lezcano
2016-06-13 8:18 ` Daniel Lezcano
2016-06-20 21:18 ` Michael Turquette
7 siblings, 0 replies; 10+ messages in thread
From: Daniel Lezcano @ 2016-06-06 7:19 UTC (permalink / raw)
To: tglx
Cc: linux-kernel, Russell King, open list:CLK API, mike.turquette,
Stephen Boyd
On 06/02/2016 11:41 PM, Daniel Lezcano wrote:
> When compiling with the COMPILE_TEST option set, the clps711x does not
> compile because of the clk_get_sys() noop stub missing.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Added missing Cc [Mike and Stephen]
> ---
> include/linux/clk.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/clk.h b/include/linux/clk.h
> index 0df4a51..834179f 100644
> --- a/include/linux/clk.h
> +++ b/include/linux/clk.h
> @@ -461,6 +461,10 @@ static inline struct clk *clk_get_parent(struct clk *clk)
> return NULL;
> }
>
> +static inline struct clk *clk_get_sys(const char *dev_id, const char *con_id)
> +{
> + return NULL;
> +}
> #endif
>
> /* clk_prepare_enable helps cases using clk_enable in non-atomic context. */
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/6] clk: Add missing clk_get_sys() stub
2016-06-02 21:41 [PATCH 1/6] clk: Add missing clk_get_sys() stub Daniel Lezcano
` (5 preceding siblings ...)
2016-06-06 7:19 ` [PATCH 1/6] clk: Add missing clk_get_sys() stub Daniel Lezcano
@ 2016-06-13 8:18 ` Daniel Lezcano
2016-06-20 21:18 ` Michael Turquette
7 siblings, 0 replies; 10+ messages in thread
From: Daniel Lezcano @ 2016-06-13 8:18 UTC (permalink / raw)
To: tglx; +Cc: linux-kernel, Russell King, open list:CLK API, Mike Turquette
On 06/02/2016 11:41 PM, Daniel Lezcano wrote:
> When compiling with the COMPILE_TEST option set, the clps711x does not
> compile because of the clk_get_sys() noop stub missing.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
Hi,
is this patch fine ? Can I pick it through my tree ?
Thanks.
-- Daniel
> include/linux/clk.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/clk.h b/include/linux/clk.h
> index 0df4a51..834179f 100644
> --- a/include/linux/clk.h
> +++ b/include/linux/clk.h
> @@ -461,6 +461,10 @@ static inline struct clk *clk_get_parent(struct clk *clk)
> return NULL;
> }
>
> +static inline struct clk *clk_get_sys(const char *dev_id, const char *con_id)
> +{
> + return NULL;
> +}
> #endif
>
> /* clk_prepare_enable helps cases using clk_enable in non-atomic context. */
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/6] clk: Add missing clk_get_sys() stub
2016-06-02 21:41 [PATCH 1/6] clk: Add missing clk_get_sys() stub Daniel Lezcano
` (6 preceding siblings ...)
2016-06-13 8:18 ` Daniel Lezcano
@ 2016-06-20 21:18 ` Michael Turquette
7 siblings, 0 replies; 10+ messages in thread
From: Michael Turquette @ 2016-06-20 21:18 UTC (permalink / raw)
To: Daniel Lezcano, daniel.lezcano, tglx
Cc: linux-kernel, Russell King, open list:CLK API
Hi Daniel,
Quoting Daniel Lezcano (2016-06-02 14:41:32)
> When compiling with the COMPILE_TEST option set, the clps711x does not
> compile because of the clk_get_sys() noop stub missing.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
This looks OK to me. Russell maintains clkdev and the clk.h stuff, so it
would be good to get his ack. Please feel free to add:
Reviewed-by: Michael Turquette <mturquette@baylibre.com>
Regards,
Mike
> ---
> include/linux/clk.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/clk.h b/include/linux/clk.h
> index 0df4a51..834179f 100644
> --- a/include/linux/clk.h
> +++ b/include/linux/clk.h
> @@ -461,6 +461,10 @@ static inline struct clk *clk_get_parent(struct clk *clk)
> return NULL;
> }
>
> +static inline struct clk *clk_get_sys(const char *dev_id, const char *con_id)
> +{
> + return NULL;
> +}
> #endif
>
> /* clk_prepare_enable helps cases using clk_enable in non-atomic context. */
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-06-20 21:19 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-02 21:41 [PATCH 1/6] clk: Add missing clk_get_sys() stub Daniel Lezcano
2016-06-02 21:41 ` [PATCH 2/6] clocksource/drivers/bcm_kona: Remove useless header <asm/mach/time.h> Daniel Lezcano
2016-06-02 21:41 ` [PATCH 3/6] clocksource/drivers/bcm2835: Add the COMPILE_TEST option Daniel Lezcano
2016-06-02 21:41 ` [PATCH 4/6] clocksource/drivers/armv7m_systick: " Daniel Lezcano
2016-06-03 5:14 ` kbuild test robot
2016-06-02 21:41 ` [PATCH 5/6] clocksource/drivers/bcm_kona: " Daniel Lezcano
2016-06-02 21:41 ` [PATCH 6/6] clocksource/drivers/clps_711x: " Daniel Lezcano
2016-06-06 7:19 ` [PATCH 1/6] clk: Add missing clk_get_sys() stub Daniel Lezcano
2016-06-13 8:18 ` Daniel Lezcano
2016-06-20 21:18 ` Michael Turquette
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).