From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752058AbcFCAkW (ORCPT ); Thu, 2 Jun 2016 20:40:22 -0400 Received: from mail.windriver.com ([147.11.1.11]:53849 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751041AbcFCAkU (ORCPT ); Thu, 2 Jun 2016 20:40:20 -0400 From: Paul Gortmaker To: linux-kernel@vger.kernel.org, Lee Jones , Kyungmin Park , Javier Martinez Canillas Cc: Paul Gortmaker , Chanwoo Choi , Haojian Zhuang , Krzysztof Kozlowski , MyungJoo Ham , Samuel Ortiz Subject: [PATCH v2 0/5] mfd: Make max drivers explicitly non-modular Date: Thu, 2 Jun 2016 20:39:45 -0400 Message-Id: <1464914390-23520-1-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.4.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For anyone new to the underlying goal of this cleanup, we are trying to make driver code consistent with the Makefiles/Kconfigs that control them. This means not using modular functions/macros for drivers that can never be built as a module. Some of the other downfalls this leads to are: (1) it is easy to accidentally write unused module_exit and remove code (2) it can be misleading when reading the source, thinking it can be modular when the Makefile and/or Kconfig prohibit it (3) it requires the include of the module.h header file which in turn includes nearly everything else, thus adding to CPP overhead. (4) it gets copied/replicated into other drivers and spreads like weeds. There are quite a few in the mfd space, so rather than send a large series, I'll try and batch them up into reasonable sized queues. To that end, here we fix up all the maxim drivers as the 1st mfd batch. As always, the option exists for someone with the hardware and the desire to extend the functionality to make any given driver tristate. But given the number of these tree wide and the fact that I can't test that new extended functionality in all cases, I just make the code consistent with the existing Kconfig/Makefile settings that restrict them to "bool". Build tested on linux-next for arm, arm64 and x86-64 to ensure no typos or similar issues crept in. Paul. --- [v2: - drop two patches for drivers getting tristate conversion from JMC. - fix up shortlog/subjects to match existing mfd style/convention. - rebase to current linux-next and redo build testing. ] [v1: https://lkml.kernel.org/r/1459718659-28316-1-git-send-email-paul.gortmaker@windriver.com ] Cc: Chanwoo Choi Cc: Haojian Zhuang Cc: Krzysztof Kozlowski Cc: Kyungmin Park Cc: Lee Jones Cc: Javier Martinez Canillas Cc: MyungJoo Ham Cc: Samuel Ortiz Paul Gortmaker (5): mfd: max8925-i2c: Make it explicitly non-modular mfd: max8997: Make it explicitly non-modular mfd: max8998: Make it explicitly non-modular mfd: max77620: make it explicitly non-modular mfd: max77843: Make it explicitly non-modular drivers/mfd/max77620.c | 12 ++---------- drivers/mfd/max77843.c | 24 ++---------------------- drivers/mfd/max8925-i2c.c | 14 +------------- drivers/mfd/max8997.c | 30 +++--------------------------- drivers/mfd/max8998.c | 27 +-------------------------- 5 files changed, 9 insertions(+), 98 deletions(-) -- 2.4.3