From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751183AbcFDCQa (ORCPT ); Fri, 3 Jun 2016 22:16:30 -0400 Received: from p3plsmtps2ded01.prod.phx3.secureserver.net ([208.109.80.58]:46401 "EHLO p3plsmtps2ded01.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbcFDCQ3 (ORCPT ); Fri, 3 Jun 2016 22:16:29 -0400 x-originating-ip: 72.167.245.219 From: Long Li To: "James E.J. Bottomley" , "Martin K. Petersen" Cc: Long Li , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] sd: remove redundant check for BLK_DEF_MAX_SECTORS Date: Fri, 3 Jun 2016 20:57:58 -0700 Message-Id: <1465012678-32547-1-git-send-email-longli@microsoft.com> X-Mailer: git-send-email 1.7.4.1 X-CMAE-Envelope: MS4wfIRVXIijeNwmsCfRUgYqeBSV9k9fNc0tT0+MEGQ67XC4aAsx7uaLHacIy4hk9nh+kI5geAVDWnUjktTVphOGAxq3kRk9/QByzTrtZaQ7idmMhJK2bA/m lhBdgyzAZpfId+usj7tPtPtB5JILrr68uu2BTAzaEJ1iPizJQp1zuk4GUxR8IlN5TynPrhpucVSUATaGBSjYyrBR4CE1GnWjRXBJxi/LJO4H4Xptx+RPIPgD bVBrqQ+GQbx+v09YtaujsA7H9Mhs8zxC4Uu6OaEgu4i8mAZw/74jR7nNplfUEzWMG0nrflZumQ+NOM3gPnY17xxBYcewO+wppzo9ZdrLoqw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org q->limits.max_sectors is already checked against BLK_DEF_MAX_SECTORS in __scsi_alloc_queue(), when it calls blk_queue_max_hw_sectors(). There is no need to check it again in sd. This change also allows a SCSI driver set an maximum sector size bigger than BLK_DEF_MAX_SECTORS, without returning values on optional VPD page 0xb0 "Block Limits". Signed-off-by: Long Li --- drivers/scsi/sd.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 60bff78..d8c4047 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -2870,11 +2870,8 @@ static int sd_revalidate_disk(struct gendisk *disk) logical_to_bytes(sdp, sdkp->opt_xfer_blocks) >= PAGE_SIZE) { q->limits.io_opt = logical_to_bytes(sdp, sdkp->opt_xfer_blocks); rw_max = logical_to_sectors(sdp, sdkp->opt_xfer_blocks); - } else - rw_max = BLK_DEF_MAX_SECTORS; - - /* Combine with controller limits */ - q->limits.max_sectors = min(rw_max, queue_max_hw_sectors(q)); + q->limits.max_sectors = min(rw_max, queue_max_hw_sectors(q)); + } set_capacity(disk, logical_to_sectors(sdp, sdkp->capacity)); sd_config_write_same(sdkp); -- 2.7.4