From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751089AbcFDQ3O (ORCPT ); Sat, 4 Jun 2016 12:29:14 -0400 Received: from smtprelay0224.hostedemail.com ([216.40.44.224]:36051 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750996AbcFDQ3M (ORCPT ); Sat, 4 Jun 2016 12:29:12 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:967:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2525:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3865:3866:3867:3868:3870:3871:3872:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:5007:7974:9025:10004:10400:10848:11026:11232:11473:11658:11783:11914:12043:12050:12517:12519:12740:13069:13161:13229:13311:13357:13439:13845:13894:14181:14659:14721:21080:21324:30012:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: boy41_6d11041d0990d X-Filterd-Recvd-Size: 1809 Message-ID: <1465057748.11800.53.camel@perches.com> Subject: Re: [PATCH v2 2/2] lib/uuid.c: eliminate uuid_[bl]e_index arrays From: Joe Perches To: George Spelvin , andriy.shevchenko@linux.intel.com Cc: bjorn@mork.no, linux-kernel@vger.kernel.org, matt@codeblueprint.co.uk, rv@rasmusvillemoes.dk, Robert Moore , Lv Zheng , "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org, devel@acpica.org Date: Sat, 04 Jun 2016 09:29:08 -0700 In-Reply-To: <20160604051453.3758.qmail@ns.sciencehorizons.net> References: <20160604051453.3758.qmail@ns.sciencehorizons.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (adding acpi folks) On Sat, 2016-06-04 at 01:14 -0400, George Spelvin wrote: > Both input and output code is simplified if we use a mapping from binary > UUID index to ASCII UUID position.  This lets us combine hyphen-skipping > and endian-swapping into one table. > > This significantly simplifies __uuid_to_bin(), which was using *two* > lookup tables. Seems sensible, thanks. Trivially, acpi defines this but doesn't seem to use it. include/acpi/acconfig.h:#define UUID_STRING_LENGTH          36  /* Total length of a UUID string */ And Ingo commented last month: https://lkml.org/lkml/2016/4/29/69 Maybe this __uuid_to_bin function should be made public and the acpi version in drivers/acpi/acpica/utuuid.c should be removed.