From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751852AbcFDRdo (ORCPT <rfc822;w@1wt.eu>);
	Sat, 4 Jun 2016 13:33:44 -0400
Received: from mail1.bemta8.messagelabs.com ([216.82.243.195]:29518 "EHLO
	mail1.bemta8.messagelabs.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751243AbcFDR2A (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 4 Jun 2016 13:28:00 -0400
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJIsWRWlGSWpSXmKPExsVywNY2Q3cef3C
  4watgi4VtS1gsLu+aw+bA5PF5k1wAYxRrZl5SfkUCa8bVP51sBXPVKp5/MWtgPKzYxcjFISSw
  i1Hi78W9zF2MnEDOfkaJE8frIRKXGCUurfrEBOGsZZS4++k/I4SzhVFi2+/JTCAtbAIGEjPv3
  GUHsUUEzrNIPL2VC2ILC6RKHFq5FGwsi4CKxMaVH1i7GDk4eAW8JG5tEAEJSwjISZw8NpkVxO
  YECl95sJQJ4gpPiT37e6AuUpM4fPYRG0R9sMSORT/AVvEKCEqcnPmEBcRmFpCQOPjiBfMERsF
  ZSFKzkKQWMDKtYlQvTi0qSy3SNdNLKspMzyjJTczM0TU0sNDLTS0uTkxPzUlMKtZLzs/dxAgM
  UgYg2MH4qd/5EKMkB5OSKO/U+UHhQnxJ+SmVGYnFGfFFpTmpxYcYZTg4lCR4P/AFhwsJFqWmp
  1akZeYA4wUmLcHBoyTCqwiMGSHe4oLE3OLMdIjUKUZFKXHedyB9AiCJjNI8uDZYjF5ilJUS5m
  UEOkSIpyC1KDezBFX+FaM4B6OSMO9HkCk8mXklcNNfAS1mAlpc8MgfZHFJIkJKqoGRwdujzee
  X4lyt6Dd9XvyPzNfam5Xf5XJJsFQ2lrnaEasVJ/LcUTHpar9ygJOWv3fOF+PZhnkNHxeUXmAO
  Mmy2FmGqupk2W7b6QI8uk33jzO7rR9I2CGzf1HrpR7TENfmOxEOsNyW+2aebXFVb+mHNbQlRi
  09/mL7+ZzSVXZkZc2ip/O66C0osxRmJhlrMRcWJALVMSE/MAgAA
X-Env-Sender: David.Kershner@unisys.com
X-Msg-Ref: server-14.tower-46.messagelabs.com!1465061277!28555086!2
X-Originating-IP: [192.61.61.104]
X-StarScan-Received: 
X-StarScan-Version: 8.34; banners=-,-,-
X-VirusChecked: Checked
From: David Kershner <david.kershner@unisys.com>
To: <corbet@lwn.net>, <tglx@linutronix.de>, <mingo@redhat.com>,
        <hpa@zytor.com>, <david.kershner@unisys.com>,
        <gregkh@linuxfoundation.org>, <erik.arfvidson@unisys.com>,
        <timothy.sell@unisys.com>, <hofrat@osadl.org>, <dzickus@redhat.com>,
        <jes.sorensen@redhat.com>, <alexander.curtin@unisys.com>,
        <janani.rvchndrn@gmail.com>, <sudipm.mukherjee@gmail.com>,
        <prarit@redhat.com>, <david.binder@unisys.com>, <nhorman@redhat.com>,
        <dan.j.williams@intel.com>, <linux-kernel@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <driverdev-devel@linuxdriverproject.org>,
        <sparmaintainer@unisys.com>
Subject: [PATCH v3 22/30] staging: unisys: visorbus: Move visorbus-unique functions to private header
Date: Sat, 4 Jun 2016 13:27:22 -0400
Message-ID: <1465061250-18551-23-git-send-email-david.kershner@unisys.com>
X-Mailer: git-send-email 1.9.1
In-Reply-To: <1465061250-18551-1-git-send-email-david.kershner@unisys.com>
References: <1465061250-18551-1-git-send-email-david.kershner@unisys.com>
X-OriginalArrivalTime: 04 Jun 2016 17:27:37.0889 (UTC) FILETIME=[63C03110:01D1BE86]
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: David Binder <david.binder@unisys.com>

Moves function prototypes that are unique to visorbus from
include/visorbus.h to visorbus/visorbus_private.h.

Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
---
 drivers/staging/unisys/include/visorbus.h          | 25 --------------------
 drivers/staging/unisys/visorbus/visorbus_private.h | 27 ++++++++++++++++++++++
 drivers/staging/unisys/visorbus/visorchannel.c     |  1 +
 3 files changed, 28 insertions(+), 25 deletions(-)

diff --git a/drivers/staging/unisys/include/visorbus.h b/drivers/staging/unisys/include/visorbus.h
index fb53a65..666a04e 100644
--- a/drivers/staging/unisys/include/visorbus.h
+++ b/drivers/staging/unisys/include/visorbus.h
@@ -187,37 +187,12 @@ int visorbus_write_channel(struct visor_device *dev,
 void visorbus_enable_channel_interrupts(struct visor_device *dev);
 void visorbus_disable_channel_interrupts(struct visor_device *dev);
 
-/* Note that for visorchannel_create()
- * <channel_bytes> and <guid> arguments may be 0 if we are a channel CLIENT.
- * In this case, the values can simply be read from the channel header.
- */
-struct visorchannel *visorchannel_create(u64 physaddr,
-					 unsigned long channel_bytes,
-					 gfp_t gfp, uuid_le guid);
-struct visorchannel *visorchannel_create_with_lock(u64 physaddr,
-						   unsigned long channel_bytes,
-						   gfp_t gfp, uuid_le guid);
-void visorchannel_destroy(struct visorchannel *channel);
-int visorchannel_read(struct visorchannel *channel, ulong offset,
-		      void *local, ulong nbytes);
-int visorchannel_write(struct visorchannel *channel, ulong offset,
-		       void *local, ulong nbytes);
 bool visorchannel_signalremove(struct visorchannel *channel, u32 queue,
 			       void *msg);
 bool visorchannel_signalinsert(struct visorchannel *channel, u32 queue,
 			       void *msg);
 bool visorchannel_signalempty(struct visorchannel *channel, u32 queue);
-
-u64 visorchannel_get_physaddr(struct visorchannel *channel);
-ulong visorchannel_get_nbytes(struct visorchannel *channel);
-char *visorchannel_id(struct visorchannel *channel, char *s);
-char *visorchannel_zoneid(struct visorchannel *channel, char *s);
-u64 visorchannel_get_clientpartition(struct visorchannel *channel);
-int visorchannel_set_clientpartition(struct visorchannel *channel,
-				     u64 partition_handle);
 uuid_le visorchannel_get_uuid(struct visorchannel *channel);
-char *visorchannel_uuid_id(uuid_le *guid, char *s);
-void __iomem *visorchannel_get_header(struct visorchannel *channel);
 
 #define BUS_ROOT_DEVICE		UINT_MAX
 struct visor_device *visorbus_get_device_by_id(u32 bus_no, u32 dev_no,
diff --git a/drivers/staging/unisys/visorbus/visorbus_private.h b/drivers/staging/unisys/visorbus/visorbus_private.h
index 39edd20..31b5ca9 100644
--- a/drivers/staging/unisys/visorbus/visorbus_private.h
+++ b/drivers/staging/unisys/visorbus/visorbus_private.h
@@ -65,4 +65,31 @@ visorchipset_register_busdev(
 /* visorbus init and exit functions */
 int visorbus_init(void);
 void visorbus_exit(void);
+
+/* Visorchannel access functions */
+
+/* Note that for visorchannel_create()
+ * <channel_bytes> and <guid> arguments may be 0 if we are a channel CLIENT.
+ * In this case, the values can simply be read from the channel header.
+ */
+struct visorchannel *visorchannel_create(u64 physaddr,
+					 unsigned long channel_bytes,
+					 gfp_t gfp, uuid_le guid);
+struct visorchannel *visorchannel_create_with_lock(u64 physaddr,
+						   unsigned long channel_bytes,
+						   gfp_t gfp, uuid_le guid);
+void visorchannel_destroy(struct visorchannel *channel);
+int visorchannel_read(struct visorchannel *channel, ulong offset,
+		      void *local, ulong nbytes);
+int visorchannel_write(struct visorchannel *channel, ulong offset,
+		       void *local, ulong nbytes);
+u64 visorchannel_get_physaddr(struct visorchannel *channel);
+ulong visorchannel_get_nbytes(struct visorchannel *channel);
+char *visorchannel_id(struct visorchannel *channel, char *s);
+char *visorchannel_zoneid(struct visorchannel *channel, char *s);
+u64 visorchannel_get_clientpartition(struct visorchannel *channel);
+int visorchannel_set_clientpartition(struct visorchannel *channel,
+				     u64 partition_handle);
+char *visorchannel_uuid_id(uuid_le *guid, char *s);
+void __iomem *visorchannel_get_header(struct visorchannel *channel);
 #endif
diff --git a/drivers/staging/unisys/visorbus/visorchannel.c b/drivers/staging/unisys/visorbus/visorchannel.c
index 0ddfe05..fbae66e 100644
--- a/drivers/staging/unisys/visorbus/visorchannel.c
+++ b/drivers/staging/unisys/visorbus/visorchannel.c
@@ -25,6 +25,7 @@
 #include "version.h"
 #include "visorbus.h"
 #include "controlvmchannel.h"
+#include "visorbus_private.h"
 
 #define MYDRVNAME "visorchannel"
 
-- 
1.9.1