linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/7] dts: sunxi: Add sunxi NAND Flash Controller support
@ 2016-06-06 10:24 Aleksei Mamlin
  2016-06-06 10:24 ` [PATCH 1/7] ARM: dts: sun4i: Add A10 NAND controller pin definitions Aleksei Mamlin
                   ` (7 more replies)
  0 siblings, 8 replies; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-06 10:24 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Boris Brezillon, Richard Weinberger,
	David Woodhouse, Brian Norris
  Cc: linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi, Aleksei Mamlin

Hello,

This series adds the sunxi NAND Flash Controller nodes to dts.

The first 4 patches is Boris Brezillon's patches with dtsi changes.
The second 1 patch adds Hynix H27UBG8T2BTR-BC NAND chip definition.
The last 2 patches enables NAND on Marsboard A10 board and Wexler TAB7200
tablet.

Aleksei Mamlin (3):
  mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
  ARM: dts: sun4i: Enable NAND on Marsboard A10
  ARM: dts: sun7i: Enable NAND on Wexler TAB7200

Boris Brezillon (4):
  ARM: dts: sun4i: Add A10 NAND controller pin definitions
  ARM: dts: sun4i: Add NFC node to Allwinner A10 SoC
  ARM: dts: sun7i: Add A20 NAND controller pin definitions
  ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC

 arch/arm/boot/dts/sun4i-a10-marsboard.dts      | 41 ++++++++++++
 arch/arm/boot/dts/sun4i-a10.dtsi               | 91 ++++++++++++++++++++++++++
 arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 41 ++++++++++++
 arch/arm/boot/dts/sun7i-a20.dtsi               | 91 ++++++++++++++++++++++++++
 drivers/mtd/nand/nand_ids.c                    |  4 ++
 5 files changed, 268 insertions(+)

-- 
2.7.3

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [PATCH 1/7] ARM: dts: sun4i: Add A10 NAND controller pin definitions
  2016-06-06 10:24 [PATCH 0/7] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
@ 2016-06-06 10:24 ` Aleksei Mamlin
  2016-06-08 22:04   ` Maxime Ripard
  2016-06-06 10:24 ` [PATCH 2/7] ARM: dts: sun4i: Add NFC node to Allwinner A10 SoC Aleksei Mamlin
                   ` (6 subsequent siblings)
  7 siblings, 1 reply; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-06 10:24 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Boris Brezillon, Richard Weinberger,
	David Woodhouse, Brian Norris
  Cc: linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi, Aleksei Mamlin

From: Boris Brezillon <boris.brezillon@free-electrons.com>

Define the NAND controller pin configs.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
 arch/arm/boot/dts/sun4i-a10.dtsi | 80 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 80 insertions(+)

diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
index a9c3190..146a08db 100644
--- a/arch/arm/boot/dts/sun4i-a10.dtsi
+++ b/arch/arm/boot/dts/sun4i-a10.dtsi
@@ -1144,6 +1144,86 @@
 				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
 				allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
 			};
+
+			nand_pins_a: nand_base0@0 {
+				allwinner,pins = "PC0", "PC1", "PC2",
+						"PC5", "PC8", "PC9", "PC10",
+						"PC11", "PC12", "PC13", "PC14",
+						"PC15", "PC16";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs0_pins_a: nand_cs@0 {
+				allwinner,pins = "PC4";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs1_pins_a: nand_cs@1 {
+				allwinner,pins = "PC3";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs2_pins_a: nand_cs@2 {
+				allwinner,pins = "PC17";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs3_pins_a: nand_cs@3 {
+				allwinner,pins = "PC18";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs4_pins_a: nand_cs@4 {
+				allwinner,pins = "PC19";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs5_pins_a: nand_cs@5 {
+				allwinner,pins = "PC20";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs6_pins_a: nand_cs@6 {
+				allwinner,pins = "PC21";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs7_pins_a: nand_cs@7 {
+				allwinner,pins = "PC22";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_rb0_pins_a: nand_rb@0 {
+				allwinner,pins = "PC6";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_rb1_pins_a: nand_rb@1 {
+				allwinner,pins = "PC7";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
 		};
 
 		timer@01c20c00 {
-- 
2.7.3

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [PATCH 2/7] ARM: dts: sun4i: Add NFC node to Allwinner A10 SoC
  2016-06-06 10:24 [PATCH 0/7] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
  2016-06-06 10:24 ` [PATCH 1/7] ARM: dts: sun4i: Add A10 NAND controller pin definitions Aleksei Mamlin
@ 2016-06-06 10:24 ` Aleksei Mamlin
  2016-06-06 10:24 ` [PATCH 3/7] ARM: dts: sun7i: Add A20 NAND controller pin definitions Aleksei Mamlin
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-06 10:24 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Boris Brezillon, Richard Weinberger,
	David Woodhouse, Brian Norris
  Cc: linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi, Aleksei Mamlin

From: Boris Brezillon <boris.brezillon@free-electrons.com>

Add NAND Flash controller node definition to the A10 SoC.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
 arch/arm/boot/dts/sun4i-a10.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
index 146a08db..22950d8 100644
--- a/arch/arm/boot/dts/sun4i-a10.dtsi
+++ b/arch/arm/boot/dts/sun4i-a10.dtsi
@@ -747,6 +747,17 @@
 			#size-cells = <0>;
 		};
 
+		nfc: nand@01c03000 {
+			compatible = "allwinner,sun4i-a10-nand";
+			reg = <0x01c03000 0x1000>;
+			interrupts = <37>;
+			clocks = <&ahb_gates 13>, <&nand_clk>;
+			clock-names = "ahb", "mod";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
 		emac: ethernet@01c0b000 {
 			compatible = "allwinner,sun4i-a10-emac";
 			reg = <0x01c0b000 0x1000>;
-- 
2.7.3

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [PATCH 3/7] ARM: dts: sun7i: Add A20 NAND controller pin definitions
  2016-06-06 10:24 [PATCH 0/7] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
  2016-06-06 10:24 ` [PATCH 1/7] ARM: dts: sun4i: Add A10 NAND controller pin definitions Aleksei Mamlin
  2016-06-06 10:24 ` [PATCH 2/7] ARM: dts: sun4i: Add NFC node to Allwinner A10 SoC Aleksei Mamlin
@ 2016-06-06 10:24 ` Aleksei Mamlin
  2016-06-06 10:24 ` [PATCH 4/7] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC Aleksei Mamlin
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-06 10:24 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Boris Brezillon, Richard Weinberger,
	David Woodhouse, Brian Norris
  Cc: linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi, Aleksei Mamlin

From: Boris Brezillon <boris.brezillon@free-electrons.com>

Define the NAND controller pin configs.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
 arch/arm/boot/dts/sun7i-a20.dtsi | 80 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 80 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 82e28c3..915979f 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -1328,6 +1328,86 @@
 				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
 				allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
 			};
+
+			nand_pins_a: nand_base0@0 {
+				allwinner,pins = "PC0", "PC1", "PC2",
+						"PC5", "PC8", "PC9", "PC10",
+						"PC11", "PC12", "PC13", "PC14",
+						"PC15", "PC16";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs0_pins_a: nand_cs@0 {
+				allwinner,pins = "PC4";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs1_pins_a: nand_cs@1 {
+				allwinner,pins = "PC3";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs2_pins_a: nand_cs@2 {
+				allwinner,pins = "PC17";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs3_pins_a: nand_cs@3 {
+				allwinner,pins = "PC18";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs4_pins_a: nand_cs@4 {
+				allwinner,pins = "PC19";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs5_pins_a: nand_cs@5 {
+				allwinner,pins = "PC20";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs6_pins_a: nand_cs@6 {
+				allwinner,pins = "PC21";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs7_pins_a: nand_cs@7 {
+				allwinner,pins = "PC22";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_rb0_pins_a: nand_rb@0 {
+				allwinner,pins = "PC6";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_rb1_pins_a: nand_rb@1 {
+				allwinner,pins = "PC7";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
 		};
 
 		timer@01c20c00 {
-- 
2.7.3

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [PATCH 4/7] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC
  2016-06-06 10:24 [PATCH 0/7] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
                   ` (2 preceding siblings ...)
  2016-06-06 10:24 ` [PATCH 3/7] ARM: dts: sun7i: Add A20 NAND controller pin definitions Aleksei Mamlin
@ 2016-06-06 10:24 ` Aleksei Mamlin
  2016-06-07 17:21   ` Aleksei Mamlin
  2016-06-06 10:24 ` [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table Aleksei Mamlin
                   ` (3 subsequent siblings)
  7 siblings, 1 reply; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-06 10:24 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Boris Brezillon, Richard Weinberger,
	David Woodhouse, Brian Norris
  Cc: linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi, Aleksei Mamlin

From: Boris Brezillon <boris.brezillon@free-electrons.com>

Add NAND Flash controller node definition to the A20 SoC.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
 arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 915979f..e473570 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -826,6 +826,17 @@
 			#size-cells = <0>;
 		};
 
+		nfc: nand@01c03000 {
+			compatible = "allwinner,sun4i-a10-nand";
+			reg = <0x01c03000 0x1000>;
+			interrupts = <37>;
+			clocks = <&ahb_gates 13>, <&nand_clk>;
+			clock-names = "ahb", "mod";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
 		emac: ethernet@01c0b000 {
 			compatible = "allwinner,sun4i-a10-emac";
 			reg = <0x01c0b000 0x1000>;
-- 
2.7.3

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
  2016-06-06 10:24 [PATCH 0/7] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
                   ` (3 preceding siblings ...)
  2016-06-06 10:24 ` [PATCH 4/7] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC Aleksei Mamlin
@ 2016-06-06 10:24 ` Aleksei Mamlin
  2016-06-06 18:55   ` Boris Brezillon
  2016-06-06 10:24 ` [PATCH 6/7] ARM: dts: sun4i: Enable NAND on Marsboard A10 Aleksei Mamlin
                   ` (2 subsequent siblings)
  7 siblings, 1 reply; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-06 10:24 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Boris Brezillon, Richard Weinberger,
	David Woodhouse, Brian Norris
  Cc: linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi, Aleksei Mamlin

Add the full description of the Hynix H27UBG8T2BTR-BC NAND chip in the
nand_ids table so that we can later use the NAND ECC infos and ONFI timings
mode in controller drivers.

Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
 drivers/mtd/nand/nand_ids.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c
index ccc05f5..ccdc773 100644
--- a/drivers/mtd/nand/nand_ids.c
+++ b/drivers/mtd/nand/nand_ids.c
@@ -52,6 +52,10 @@ struct nand_flash_dev nand_flash_ids[] = {
 		{ .id = {0xad, 0xde, 0x94, 0xda, 0x74, 0xc4} },
 		  SZ_8K, SZ_8K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
 		  NAND_ECC_INFO(40, SZ_1K), 4 },
+	{"H27UBG8T2BTR-BC 32G 3.3V 8-bit",
+		{ .id = {0xad, 0xd7, 0x94, 0xda, 0x74, 0xc3} },
+		  SZ_8K, SZ_4K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
+		  NAND_ECC_INFO(40, SZ_1K), 0 },
 
 	LEGACY_ID_NAND("NAND 4MiB 5V 8-bit",   0x6B, 4, SZ_8K, SP_OPTIONS),
 	LEGACY_ID_NAND("NAND 4MiB 3,3V 8-bit", 0xE3, 4, SZ_8K, SP_OPTIONS),
-- 
2.7.3

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [PATCH 6/7] ARM: dts: sun4i: Enable NAND on Marsboard A10
  2016-06-06 10:24 [PATCH 0/7] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
                   ` (4 preceding siblings ...)
  2016-06-06 10:24 ` [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table Aleksei Mamlin
@ 2016-06-06 10:24 ` Aleksei Mamlin
  2016-06-06 18:50   ` Boris Brezillon
  2016-06-06 10:24 ` [PATCH 7/7] ARM: dts: sun7i: Enable NAND on Wexler TAB7200 Aleksei Mamlin
  2016-06-14 11:17 ` [PATCH v2 0/4] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
  7 siblings, 1 reply; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-06 10:24 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Boris Brezillon, Richard Weinberger,
	David Woodhouse, Brian Norris
  Cc: linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi, Aleksei Mamlin

Enable the NFC and describe the NAND flash connected to this controller.

Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
 arch/arm/boot/dts/sun4i-a10-marsboard.dts | 41 +++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/arch/arm/boot/dts/sun4i-a10-marsboard.dts b/arch/arm/boot/dts/sun4i-a10-marsboard.dts
index 8e50723..ea6e2d5 100644
--- a/arch/arm/boot/dts/sun4i-a10-marsboard.dts
+++ b/arch/arm/boot/dts/sun4i-a10-marsboard.dts
@@ -150,6 +150,47 @@
 	status = "okay";
 };
 
+&nfc {
+	pinctrl-names = "default";
+	pinctrl-0 = <&nand_pins_a>, <&nand_cs0_pins_a>, <&nand_rb0_pins_a>;
+	status = "okay";
+
+	nand@0 {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		reg = <0>;
+		allwinner,rb = <0>;
+
+		nand-ecc-mode = "hw";
+		nand-on-flash-bbt;
+
+		boot0@0 {
+			label = "boot0";
+			reg = /bits/ 64 <0x0 0x200000>;
+		};
+
+		boot0-rescue@200000 {
+			label = "boot0-rescue";
+			reg = /bits/ 64 <0x200000 0x200000>;
+		};
+
+		uboot@400000 {
+			label = "uboot";
+			reg = /bits/ 64 <0x400000 0x200000>;
+		};
+
+		uboot-rescue@600000 {
+			label = "uboot-rescue";
+			reg = /bits/ 64 <0x600000 0x200000>;
+		};
+
+		main@800000 {
+			label = "main";
+			reg = /bits/ 64 <0x800000 0xff800000>;
+		};
+	};
+};
+
 &ohci0 {
 	status = "okay";
 };
-- 
2.7.3

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [PATCH 7/7] ARM: dts: sun7i: Enable NAND on Wexler TAB7200
  2016-06-06 10:24 [PATCH 0/7] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
                   ` (5 preceding siblings ...)
  2016-06-06 10:24 ` [PATCH 6/7] ARM: dts: sun4i: Enable NAND on Marsboard A10 Aleksei Mamlin
@ 2016-06-06 10:24 ` Aleksei Mamlin
  2016-06-06 18:51   ` Boris Brezillon
  2016-06-08 22:03   ` Maxime Ripard
  2016-06-14 11:17 ` [PATCH v2 0/4] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
  7 siblings, 2 replies; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-06 10:24 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Boris Brezillon, Richard Weinberger,
	David Woodhouse, Brian Norris
  Cc: linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi, Aleksei Mamlin

Enable the NFC and describe the NAND flash connected to this controller.

Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
 arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 41 ++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
index 2f6b21a..42aff91 100644
--- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
+++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
@@ -159,6 +159,47 @@
 	status = "okay";
 };
 
+&nfc {
+	pinctrl-names = "default";
+	pinctrl-0 = <&nand_pins_a>, <&nand_cs0_pins_a>, <&nand_rb0_pins_a>;
+	status = "okay";
+
+	nand@0 {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		reg = <0>;
+		allwinner,rb = <0>;
+
+		nand-ecc-mode = "hw";
+		nand-on-flash-bbt;
+
+		boot0@0 {
+			label = "boot0";
+			reg = /bits/ 64 <0x0 0x200000>;
+		};
+
+		boot0-rescue@200000 {
+			label = "boot0-rescue";
+			reg = /bits/ 64 <0x200000 0x200000>;
+		};
+
+		uboot@400000 {
+			label = "uboot";
+			reg = /bits/ 64 <0x400000 0x200000>;
+		};
+
+		uboot-rescue@600000 {
+			label = "uboot-rescue";
+			reg = /bits/ 64 <0x600000 0x200000>;
+		};
+
+		main@800000 {
+			label = "main";
+			reg = /bits/ 64 <0x800000 0xff800000>;
+		};
+	};
+};
+
 &ohci0 {
 	status = "okay";
 };
-- 
2.7.3

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH 6/7] ARM: dts: sun4i: Enable NAND on Marsboard A10
  2016-06-06 10:24 ` [PATCH 6/7] ARM: dts: sun4i: Enable NAND on Marsboard A10 Aleksei Mamlin
@ 2016-06-06 18:50   ` Boris Brezillon
  0 siblings, 0 replies; 33+ messages in thread
From: Boris Brezillon @ 2016-06-06 18:50 UTC (permalink / raw)
  To: Aleksei Mamlin
  Cc: Maxime Ripard, Chen-Yu Tsai, Richard Weinberger, David Woodhouse,
	Brian Norris, linux-mtd, linux-kernel, linux-arm-kernel,
	devicetree, linux-sunxi

On Mon,  6 Jun 2016 13:24:23 +0300
Aleksei Mamlin <mamlinav@gmail.com> wrote:

> Enable the NFC and describe the NAND flash connected to this controller.
> 
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>

Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
>  arch/arm/boot/dts/sun4i-a10-marsboard.dts | 41 +++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun4i-a10-marsboard.dts b/arch/arm/boot/dts/sun4i-a10-marsboard.dts
> index 8e50723..ea6e2d5 100644
> --- a/arch/arm/boot/dts/sun4i-a10-marsboard.dts
> +++ b/arch/arm/boot/dts/sun4i-a10-marsboard.dts
> @@ -150,6 +150,47 @@
>  	status = "okay";
>  };
>  
> +&nfc {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&nand_pins_a>, <&nand_cs0_pins_a>, <&nand_rb0_pins_a>;
> +	status = "okay";
> +
> +	nand@0 {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		reg = <0>;
> +		allwinner,rb = <0>;
> +
> +		nand-ecc-mode = "hw";
> +		nand-on-flash-bbt;
> +
> +		boot0@0 {
> +			label = "boot0";
> +			reg = /bits/ 64 <0x0 0x200000>;
> +		};
> +
> +		boot0-rescue@200000 {
> +			label = "boot0-rescue";
> +			reg = /bits/ 64 <0x200000 0x200000>;
> +		};
> +
> +		uboot@400000 {
> +			label = "uboot";
> +			reg = /bits/ 64 <0x400000 0x200000>;
> +		};
> +
> +		uboot-rescue@600000 {
> +			label = "uboot-rescue";
> +			reg = /bits/ 64 <0x600000 0x200000>;
> +		};
> +
> +		main@800000 {
> +			label = "main";
> +			reg = /bits/ 64 <0x800000 0xff800000>;
> +		};
> +	};
> +};
> +
>  &ohci0 {
>  	status = "okay";
>  };



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH 7/7] ARM: dts: sun7i: Enable NAND on Wexler TAB7200
  2016-06-06 10:24 ` [PATCH 7/7] ARM: dts: sun7i: Enable NAND on Wexler TAB7200 Aleksei Mamlin
@ 2016-06-06 18:51   ` Boris Brezillon
  2016-06-08 22:03   ` Maxime Ripard
  1 sibling, 0 replies; 33+ messages in thread
From: Boris Brezillon @ 2016-06-06 18:51 UTC (permalink / raw)
  To: Aleksei Mamlin
  Cc: Maxime Ripard, Chen-Yu Tsai, Richard Weinberger, David Woodhouse,
	Brian Norris, linux-mtd, linux-kernel, linux-arm-kernel,
	devicetree, linux-sunxi

On Mon,  6 Jun 2016 13:24:24 +0300
Aleksei Mamlin <mamlinav@gmail.com> wrote:

> Enable the NFC and describe the NAND flash connected to this controller.
> 
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>

Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
>  arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 41 ++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> index 2f6b21a..42aff91 100644
> --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> @@ -159,6 +159,47 @@
>  	status = "okay";
>  };
>  
> +&nfc {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&nand_pins_a>, <&nand_cs0_pins_a>, <&nand_rb0_pins_a>;
> +	status = "okay";
> +
> +	nand@0 {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		reg = <0>;
> +		allwinner,rb = <0>;
> +
> +		nand-ecc-mode = "hw";
> +		nand-on-flash-bbt;
> +
> +		boot0@0 {
> +			label = "boot0";
> +			reg = /bits/ 64 <0x0 0x200000>;
> +		};
> +
> +		boot0-rescue@200000 {
> +			label = "boot0-rescue";
> +			reg = /bits/ 64 <0x200000 0x200000>;
> +		};
> +
> +		uboot@400000 {
> +			label = "uboot";
> +			reg = /bits/ 64 <0x400000 0x200000>;
> +		};
> +
> +		uboot-rescue@600000 {
> +			label = "uboot-rescue";
> +			reg = /bits/ 64 <0x600000 0x200000>;
> +		};
> +
> +		main@800000 {
> +			label = "main";
> +			reg = /bits/ 64 <0x800000 0xff800000>;
> +		};
> +	};
> +};
> +
>  &ohci0 {
>  	status = "okay";
>  };



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
  2016-06-06 10:24 ` [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table Aleksei Mamlin
@ 2016-06-06 18:55   ` Boris Brezillon
  2016-06-06 19:59     ` Aleksei Mamlin
  0 siblings, 1 reply; 33+ messages in thread
From: Boris Brezillon @ 2016-06-06 18:55 UTC (permalink / raw)
  To: Aleksei Mamlin
  Cc: Maxime Ripard, Chen-Yu Tsai, Richard Weinberger, David Woodhouse,
	Brian Norris, linux-mtd, linux-kernel, linux-arm-kernel,
	devicetree, linux-sunxi

On Mon,  6 Jun 2016 13:24:22 +0300
Aleksei Mamlin <mamlinav@gmail.com> wrote:

> Add the full description of the Hynix H27UBG8T2BTR-BC NAND chip in the
> nand_ids table so that we can later use the NAND ECC infos and ONFI timings
> mode in controller drivers.

Still hoping to get this series [1] merged in 4.8, but if that's
not the case, I'll apply your patch.

BTW, that would be great if you could test it on your platforms.

Regards,

Boris

[1]https://lkml.org/lkml/2016/5/27/264

> 
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
> ---
>  drivers/mtd/nand/nand_ids.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c
> index ccc05f5..ccdc773 100644
> --- a/drivers/mtd/nand/nand_ids.c
> +++ b/drivers/mtd/nand/nand_ids.c
> @@ -52,6 +52,10 @@ struct nand_flash_dev nand_flash_ids[] = {
>  		{ .id = {0xad, 0xde, 0x94, 0xda, 0x74, 0xc4} },
>  		  SZ_8K, SZ_8K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
>  		  NAND_ECC_INFO(40, SZ_1K), 4 },
> +	{"H27UBG8T2BTR-BC 32G 3.3V 8-bit",
> +		{ .id = {0xad, 0xd7, 0x94, 0xda, 0x74, 0xc3} },
> +		  SZ_8K, SZ_4K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
> +		  NAND_ECC_INFO(40, SZ_1K), 0 },
>  
>  	LEGACY_ID_NAND("NAND 4MiB 5V 8-bit",   0x6B, 4, SZ_8K, SP_OPTIONS),
>  	LEGACY_ID_NAND("NAND 4MiB 3,3V 8-bit", 0xE3, 4, SZ_8K, SP_OPTIONS),



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
  2016-06-06 18:55   ` Boris Brezillon
@ 2016-06-06 19:59     ` Aleksei Mamlin
  2016-06-06 20:31       ` Boris Brezillon
  0 siblings, 1 reply; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-06 19:59 UTC (permalink / raw)
  To: Boris Brezillon
  Cc: Maxime Ripard, Chen-Yu Tsai, Richard Weinberger, David Woodhouse,
	Brian Norris, linux-mtd, linux-kernel, linux-arm-kernel,
	devicetree, linux-sunxi

On Mon, 6 Jun 2016 20:55:49 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> On Mon,  6 Jun 2016 13:24:22 +0300
> Aleksei Mamlin <mamlinav@gmail.com> wrote:
> 
> > Add the full description of the Hynix H27UBG8T2BTR-BC NAND chip in the
> > nand_ids table so that we can later use the NAND ECC infos and ONFI timings
> > mode in controller drivers.
> 
> Still hoping to get this series [1] merged in 4.8, but if that's
> not the case, I'll apply your patch.
> 
> BTW, that would be great if you could test it on your platforms.
> 

It seems that Hynix-specific initialization code can't handle H27UBG8T2BTR-BC
chip:

[    0.886153] nand: Could not find valid ONFI parameter page; aborting
[    0.892665] nand: device found, Manufacturer ID: 0xad, Chip ID: 0xd7
[    0.899025] nand: Hynix 1c03000.nand
[    0.902596] nand: bus width 8 instead 16 bit
[    0.906858] nand: No NAND device found
[    0.910620] sunxi_nand 1c03000.nand: failed to init nand chips
[    0.916528] sunxi_nand: probe of 1c03000.nand failed with error -22

> 
> Regards,
> 
> Boris
> 
> [1]https://lkml.org/lkml/2016/5/27/264
> 
> > 
> > Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
> > ---
> >  drivers/mtd/nand/nand_ids.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c
> > index ccc05f5..ccdc773 100644
> > --- a/drivers/mtd/nand/nand_ids.c
> > +++ b/drivers/mtd/nand/nand_ids.c
> > @@ -52,6 +52,10 @@ struct nand_flash_dev nand_flash_ids[] = {
> >  		{ .id = {0xad, 0xde, 0x94, 0xda, 0x74, 0xc4} },
> >  		  SZ_8K, SZ_8K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
> >  		  NAND_ECC_INFO(40, SZ_1K), 4 },
> > +	{"H27UBG8T2BTR-BC 32G 3.3V 8-bit",
> > +		{ .id = {0xad, 0xd7, 0x94, 0xda, 0x74, 0xc3} },
> > +		  SZ_8K, SZ_4K, SZ_2M, NAND_NEED_SCRAMBLING, 6, 640,
> > +		  NAND_ECC_INFO(40, SZ_1K), 0 },
> >  
> >  	LEGACY_ID_NAND("NAND 4MiB 5V 8-bit",   0x6B, 4, SZ_8K, SP_OPTIONS),
> >  	LEGACY_ID_NAND("NAND 4MiB 3,3V 8-bit", 0xE3, 4, SZ_8K, SP_OPTIONS),
> 
> 
> 
> -- 
> Boris Brezillon, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com


-- 
Thanks and regards,
Aleksei Mamlin

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
  2016-06-06 19:59     ` Aleksei Mamlin
@ 2016-06-06 20:31       ` Boris Brezillon
  2016-06-06 21:06         ` Aleksei Mamlin
  2016-06-07  5:49         ` Boris Brezillon
  0 siblings, 2 replies; 33+ messages in thread
From: Boris Brezillon @ 2016-06-06 20:31 UTC (permalink / raw)
  To: Aleksei Mamlin
  Cc: Maxime Ripard, Chen-Yu Tsai, Richard Weinberger, David Woodhouse,
	Brian Norris, linux-mtd, linux-kernel, linux-arm-kernel,
	devicetree, linux-sunxi

On Mon, 6 Jun 2016 22:59:03 +0300
Aleksei Mamlin <mamlinav@gmail.com> wrote:

> On Mon, 6 Jun 2016 20:55:49 +0200
> Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> 
> > On Mon,  6 Jun 2016 13:24:22 +0300
> > Aleksei Mamlin <mamlinav@gmail.com> wrote:
> >   
> > > Add the full description of the Hynix H27UBG8T2BTR-BC NAND chip in the
> > > nand_ids table so that we can later use the NAND ECC infos and ONFI timings
> > > mode in controller drivers.  
> > 
> > Still hoping to get this series [1] merged in 4.8, but if that's
> > not the case, I'll apply your patch.
> > 
> > BTW, that would be great if you could test it on your platforms.
> >   
> 
> It seems that Hynix-specific initialization code can't handle H27UBG8T2BTR-BC
> chip:
> 
> [    0.886153] nand: Could not find valid ONFI parameter page; aborting
> [    0.892665] nand: device found, Manufacturer ID: 0xad, Chip ID: 0xd7
> [    0.899025] nand: Hynix 1c03000.nand
> [    0.902596] nand: bus width 8 instead 16 bit
> [    0.906858] nand: No NAND device found
> [    0.910620] sunxi_nand 1c03000.nand: failed to init nand chips
> [    0.916528] sunxi_nand: probe of 1c03000.nand failed with error -22

Can you try this patch? It should fix the problem [1].

[1]http://code.bulix.org/6hjww1-100494


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
  2016-06-06 20:31       ` Boris Brezillon
@ 2016-06-06 21:06         ` Aleksei Mamlin
  2016-06-07  5:48           ` Boris Brezillon
  2016-06-07  5:49         ` Boris Brezillon
  1 sibling, 1 reply; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-06 21:06 UTC (permalink / raw)
  To: Boris Brezillon
  Cc: Maxime Ripard, Chen-Yu Tsai, Richard Weinberger, David Woodhouse,
	Brian Norris, linux-mtd, linux-kernel, linux-arm-kernel,
	devicetree, linux-sunxi

On Mon, 6 Jun 2016 22:31:38 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> On Mon, 6 Jun 2016 22:59:03 +0300
> Aleksei Mamlin <mamlinav@gmail.com> wrote:
> 
> > On Mon, 6 Jun 2016 20:55:49 +0200
> > Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> > 
> > > On Mon,  6 Jun 2016 13:24:22 +0300
> > > Aleksei Mamlin <mamlinav@gmail.com> wrote:
> > >   
> > > > Add the full description of the Hynix H27UBG8T2BTR-BC NAND chip in the
> > > > nand_ids table so that we can later use the NAND ECC infos and ONFI timings
> > > > mode in controller drivers.  
> > > 
> > > Still hoping to get this series [1] merged in 4.8, but if that's
> > > not the case, I'll apply your patch.
> > > 
> > > BTW, that would be great if you could test it on your platforms.
> > >   
> > 
> > It seems that Hynix-specific initialization code can't handle H27UBG8T2BTR-BC
> > chip:
> > 
> > [    0.886153] nand: Could not find valid ONFI parameter page; aborting
> > [    0.892665] nand: device found, Manufacturer ID: 0xad, Chip ID: 0xd7
> > [    0.899025] nand: Hynix 1c03000.nand
> > [    0.902596] nand: bus width 8 instead 16 bit
> > [    0.906858] nand: No NAND device found
> > [    0.910620] sunxi_nand 1c03000.nand: failed to init nand chips
> > [    0.916528] sunxi_nand: probe of 1c03000.nand failed with error -22
> 
> Can you try this patch? It should fix the problem [1].
> 
> [1]http://code.bulix.org/6hjww1-100494
> 

Yes, it fixes problem. What about ONFI parameter page? Should it be ignored?
[    0.886068] nand: Could not find valid ONFI parameter page; aborting
[    0.892571] nand: device found, Manufacturer ID: 0xad, Chip ID: 0xd7
[    0.898917] nand: Hynix NAND 4GiB 3,3V 8-bit
[    0.903198] nand: 4096 MiB, MLC, erase size: 2048 KiB, page size: 8192, OOB size: 640
[    0.911908] Bad block table found at page 524032, version 0x01
[    0.918534] Bad block table found at page 523776, version 0x01
[    0.972112] 5 ofpart partitions found on MTD device 1c03000.nand
[    0.978116] Creating 5 MTD partitions on "1c03000.nand":
[    0.983477] 0x000000000000-0x000000200000 : "boot0"
[    0.988803] 0x000000200000-0x000000400000 : "boot0-rescue"
[    0.994692] 0x000000400000-0x000000600000 : "uboot"
[    0.999944] 0x000000600000-0x000000800000 : "uboot-rescue"
[    1.005763] 0x000000800000-0x000100000000 : "main"

> 
> -- 
> Boris Brezillon, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com


-- 
Thanks and regards,
Aleksei Mamlin

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
  2016-06-06 21:06         ` Aleksei Mamlin
@ 2016-06-07  5:48           ` Boris Brezillon
  0 siblings, 0 replies; 33+ messages in thread
From: Boris Brezillon @ 2016-06-07  5:48 UTC (permalink / raw)
  To: Aleksei Mamlin, Brian Norris
  Cc: Maxime Ripard, Chen-Yu Tsai, Richard Weinberger, David Woodhouse,
	linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi

On Tue, 7 Jun 2016 00:06:45 +0300
Aleksei Mamlin <mamlinav@gmail.com> wrote:

> On Mon, 6 Jun 2016 22:31:38 +0200
> Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> 
> > On Mon, 6 Jun 2016 22:59:03 +0300
> > Aleksei Mamlin <mamlinav@gmail.com> wrote:
> >   
> > > On Mon, 6 Jun 2016 20:55:49 +0200
> > > Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> > >   
> > > > On Mon,  6 Jun 2016 13:24:22 +0300
> > > > Aleksei Mamlin <mamlinav@gmail.com> wrote:
> > > >     
> > > > > Add the full description of the Hynix H27UBG8T2BTR-BC NAND chip in the
> > > > > nand_ids table so that we can later use the NAND ECC infos and ONFI timings
> > > > > mode in controller drivers.    
> > > > 
> > > > Still hoping to get this series [1] merged in 4.8, but if that's
> > > > not the case, I'll apply your patch.
> > > > 
> > > > BTW, that would be great if you could test it on your platforms.
> > > >     
> > > 
> > > It seems that Hynix-specific initialization code can't handle H27UBG8T2BTR-BC
> > > chip:
> > > 
> > > [    0.886153] nand: Could not find valid ONFI parameter page; aborting
> > > [    0.892665] nand: device found, Manufacturer ID: 0xad, Chip ID: 0xd7
> > > [    0.899025] nand: Hynix 1c03000.nand
> > > [    0.902596] nand: bus width 8 instead 16 bit
> > > [    0.906858] nand: No NAND device found
> > > [    0.910620] sunxi_nand 1c03000.nand: failed to init nand chips
> > > [    0.916528] sunxi_nand: probe of 1c03000.nand failed with error -22  
> > 
> > Can you try this patch? It should fix the problem [1].
> > 
> > [1]http://code.bulix.org/6hjww1-100494
> >   
> 
> Yes, it fixes problem. What about ONFI parameter page? Should it be ignored?

It should be ignored: your NAND is not 'ONFI compatible', the datasheet
just says that it supports the' ONFI command set', which is not the
same :).
The trace you're seeing here is just notifying that the core failed to
detect an ONFI NAND, which is expected in your case.

> [    0.886068] nand: Could not find valid ONFI parameter page; aborting
> [    0.892571] nand: device found, Manufacturer ID: 0xad, Chip ID: 0xd7
> [    0.898917] nand: Hynix NAND 4GiB 3,3V 8-bit
> [    0.903198] nand: 4096 MiB, MLC, erase size: 2048 KiB, page size: 8192, OOB size: 640
> [    0.911908] Bad block table found at page 524032, version 0x01
> [    0.918534] Bad block table found at page 523776, version 0x01
> [    0.972112] 5 ofpart partitions found on MTD device 1c03000.nand
> [    0.978116] Creating 5 MTD partitions on "1c03000.nand":
> [    0.983477] 0x000000000000-0x000000200000 : "boot0"
> [    0.988803] 0x000000200000-0x000000400000 : "boot0-rescue"
> [    0.994692] 0x000000400000-0x000000600000 : "uboot"
> [    0.999944] 0x000000600000-0x000000800000 : "uboot-rescue"
> [    1.005763] 0x000000800000-0x000100000000 : "main"
> 
> > 
> > -- 
> > Boris Brezillon, Free Electrons
> > Embedded Linux and Kernel engineering
> > http://free-electrons.com  
> 
> 



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table
  2016-06-06 20:31       ` Boris Brezillon
  2016-06-06 21:06         ` Aleksei Mamlin
@ 2016-06-07  5:49         ` Boris Brezillon
  1 sibling, 0 replies; 33+ messages in thread
From: Boris Brezillon @ 2016-06-07  5:49 UTC (permalink / raw)
  To: Aleksei Mamlin, Brian Norris
  Cc: Maxime Ripard, Chen-Yu Tsai, Richard Weinberger, David Woodhouse,
	linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi

On Mon, 6 Jun 2016 22:31:38 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> On Mon, 6 Jun 2016 22:59:03 +0300
> Aleksei Mamlin <mamlinav@gmail.com> wrote:
> 
> > On Mon, 6 Jun 2016 20:55:49 +0200
> > Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> >   
> > > On Mon,  6 Jun 2016 13:24:22 +0300
> > > Aleksei Mamlin <mamlinav@gmail.com> wrote:
> > >     
> > > > Add the full description of the Hynix H27UBG8T2BTR-BC NAND chip in the
> > > > nand_ids table so that we can later use the NAND ECC infos and ONFI timings
> > > > mode in controller drivers.    
> > > 
> > > Still hoping to get this series [1] merged in 4.8, but if that's
> > > not the case, I'll apply your patch.
> > > 
> > > BTW, that would be great if you could test it on your platforms.
> > >     
> > 
> > It seems that Hynix-specific initialization code can't handle H27UBG8T2BTR-BC
> > chip:
> > 
> > [    0.886153] nand: Could not find valid ONFI parameter page; aborting
> > [    0.892665] nand: device found, Manufacturer ID: 0xad, Chip ID: 0xd7
> > [    0.899025] nand: Hynix 1c03000.nand
> > [    0.902596] nand: bus width 8 instead 16 bit
> > [    0.906858] nand: No NAND device found
> > [    0.910620] sunxi_nand 1c03000.nand: failed to init nand chips
> > [    0.916528] sunxi_nand: probe of 1c03000.nand failed with error -22  
> 
> Can you try this patch? It should fix the problem [1].

Brian, I have a question regarding the extended NAND ids (not full-ids)
defined in the nand_ids table. Are they really valid for all vendors?

If that's the case, why are we extracting the bus width from the id[3]
since we already have this information in the options field?

> 
> [1]http://code.bulix.org/6hjww1-100494
> 
> 



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH 4/7] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC
  2016-06-06 10:24 ` [PATCH 4/7] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC Aleksei Mamlin
@ 2016-06-07 17:21   ` Aleksei Mamlin
  0 siblings, 0 replies; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-07 17:21 UTC (permalink / raw)
  To: Aleksei Mamlin
  Cc: Maxime Ripard, Chen-Yu Tsai, Boris Brezillon, Richard Weinberger,
	David Woodhouse, Brian Norris, linux-mtd, linux-kernel,
	linux-arm-kernel, devicetree, linux-sunxi

On Mon,  6 Jun 2016 13:24:21 +0300
Aleksei Mamlin <mamlinav@gmail.com> wrote:

> From: Boris Brezillon <boris.brezillon@free-electrons.com>
> 
> Add NAND Flash controller node definition to the A20 SoC.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
> ---
>  arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 915979f..e473570 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -826,6 +826,17 @@
>  			#size-cells = <0>;
>  		};
>  
> +		nfc: nand@01c03000 {
> +			compatible = "allwinner,sun4i-a10-nand";
> +			reg = <0x01c03000 0x1000>;
> +			interrupts = <37>;

Should be
			interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;

> +			clocks = <&ahb_gates 13>, <&nand_clk>;
> +			clock-names = "ahb", "mod";
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			status = "disabled";
> +		};
> +
>  		emac: ethernet@01c0b000 {
>  			compatible = "allwinner,sun4i-a10-emac";
>  			reg = <0x01c0b000 0x1000>;
> -- 
> 2.7.3
> 


-- 
Thanks and regards,
Aleksei Mamlin

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH 7/7] ARM: dts: sun7i: Enable NAND on Wexler TAB7200
  2016-06-06 10:24 ` [PATCH 7/7] ARM: dts: sun7i: Enable NAND on Wexler TAB7200 Aleksei Mamlin
  2016-06-06 18:51   ` Boris Brezillon
@ 2016-06-08 22:03   ` Maxime Ripard
  2016-06-09  8:11     ` Aleksei Mamlin
  1 sibling, 1 reply; 33+ messages in thread
From: Maxime Ripard @ 2016-06-08 22:03 UTC (permalink / raw)
  To: Aleksei Mamlin
  Cc: Chen-Yu Tsai, Boris Brezillon, Richard Weinberger,
	David Woodhouse, Brian Norris, linux-mtd, linux-kernel,
	linux-arm-kernel, devicetree, linux-sunxi

[-- Attachment #1: Type: text/plain, Size: 2261 bytes --]

Hi,

On Mon, Jun 06, 2016 at 01:24:24PM +0300, Aleksei Mamlin wrote:
> Enable the NFC and describe the NAND flash connected to this controller.
> 
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
> ---
>  arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 41 ++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> index 2f6b21a..42aff91 100644
> --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> @@ -159,6 +159,47 @@
>  	status = "okay";
>  };
>  
> +&nfc {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&nand_pins_a>, <&nand_cs0_pins_a>, <&nand_rb0_pins_a>;
> +	status = "okay";
> +
> +	nand@0 {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		reg = <0>;
> +		allwinner,rb = <0>;
> +
> +		nand-ecc-mode = "hw";
> +		nand-on-flash-bbt;
> +
> +		boot0@0 {
> +			label = "boot0";
> +			reg = /bits/ 64 <0x0 0x200000>;
> +		};
> +
> +		boot0-rescue@200000 {
> +			label = "boot0-rescue";
> +			reg = /bits/ 64 <0x200000 0x200000>;
> +		};
> +
> +		uboot@400000 {
> +			label = "uboot";
> +			reg = /bits/ 64 <0x400000 0x200000>;
> +		};
> +
> +		uboot-rescue@600000 {
> +			label = "uboot-rescue";
> +			reg = /bits/ 64 <0x600000 0x200000>;
> +		};
> +
> +		main@800000 {
> +			label = "main";
> +			reg = /bits/ 64 <0x800000 0xff800000>;
> +		};
> +	};
> +};

This feels a bit premature. The two boards you're using have an MLC
NAND which is not supported yet. Until there's proper MLC support in
the kernel, I'm not sure we want to enable that for end-users when we
know that things will get wrong.

However, after discussing this with Boris, I appreciate that we don't
have any example available because of this policy for people that want
to opt-in anyway.

What we could do is to still mark the status as disabled in the DTS,
with a big fat warning as comment just before, so that it requires
user action, and that user will have been warned.

Would that work for you?
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH 1/7] ARM: dts: sun4i: Add A10 NAND controller pin definitions
  2016-06-06 10:24 ` [PATCH 1/7] ARM: dts: sun4i: Add A10 NAND controller pin definitions Aleksei Mamlin
@ 2016-06-08 22:04   ` Maxime Ripard
  0 siblings, 0 replies; 33+ messages in thread
From: Maxime Ripard @ 2016-06-08 22:04 UTC (permalink / raw)
  To: Aleksei Mamlin
  Cc: Chen-Yu Tsai, Boris Brezillon, Richard Weinberger,
	David Woodhouse, Brian Norris, linux-mtd, linux-kernel,
	linux-arm-kernel, devicetree, linux-sunxi

[-- Attachment #1: Type: text/plain, Size: 3620 bytes --]

Hi,

On Mon, Jun 06, 2016 at 01:24:18PM +0300, Aleksei Mamlin wrote:
> From: Boris Brezillon <boris.brezillon@free-electrons.com>
> 
> Define the NAND controller pin configs.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
> ---
>  arch/arm/boot/dts/sun4i-a10.dtsi | 80 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 80 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> index a9c3190..146a08db 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -1144,6 +1144,86 @@
>  				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>  				allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
>  			};
> +
> +			nand_pins_a: nand_base0@0 {
> +				allwinner,pins = "PC0", "PC1", "PC2",
> +						"PC5", "PC8", "PC9", "PC10",
> +						"PC11", "PC12", "PC13", "PC14",
> +						"PC15", "PC16";
> +				allwinner,function = "nand0";
> +				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> +				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> +			};
> +
> +			nand_cs0_pins_a: nand_cs@0 {
> +				allwinner,pins = "PC4";
> +				allwinner,function = "nand0";
> +				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> +				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> +			};
> +
> +			nand_cs1_pins_a: nand_cs@1 {
> +				allwinner,pins = "PC3";
> +				allwinner,function = "nand0";
> +				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> +				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> +			};
> +
> +			nand_cs2_pins_a: nand_cs@2 {
> +				allwinner,pins = "PC17";
> +				allwinner,function = "nand0";
> +				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> +				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> +			};
> +
> +			nand_cs3_pins_a: nand_cs@3 {
> +				allwinner,pins = "PC18";
> +				allwinner,function = "nand0";
> +				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> +				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> +			};
> +
> +			nand_cs4_pins_a: nand_cs@4 {
> +				allwinner,pins = "PC19";
> +				allwinner,function = "nand0";
> +				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> +				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> +			};
> +
> +			nand_cs5_pins_a: nand_cs@5 {
> +				allwinner,pins = "PC20";
> +				allwinner,function = "nand0";
> +				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> +				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> +			};
> +
> +			nand_cs6_pins_a: nand_cs@6 {
> +				allwinner,pins = "PC21";
> +				allwinner,function = "nand0";
> +				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> +				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> +			};
> +
> +			nand_cs7_pins_a: nand_cs@7 {
> +				allwinner,pins = "PC22";
> +				allwinner,function = "nand0";
> +				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> +				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> +			};
> +
> +			nand_rb0_pins_a: nand_rb@0 {
> +				allwinner,pins = "PC6";
> +				allwinner,function = "nand0";
> +				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> +				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> +			};
> +
> +			nand_rb1_pins_a: nand_rb@1 {
> +				allwinner,pins = "PC7";
> +				allwinner,function = "nand0";
> +				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> +				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> +			};

We usually enable only the pin groups that are actually used by some
board to avoid bloating the DT too much.

And the nodes should be sorted alphabetically.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH 7/7] ARM: dts: sun7i: Enable NAND on Wexler TAB7200
  2016-06-08 22:03   ` Maxime Ripard
@ 2016-06-09  8:11     ` Aleksei Mamlin
  2016-06-10  8:56       ` Maxime Ripard
  0 siblings, 1 reply; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-09  8:11 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Chen-Yu Tsai, Boris Brezillon, Richard Weinberger,
	David Woodhouse, Brian Norris, linux-mtd, linux-kernel,
	linux-arm-kernel, devicetree, linux-sunxi

On Thu, 9 Jun 2016 00:03:14 +0200
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:

> Hi,
> 
> On Mon, Jun 06, 2016 at 01:24:24PM +0300, Aleksei Mamlin wrote:
> > Enable the NFC and describe the NAND flash connected to this controller.
> > 
> > Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
> > ---
> >  arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 41 ++++++++++++++++++++++++++
> >  1 file changed, 41 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > index 2f6b21a..42aff91 100644
> > --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > @@ -159,6 +159,47 @@
> >  	status = "okay";
> >  };
> >  
> > +&nfc {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&nand_pins_a>, <&nand_cs0_pins_a>, <&nand_rb0_pins_a>;
> > +	status = "okay";
> > +
> > +	nand@0 {
> > +		#address-cells = <2>;
> > +		#size-cells = <2>;
> > +		reg = <0>;
> > +		allwinner,rb = <0>;
> > +
> > +		nand-ecc-mode = "hw";
> > +		nand-on-flash-bbt;
> > +
> > +		boot0@0 {
> > +			label = "boot0";
> > +			reg = /bits/ 64 <0x0 0x200000>;
> > +		};
> > +
> > +		boot0-rescue@200000 {
> > +			label = "boot0-rescue";
> > +			reg = /bits/ 64 <0x200000 0x200000>;
> > +		};
> > +
> > +		uboot@400000 {
> > +			label = "uboot";
> > +			reg = /bits/ 64 <0x400000 0x200000>;
> > +		};
> > +
> > +		uboot-rescue@600000 {
> > +			label = "uboot-rescue";
> > +			reg = /bits/ 64 <0x600000 0x200000>;
> > +		};
> > +
> > +		main@800000 {
> > +			label = "main";
> > +			reg = /bits/ 64 <0x800000 0xff800000>;
> > +		};
> > +	};
> > +};
> 
> This feels a bit premature. The two boards you're using have an MLC
> NAND which is not supported yet. Until there's proper MLC support in
> the kernel, I'm not sure we want to enable that for end-users when we
> know that things will get wrong.
> 
> However, after discussing this with Boris, I appreciate that we don't
> have any example available because of this policy for people that want
> to opt-in anyway.
> 
> What we could do is to still mark the status as disabled in the DTS,
> with a big fat warning as comment just before, so that it requires
> user action, and that user will have been warned.
> 
> Would that work for you?
> Maxime
> 

Let's drop this two patches with boards dts changes until we get proper MLC
support in kernel.

As for examples - I'll update linux-sunxi wiki with how to enable NAND 
controller and describe NAND chips in DTS. People who want to add NAND support 
to their boards will be warned that it is risky for now.

>
> -- 
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com


-- 
Thanks and regards,
Aleksei Mamlin

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH 7/7] ARM: dts: sun7i: Enable NAND on Wexler TAB7200
  2016-06-09  8:11     ` Aleksei Mamlin
@ 2016-06-10  8:56       ` Maxime Ripard
  0 siblings, 0 replies; 33+ messages in thread
From: Maxime Ripard @ 2016-06-10  8:56 UTC (permalink / raw)
  To: Aleksei Mamlin
  Cc: Chen-Yu Tsai, Boris Brezillon, Richard Weinberger,
	David Woodhouse, Brian Norris, linux-mtd, linux-kernel,
	linux-arm-kernel, devicetree, linux-sunxi

[-- Attachment #1: Type: text/plain, Size: 3100 bytes --]

On Thu, Jun 09, 2016 at 11:11:00AM +0300, Aleksei Mamlin wrote:
> On Thu, 9 Jun 2016 00:03:14 +0200
> Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
> 
> > Hi,
> > 
> > On Mon, Jun 06, 2016 at 01:24:24PM +0300, Aleksei Mamlin wrote:
> > > Enable the NFC and describe the NAND flash connected to this controller.
> > > 
> > > Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
> > > ---
> > >  arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 41 ++++++++++++++++++++++++++
> > >  1 file changed, 41 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > > index 2f6b21a..42aff91 100644
> > > --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > > +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> > > @@ -159,6 +159,47 @@
> > >  	status = "okay";
> > >  };
> > >  
> > > +&nfc {
> > > +	pinctrl-names = "default";
> > > +	pinctrl-0 = <&nand_pins_a>, <&nand_cs0_pins_a>, <&nand_rb0_pins_a>;
> > > +	status = "okay";
> > > +
> > > +	nand@0 {
> > > +		#address-cells = <2>;
> > > +		#size-cells = <2>;
> > > +		reg = <0>;
> > > +		allwinner,rb = <0>;
> > > +
> > > +		nand-ecc-mode = "hw";
> > > +		nand-on-flash-bbt;
> > > +
> > > +		boot0@0 {
> > > +			label = "boot0";
> > > +			reg = /bits/ 64 <0x0 0x200000>;
> > > +		};
> > > +
> > > +		boot0-rescue@200000 {
> > > +			label = "boot0-rescue";
> > > +			reg = /bits/ 64 <0x200000 0x200000>;
> > > +		};
> > > +
> > > +		uboot@400000 {
> > > +			label = "uboot";
> > > +			reg = /bits/ 64 <0x400000 0x200000>;
> > > +		};
> > > +
> > > +		uboot-rescue@600000 {
> > > +			label = "uboot-rescue";
> > > +			reg = /bits/ 64 <0x600000 0x200000>;
> > > +		};
> > > +
> > > +		main@800000 {
> > > +			label = "main";
> > > +			reg = /bits/ 64 <0x800000 0xff800000>;
> > > +		};
> > > +	};
> > > +};
> > 
> > This feels a bit premature. The two boards you're using have an MLC
> > NAND which is not supported yet. Until there's proper MLC support in
> > the kernel, I'm not sure we want to enable that for end-users when we
> > know that things will get wrong.
> > 
> > However, after discussing this with Boris, I appreciate that we don't
> > have any example available because of this policy for people that want
> > to opt-in anyway.
> > 
> > What we could do is to still mark the status as disabled in the DTS,
> > with a big fat warning as comment just before, so that it requires
> > user action, and that user will have been warned.
> > 
> > Would that work for you?
> > Maxime
> > 
> 
> Let's drop this two patches with boards dts changes until we get proper MLC
> support in kernel.
> 
> As for examples - I'll update linux-sunxi wiki with how to enable NAND 
> controller and describe NAND chips in DTS. People who want to add NAND support 
> to their boards will be warned that it is risky for now.

That works for me too.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [PATCH v2 0/4] dts: sunxi: Add sunxi NAND Flash Controller support
  2016-06-06 10:24 [PATCH 0/7] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
                   ` (6 preceding siblings ...)
  2016-06-06 10:24 ` [PATCH 7/7] ARM: dts: sun7i: Enable NAND on Wexler TAB7200 Aleksei Mamlin
@ 2016-06-14 11:17 ` Aleksei Mamlin
  2016-06-14 11:17   ` [PATCH v2 1/4] ARM: dts: sun4i: Add A10 NAND controller pin definitions Aleksei Mamlin
                     ` (3 more replies)
  7 siblings, 4 replies; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-14 11:17 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Boris Brezillon
  Cc: linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi, Aleksei Mamlin

Hello,

This series adds the sunxi NAND Flash Controller pin definitions and nodes to
dts.

Changes since v1:
- Remove patch with Hynix H27UBG8T2BTR-BC MLC NAND chip definition.
- Remove patches with NAND support on Marsboard A10 board and Wexler TAB7200.
- Enable only the pin groups that are actually used by sunxi boards.
- Enable DMA support. Depends on sunxi NFC DMA support([1], [2]), merged into
  linux-nand.

[1] http://lists.infradead.org/pipermail/linux-mtd/2016-April/066899.html
[2] http://lists.infradead.org/pipermail/linux-mtd/2016-April/066898.html

Boris Brezillon (4):
  ARM: dts: sun4i: Add A10 NAND controller pin definitions
  ARM: dts: sun4i: Add NFC node to Allwinner A10 SoC
  ARM: dts: sun7i: Add A20 NAND controller pin definitions
  ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC

 arch/arm/boot/dts/sun4i-a10.dtsi | 65 ++++++++++++++++++++++++++++++++++++++++
 arch/arm/boot/dts/sun7i-a20.dtsi | 65 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 130 insertions(+)

-- 
2.7.3

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [PATCH v2 1/4] ARM: dts: sun4i: Add A10 NAND controller pin definitions
  2016-06-14 11:17 ` [PATCH v2 0/4] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
@ 2016-06-14 11:17   ` Aleksei Mamlin
  2016-06-14 12:37     ` Maxime Ripard
  2016-06-14 11:17   ` [PATCH v2 2/4] ARM: dts: sun4i: Add NFC node to Allwinner A10 SoC Aleksei Mamlin
                     ` (2 subsequent siblings)
  3 siblings, 1 reply; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-14 11:17 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Boris Brezillon
  Cc: linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi, Aleksei Mamlin

From: Boris Brezillon <boris.brezillon@free-electrons.com>

Define the NAND controller pin configs.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
 arch/arm/boot/dts/sun4i-a10.dtsi | 52 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
index 6d9c7c70..e579bdd 100644
--- a/arch/arm/boot/dts/sun4i-a10.dtsi
+++ b/arch/arm/boot/dts/sun4i-a10.dtsi
@@ -1033,6 +1033,58 @@
 				allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
 			};
 
+			nand_pins_a: nand_base0@0 {
+				allwinner,pins = "PC0", "PC1", "PC2",
+						"PC5", "PC8", "PC9", "PC10",
+						"PC11", "PC12", "PC13", "PC14",
+						"PC15", "PC16";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs0_pins_a: nand_cs@0 {
+				allwinner,pins = "PC4";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs1_pins_a: nand_cs@1 {
+				allwinner,pins = "PC3";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs2_pins_a: nand_cs@2 {
+				allwinner,pins = "PC17";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs3_pins_a: nand_cs@3 {
+				allwinner,pins = "PC18";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_rb0_pins_a: nand_rb@0 {
+				allwinner,pins = "PC6";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_rb1_pins_a: nand_rb@1 {
+				allwinner,pins = "PC7";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
 			ps20_pins_a: ps20@0 {
 				allwinner,pins = "PI20", "PI21";
 				allwinner,function = "ps2";
-- 
2.7.3

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [PATCH v2 2/4] ARM: dts: sun4i: Add NFC node to Allwinner A10 SoC
  2016-06-14 11:17 ` [PATCH v2 0/4] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
  2016-06-14 11:17   ` [PATCH v2 1/4] ARM: dts: sun4i: Add A10 NAND controller pin definitions Aleksei Mamlin
@ 2016-06-14 11:17   ` Aleksei Mamlin
  2016-06-14 12:33     ` Maxime Ripard
  2016-06-14 11:17   ` [PATCH v2 3/4] ARM: dts: sun7i: Add A20 NAND controller pin definitions Aleksei Mamlin
  2016-06-14 11:17   ` [PATCH v2 4/4] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC Aleksei Mamlin
  3 siblings, 1 reply; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-14 11:17 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Boris Brezillon
  Cc: linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi, Aleksei Mamlin

From: Boris Brezillon <boris.brezillon@free-electrons.com>

Add NAND Flash controller node definition to the A10 SoC.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
 arch/arm/boot/dts/sun4i-a10.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
index e579bdd..308ed5d 100644
--- a/arch/arm/boot/dts/sun4i-a10.dtsi
+++ b/arch/arm/boot/dts/sun4i-a10.dtsi
@@ -719,6 +719,19 @@
 			#dma-cells = <2>;
 		};
 
+		nfc: nand@01c03000 {
+			compatible = "allwinner,sun4i-a10-nand";
+			reg = <0x01c03000 0x1000>;
+			interrupts = <37>;
+			clocks = <&ahb_gates 13>, <&nand_clk>;
+			clock-names = "ahb", "mod";
+			dmas = <&dma SUN4I_DMA_DEDICATED 3>;
+			dma-names = "rxtx";
+			status = "disabled";
+			#address-cells = <1>;
+			#size-cells = <0>;
+		};
+
 		spi0: spi@01c05000 {
 			compatible = "allwinner,sun4i-a10-spi";
 			reg = <0x01c05000 0x1000>;
-- 
2.7.3

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [PATCH v2 3/4] ARM: dts: sun7i: Add A20 NAND controller pin definitions
  2016-06-14 11:17 ` [PATCH v2 0/4] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
  2016-06-14 11:17   ` [PATCH v2 1/4] ARM: dts: sun4i: Add A10 NAND controller pin definitions Aleksei Mamlin
  2016-06-14 11:17   ` [PATCH v2 2/4] ARM: dts: sun4i: Add NFC node to Allwinner A10 SoC Aleksei Mamlin
@ 2016-06-14 11:17   ` Aleksei Mamlin
  2016-06-14 11:17   ` [PATCH v2 4/4] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC Aleksei Mamlin
  3 siblings, 0 replies; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-14 11:17 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Boris Brezillon
  Cc: linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi, Aleksei Mamlin

From: Boris Brezillon <boris.brezillon@free-electrons.com>

Define the NAND controller pin configs.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
 arch/arm/boot/dts/sun7i-a20.dtsi | 52 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index de4231e..ad984f8 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -1168,6 +1168,58 @@
 				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
 			};
 
+			nand_pins_a: nand_base0@0 {
+				allwinner,pins = "PC0", "PC1", "PC2",
+						"PC5", "PC8", "PC9", "PC10",
+						"PC11", "PC12", "PC13", "PC14",
+						"PC15", "PC16";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs0_pins_a: nand_cs@0 {
+				allwinner,pins = "PC4";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs1_pins_a: nand_cs@1 {
+				allwinner,pins = "PC3";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs2_pins_a: nand_cs@2 {
+				allwinner,pins = "PC17";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_cs3_pins_a: nand_cs@3 {
+				allwinner,pins = "PC18";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_rb0_pins_a: nand_rb@0 {
+				allwinner,pins = "PC6";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
+			nand_rb1_pins_a: nand_rb@1 {
+				allwinner,pins = "PC7";
+				allwinner,function = "nand0";
+				allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+			};
+
 			ps20_pins_a: ps20@0 {
 				allwinner,pins = "PI20", "PI21";
 				allwinner,function = "ps2";
-- 
2.7.3

^ permalink raw reply	[flat|nested] 33+ messages in thread

* [PATCH v2 4/4] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC
  2016-06-14 11:17 ` [PATCH v2 0/4] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
                     ` (2 preceding siblings ...)
  2016-06-14 11:17   ` [PATCH v2 3/4] ARM: dts: sun7i: Add A20 NAND controller pin definitions Aleksei Mamlin
@ 2016-06-14 11:17   ` Aleksei Mamlin
  2016-06-14 12:33     ` Maxime Ripard
  2016-06-14 13:11     ` kbuild test robot
  3 siblings, 2 replies; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-14 11:17 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Boris Brezillon
  Cc: linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi, Aleksei Mamlin

From: Boris Brezillon <boris.brezillon@free-electrons.com>

Add NAND Flash controller node definition to the A20 SoC.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
 arch/arm/boot/dts/sun7i-a20.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index ad984f8..7d7560f 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -798,6 +798,19 @@
 			#dma-cells = <2>;
 		};
 
+		nfc: nand@01c03000 {
+			compatible = "allwinner,sun4i-a10-nand";
+			reg = <0x01c03000 0x1000>;
+			interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;;
+			clocks = <&ahb_gates 13>, <&nand_clk>;
+			clock-names = "ahb", "mod";
+			dmas = <&dma SUN4I_DMA_DEDICATED 3>;
+			dma-names = "rxtx";
+			status = "disabled";
+			#address-cells = <1>;
+			#size-cells = <0>;
+		};
+
 		spi0: spi@01c05000 {
 			compatible = "allwinner,sun4i-a10-spi";
 			reg = <0x01c05000 0x1000>;
-- 
2.7.3

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH v2 2/4] ARM: dts: sun4i: Add NFC node to Allwinner A10 SoC
  2016-06-14 11:17   ` [PATCH v2 2/4] ARM: dts: sun4i: Add NFC node to Allwinner A10 SoC Aleksei Mamlin
@ 2016-06-14 12:33     ` Maxime Ripard
  0 siblings, 0 replies; 33+ messages in thread
From: Maxime Ripard @ 2016-06-14 12:33 UTC (permalink / raw)
  To: Aleksei Mamlin
  Cc: Chen-Yu Tsai, Boris Brezillon, linux-mtd, linux-kernel,
	linux-arm-kernel, devicetree, linux-sunxi

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

On Tue, Jun 14, 2016 at 02:17:36PM +0300, Aleksei Mamlin wrote:
> From: Boris Brezillon <boris.brezillon@free-electrons.com>
> 
> Add NAND Flash controller node definition to the A10 SoC.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH v2 4/4] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC
  2016-06-14 11:17   ` [PATCH v2 4/4] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC Aleksei Mamlin
@ 2016-06-14 12:33     ` Maxime Ripard
  2016-06-14 13:11     ` kbuild test robot
  1 sibling, 0 replies; 33+ messages in thread
From: Maxime Ripard @ 2016-06-14 12:33 UTC (permalink / raw)
  To: Aleksei Mamlin
  Cc: Chen-Yu Tsai, Boris Brezillon, linux-mtd, linux-kernel,
	linux-arm-kernel, devicetree, linux-sunxi

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

On Tue, Jun 14, 2016 at 02:17:38PM +0300, Aleksei Mamlin wrote:
> From: Boris Brezillon <boris.brezillon@free-electrons.com>
> 
> Add NAND Flash controller node definition to the A20 SoC.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH v2 1/4] ARM: dts: sun4i: Add A10 NAND controller pin definitions
  2016-06-14 11:17   ` [PATCH v2 1/4] ARM: dts: sun4i: Add A10 NAND controller pin definitions Aleksei Mamlin
@ 2016-06-14 12:37     ` Maxime Ripard
  0 siblings, 0 replies; 33+ messages in thread
From: Maxime Ripard @ 2016-06-14 12:37 UTC (permalink / raw)
  To: Aleksei Mamlin
  Cc: Chen-Yu Tsai, Boris Brezillon, linux-mtd, linux-kernel,
	linux-arm-kernel, devicetree, linux-sunxi

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

Hi,

On Tue, Jun 14, 2016 at 02:17:35PM +0300, Aleksei Mamlin wrote:
> From: Boris Brezillon <boris.brezillon@free-electrons.com>
> 
> Define the NAND controller pin configs.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>

Unfortunately, we don't have any user for it at the moment.

Please re-submit it later when we'll have some :)

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH v2 4/4] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC
  2016-06-14 11:17   ` [PATCH v2 4/4] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC Aleksei Mamlin
  2016-06-14 12:33     ` Maxime Ripard
@ 2016-06-14 13:11     ` kbuild test robot
  2016-06-14 13:19       ` Aleksei Mamlin
  1 sibling, 1 reply; 33+ messages in thread
From: kbuild test robot @ 2016-06-14 13:11 UTC (permalink / raw)
  To: Aleksei Mamlin
  Cc: kbuild-all, Maxime Ripard, Chen-Yu Tsai, Boris Brezillon,
	linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi, Aleksei Mamlin

[-- Attachment #1: Type: text/plain, Size: 1128 bytes --]

Hi,

[auto build test ERROR on mripard/sunxi/for-next]
[also build test ERROR on next-20160614]
[cannot apply to robh/for-next v4.7-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Aleksei-Mamlin/dts-sunxi-Add-sunxi-NAND-Flash-Controller-support/20160614-192539
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git sunxi/for-next
config: arm-sunxi_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All errors (new ones prefixed by >>):

>> Error: arch/arm/boot/dts/sun7i-a20.dtsi:806.26-27 syntax error
   FATAL ERROR: Unable to parse input tree

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 20206 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH v2 4/4] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC
  2016-06-14 13:11     ` kbuild test robot
@ 2016-06-14 13:19       ` Aleksei Mamlin
  2016-06-14 13:57         ` Maxime Ripard
  0 siblings, 1 reply; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-14 13:19 UTC (permalink / raw)
  To: kbuild test robot
  Cc: kbuild-all, Maxime Ripard, Chen-Yu Tsai, Boris Brezillon,
	linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi

On Tue, 14 Jun 2016 21:11:12 +0800
kbuild test robot <lkp@intel.com> wrote:

> Hi,
> 
> [auto build test ERROR on mripard/sunxi/for-next]
> [also build test ERROR on next-20160614]
> [cannot apply to robh/for-next v4.7-rc3]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Aleksei-Mamlin/dts-sunxi-Add-sunxi-NAND-Flash-Controller-support/20160614-192539
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git sunxi/for-next
> config: arm-sunxi_defconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm 
> 
> All errors (new ones prefixed by >>):
> 
> >> Error: arch/arm/boot/dts/sun7i-a20.dtsi:806.26-27 syntax error
>    FATAL ERROR: Unable to parse input tree
> 

My bad, dual semicolon at line 806. Maxime, can you fix it locally?

> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation


-- 
Thanks and regards,
Aleksei Mamlin

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH v2 4/4] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC
  2016-06-14 13:19       ` Aleksei Mamlin
@ 2016-06-14 13:57         ` Maxime Ripard
  2016-06-14 14:02           ` Aleksei Mamlin
  0 siblings, 1 reply; 33+ messages in thread
From: Maxime Ripard @ 2016-06-14 13:57 UTC (permalink / raw)
  To: Aleksei Mamlin
  Cc: kbuild test robot, kbuild-all, Chen-Yu Tsai, Boris Brezillon,
	linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi

[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]

On Tue, Jun 14, 2016 at 04:19:08PM +0300, Aleksei Mamlin wrote:
> On Tue, 14 Jun 2016 21:11:12 +0800
> kbuild test robot <lkp@intel.com> wrote:
> 
> > Hi,
> > 
> > [auto build test ERROR on mripard/sunxi/for-next]
> > [also build test ERROR on next-20160614]
> > [cannot apply to robh/for-next v4.7-rc3]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> > 
> > url:    https://github.com/0day-ci/linux/commits/Aleksei-Mamlin/dts-sunxi-Add-sunxi-NAND-Flash-Controller-support/20160614-192539
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git sunxi/for-next
> > config: arm-sunxi_defconfig (attached as .config)
> > compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205
> > reproduce:
> >         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # save the attached .config to linux build tree
> >         make.cross ARCH=arm 
> > 
> > All errors (new ones prefixed by >>):
> > 
> > >> Error: arch/arm/boot/dts/sun7i-a20.dtsi:806.26-27 syntax error
> >    FATAL ERROR: Unable to parse input tree
> > 
> 
> My bad, dual semicolon at line 806. Maxime, can you fix it locally?

Already did :)

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PATCH v2 4/4] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC
  2016-06-14 13:57         ` Maxime Ripard
@ 2016-06-14 14:02           ` Aleksei Mamlin
  0 siblings, 0 replies; 33+ messages in thread
From: Aleksei Mamlin @ 2016-06-14 14:02 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: kbuild test robot, kbuild-all, Chen-Yu Tsai, Boris Brezillon,
	linux-mtd, linux-kernel, linux-arm-kernel, devicetree,
	linux-sunxi

On Tue, 14 Jun 2016 15:57:16 +0200
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:

> On Tue, Jun 14, 2016 at 04:19:08PM +0300, Aleksei Mamlin wrote:
> > On Tue, 14 Jun 2016 21:11:12 +0800
> > kbuild test robot <lkp@intel.com> wrote:
> > 
> > > Hi,
> > > 
> > > [auto build test ERROR on mripard/sunxi/for-next]
> > > [also build test ERROR on next-20160614]
> > > [cannot apply to robh/for-next v4.7-rc3]
> > > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> > > 
> > > url:    https://github.com/0day-ci/linux/commits/Aleksei-Mamlin/dts-sunxi-Add-sunxi-NAND-Flash-Controller-support/20160614-192539
> > > base:   https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git sunxi/for-next
> > > config: arm-sunxi_defconfig (attached as .config)
> > > compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205
> > > reproduce:
> > >         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # save the attached .config to linux build tree
> > >         make.cross ARCH=arm 
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > > >> Error: arch/arm/boot/dts/sun7i-a20.dtsi:806.26-27 syntax error
> > >    FATAL ERROR: Unable to parse input tree
> > > 
> > 
> > My bad, dual semicolon at line 806. Maxime, can you fix it locally?
> 
> Already did :)

Thanks a lot!

> 
> Thanks!
> Maxime
> 
> -- 
> Maxime Ripard, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com


-- 
Thanks and regards,
Aleksei Mamlin

^ permalink raw reply	[flat|nested] 33+ messages in thread

end of thread, other threads:[~2016-06-14 14:02 UTC | newest]

Thread overview: 33+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-06 10:24 [PATCH 0/7] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
2016-06-06 10:24 ` [PATCH 1/7] ARM: dts: sun4i: Add A10 NAND controller pin definitions Aleksei Mamlin
2016-06-08 22:04   ` Maxime Ripard
2016-06-06 10:24 ` [PATCH 2/7] ARM: dts: sun4i: Add NFC node to Allwinner A10 SoC Aleksei Mamlin
2016-06-06 10:24 ` [PATCH 3/7] ARM: dts: sun7i: Add A20 NAND controller pin definitions Aleksei Mamlin
2016-06-06 10:24 ` [PATCH 4/7] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC Aleksei Mamlin
2016-06-07 17:21   ` Aleksei Mamlin
2016-06-06 10:24 ` [PATCH 5/7] mtd: nand: Add Hynix H27UBG8T2BTR-BC to nand_ids table Aleksei Mamlin
2016-06-06 18:55   ` Boris Brezillon
2016-06-06 19:59     ` Aleksei Mamlin
2016-06-06 20:31       ` Boris Brezillon
2016-06-06 21:06         ` Aleksei Mamlin
2016-06-07  5:48           ` Boris Brezillon
2016-06-07  5:49         ` Boris Brezillon
2016-06-06 10:24 ` [PATCH 6/7] ARM: dts: sun4i: Enable NAND on Marsboard A10 Aleksei Mamlin
2016-06-06 18:50   ` Boris Brezillon
2016-06-06 10:24 ` [PATCH 7/7] ARM: dts: sun7i: Enable NAND on Wexler TAB7200 Aleksei Mamlin
2016-06-06 18:51   ` Boris Brezillon
2016-06-08 22:03   ` Maxime Ripard
2016-06-09  8:11     ` Aleksei Mamlin
2016-06-10  8:56       ` Maxime Ripard
2016-06-14 11:17 ` [PATCH v2 0/4] dts: sunxi: Add sunxi NAND Flash Controller support Aleksei Mamlin
2016-06-14 11:17   ` [PATCH v2 1/4] ARM: dts: sun4i: Add A10 NAND controller pin definitions Aleksei Mamlin
2016-06-14 12:37     ` Maxime Ripard
2016-06-14 11:17   ` [PATCH v2 2/4] ARM: dts: sun4i: Add NFC node to Allwinner A10 SoC Aleksei Mamlin
2016-06-14 12:33     ` Maxime Ripard
2016-06-14 11:17   ` [PATCH v2 3/4] ARM: dts: sun7i: Add A20 NAND controller pin definitions Aleksei Mamlin
2016-06-14 11:17   ` [PATCH v2 4/4] ARM: dts: sun7i: Add NFC node to Allwinner A20 SoC Aleksei Mamlin
2016-06-14 12:33     ` Maxime Ripard
2016-06-14 13:11     ` kbuild test robot
2016-06-14 13:19       ` Aleksei Mamlin
2016-06-14 13:57         ` Maxime Ripard
2016-06-14 14:02           ` Aleksei Mamlin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).