From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Julian Calaby <julian.calaby@gmail.com>,
Shengzhen Li <szli@marvell.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Amitkumar Karwar <akarwar@marvell.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Kalle Valo <kvalo@codeaurora.org>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
Nishant Sarmukadam <nishants@marvell.com>
Subject: [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file
Date: Mon, 6 Jun 2016 13:02:37 -0400 [thread overview]
Message-ID: <1465232558-31678-3-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1465232558-31678-1-git-send-email-javier@osg.samsung.com>
From: Shengzhen Li <szli@marvell.com>
Most cfg80211 operations are just a wrappers to functions defined in the
sta_ioctl.c file, so for consistency move the .get_tx_power logic there.
Signed-off-by: Shengzhen Li <szli@marvell.com>
Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
[javier: update the subject line and commit message]
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/net/wireless/marvell/mwifiex/cfg80211.c | 14 +++-----------
drivers/net/wireless/marvell/mwifiex/main.h | 2 ++
drivers/net/wireless/marvell/mwifiex/sta_ioctl.c | 18 ++++++++++++++++++
3 files changed, 23 insertions(+), 11 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index b17f3d09a2c7..ff3f63ed95e1 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -385,18 +385,10 @@ mwifiex_cfg80211_get_tx_power(struct wiphy *wiphy,
int *dbm)
{
struct mwifiex_adapter *adapter = mwifiex_cfg80211_get_adapter(wiphy);
- struct mwifiex_private *priv = mwifiex_get_priv(adapter,
- MWIFIEX_BSS_ROLE_ANY);
- int ret = mwifiex_send_cmd(priv, HostCmd_CMD_RF_TX_PWR,
- HostCmd_ACT_GEN_GET, 0, NULL, true);
-
- if (ret < 0)
- return ret;
-
- /* tx_power_level is set in HostCmd_CMD_RF_TX_PWR command handler */
- *dbm = priv->tx_power_level;
+ struct mwifiex_private *priv;
- return 0;
+ priv = mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY);
+ return mwifiex_get_tx_power(priv, dbm);
}
/*
diff --git a/drivers/net/wireless/marvell/mwifiex/main.h b/drivers/net/wireless/marvell/mwifiex/main.h
index 0207af00be42..79c28cfb7780 100644
--- a/drivers/net/wireless/marvell/mwifiex/main.h
+++ b/drivers/net/wireless/marvell/mwifiex/main.h
@@ -1464,6 +1464,8 @@ int mwifiex_drv_get_driver_version(struct mwifiex_adapter *adapter,
int mwifiex_set_tx_power(struct mwifiex_private *priv,
struct mwifiex_power_cfg *power_cfg);
+int mwifiex_get_tx_power(struct mwifiex_private *priv, int *dbm);
+
int mwifiex_main_process(struct mwifiex_adapter *);
int mwifiex_queue_tx_pkt(struct mwifiex_private *priv, struct sk_buff *skb);
diff --git a/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c b/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
index 8e0862657122..70ff9b805b5b 100644
--- a/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
+++ b/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
@@ -775,6 +775,24 @@ int mwifiex_set_tx_power(struct mwifiex_private *priv,
}
/*
+ * IOCTL request handler to get tx power configuration.
+ *
+ * This function prepares the correct firmware command and
+ * issues it.
+ */
+int mwifiex_get_tx_power(struct mwifiex_private *priv, int *dbm)
+{
+ int ret;
+
+ ret = mwifiex_send_cmd(priv, HostCmd_CMD_TXPWR_CFG,
+ HostCmd_ACT_GEN_GET, 0, NULL, true);
+
+ *dbm = priv->tx_power_level;
+
+ return ret;
+}
+
+/*
* IOCTL request handler to get power save mode.
*
* This function prepares the correct firmware command and
--
2.5.5
next prev parent reply other threads:[~2016-06-06 17:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 17:02 [PATCH v2 0/3] mwifiex: add .get_tx_power and .get_antenna cfg80211 operations Javier Martinez Canillas
2016-06-06 17:02 ` [PATCH v2 1/3] mwifiex: add a cfg80211 .get_tx_power operation callback Javier Martinez Canillas
2016-06-09 8:10 ` Enric Balletbo Serra
2016-07-05 13:29 ` [v2, " Kalle Valo
2016-06-06 17:02 ` Javier Martinez Canillas [this message]
2016-06-09 8:11 ` [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file Enric Balletbo Serra
2016-06-10 14:30 ` Kalle Valo
2016-06-10 14:37 ` Javier Martinez Canillas
2016-06-10 16:26 ` Amitkumar Karwar
2016-06-10 19:33 ` Javier Martinez Canillas
2016-06-10 19:54 ` Kalle Valo
2016-06-21 14:47 ` Javier Martinez Canillas
2016-06-22 6:17 ` Kalle Valo
2016-06-22 12:57 ` Javier Martinez Canillas
2016-06-06 17:02 ` [PATCH v2 3/3] mwifiex: add get_antenna support for cfg80211 Javier Martinez Canillas
2016-06-09 8:12 ` Enric Balletbo Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465232558-31678-3-git-send-email-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=akarwar@marvell.com \
--cc=enric.balletbo@collabora.com \
--cc=julian.calaby@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=szli@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).