Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation

From: Rik van Riel <riel@redhat.com>
To: Johannes Weiner <hannes@cmpxchg.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mgorman@suse.de>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Andi Kleen <andi@firstfloor.org>, Michal Hocko <mhocko@suse.cz>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	kernel-team@fb.com
Subject: Re: [PATCH 05/10] mm: remove LRU balancing effect of temporary page isolation
Date: Mon, 06 Jun 2016 17:56:09 -0400	[thread overview]
Message-ID: <1465250169.16365.147.camel@redhat.com> (raw)
In-Reply-To: <20160606194836.3624-6-hannes@cmpxchg.org>

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

On Mon, 2016-06-06 at 15:48 -0400, Johannes Weiner wrote:
> 
> +void lru_cache_putback(struct page *page)
> +{
> +	struct pagevec *pvec = &get_cpu_var(lru_putback_pvec);
> +
> +	get_page(page);
> +	if (!pagevec_space(pvec))
> +		__pagevec_lru_add(pvec, false);
> +	pagevec_add(pvec, page);
> +	put_cpu_var(lru_putback_pvec);
> +}
> 

Wait a moment.

So now we have a putback_lru_page, which does adjust
the statistics, and an lru_cache_putback which does
not?

This function could use a name that is not as similar
to its counterpart :)

-- 
All Rights Reversed.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]