From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161038AbcFGNQt (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Jun 2016 09:16:49 -0400
Received: from mailgw02.mediatek.com ([210.61.82.184]:50695 "EHLO
	mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1752903AbcFGNQs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Jun 2016 09:16:48 -0400
Message-ID: <1465305402.26524.6.camel@mtksdaap41>
Subject: Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test
From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Andy Whitcroft <apw@canonical.com>
CC: Joe Perches <joe@perches.com>, Andrew Morton <akpm@linux-foundation.org>,
        <linux-kernel@vger.kernel.org>, <srv_heupstream@mediatek.com>,
        Andi Kleen <ak@linux.intel.com>, Paul Bolle <pebolle@tiscali.nl>
Date: Tue, 7 Jun 2016 21:16:42 +0800
In-Reply-To: <20160606191047.GK18360@brain>
References: <1465017040-12777-1-git-send-email-yingjoe.chen@mediatek.com>
	 <1465231395.25087.13.camel@perches.com> <20160606191047.GK18360@brain>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi,

Thanks for the review.


On Mon, 2016-06-06 at 20:10 +0100, Andy Whitcroft wrote:
> On Mon, Jun 06, 2016 at 09:43:15AM -0700, Joe Perches wrote:
> > On Sat, 2016-06-04 at 13:10 +0800, Yingjoe Chen wrote:
> > > If a Kconfig config option doesn't specify 'default', the default
> > > will be n. Adding 'default n' is unnecessary.
> > > Add a test to warn about this.
> > 
> > Is it obvious that a Kconfig has "default n" ?
> > This seems to work, but is this useful?


While sending patch for upstream, I saw maintainers request it to be
removed. So I think it might worth adding check to it.
Some examples from google:

http://lists.infradead.org/pipermail/linux-arm-kernel/2012-September/120733.html
https://lkml.org/lkml/2013/3/16/153
https://lkml.org/lkml/2016/5/23/657


> 
> > > +		if ($realfile =~ /Kconfig/ &&
> > > +		    $line =~ /^\+\s*default\s*n\s*(#.*|$)/i) {
> 
> I wonder particually when the submitter has supplied a comment, presumably
> to tell us why it defaults to 'n'.  I feel more accepting of rejecting
> uncommented ones than those with.


How about change this to /^\+\s*default\s*n$/i ?

Joe.C