From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422819AbcFGU1H (ORCPT ); Tue, 7 Jun 2016 16:27:07 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:39828 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161015AbcFGU1F (ORCPT ); Tue, 7 Jun 2016 16:27:05 -0400 From: Mike Kravetz To: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Shuah Khan , Sri Jayaramappa , Eric B Munson , Andrew Morton , Mike Kravetz Subject: [PATCH] selftests/vm/compaction_test: fix write to restore nr_hugepages Date: Tue, 7 Jun 2016 13:26:45 -0700 Message-Id: <1465331205-3284-1-git-send-email-mike.kravetz@oracle.com> X-Mailer: git-send-email 2.4.11 X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The write at the end of the test to restore nr_hugepages to its previous value is failing. This is because it is trying to write the number of bytes in the char array as opposed to the number of bytes in the string. Signed-off-by: Mike Kravetz --- tools/testing/selftests/vm/compaction_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/vm/compaction_test.c b/tools/testing/selftests/vm/compaction_test.c index 932ff57..00c4f65 100644 --- a/tools/testing/selftests/vm/compaction_test.c +++ b/tools/testing/selftests/vm/compaction_test.c @@ -136,7 +136,7 @@ int check_compaction(unsigned long mem_free, unsigned int hugepage_size) printf("No of huge pages allocated = %d\n", (atoi(nr_hugepages))); - if (write(fd, initial_nr_hugepages, sizeof(initial_nr_hugepages)) + if (write(fd, initial_nr_hugepages, strlen(initial_nr_hugepages)) != strlen(initial_nr_hugepages)) { perror("Failed to write to /proc/sys/vm/nr_hugepages\n"); goto close_fd; -- 2.4.11