From: Chris Metcalf <cmetcalf@mellanox.com>
To: Andrew Morton <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>, <kbuild-all@01.org>,
kbuild test robot <fengguang.wu@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Linux Memory Management List <linux-mm@kvack.org>
Cc: Chris Metcalf <cmetcalf@mellanox.com>
Subject: [PATCH] tile: allow disabling CONFIG_EARLY_PRINTK
Date: Tue, 7 Jun 2016 16:56:27 -0400 [thread overview]
Message-ID: <1465332987-28114-1-git-send-email-cmetcalf@mellanox.com> (raw)
In-Reply-To: <20160607125245.79a26fd3fee40afaa8ca04ff@linux-foundation.org>
In that case, any users of early_panic() end up calling panic().
Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com>
---
I don't think this is a recent breakage, and it doesn't feel too
critical, so I'll just push it in the next merge window.
arch/tile/include/asm/setup.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/tile/include/asm/setup.h b/arch/tile/include/asm/setup.h
index e98909033e5b..2a0347af0702 100644
--- a/arch/tile/include/asm/setup.h
+++ b/arch/tile/include/asm/setup.h
@@ -25,7 +25,12 @@
#define MAXMEM_PFN PFN_DOWN(MAXMEM)
int tile_console_write(const char *buf, int count);
+
+#ifdef CONFIG_EARLY_PRINTK
void early_panic(const char *fmt, ...);
+#else
+#define early_panic panic
+#endif
/* Init-time routine to do tile-specific per-cpu setup. */
void setup_cpu(int boot);
--
2.7.2
prev parent reply other threads:[~2016-06-07 20:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-05 4:33 undefined reference to `early_panic' kbuild test robot
2016-06-06 20:31 ` Andrew Morton
2016-06-06 20:36 ` Chris Metcalf
2016-06-06 23:31 ` Stephen Rothwell
2016-06-07 9:17 ` tile: early_printk.o is always required kbuild test robot
2016-06-07 19:52 ` Andrew Morton
2016-06-07 20:56 ` Chris Metcalf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465332987-28114-1-git-send-email-cmetcalf@mellanox.com \
--to=cmetcalf@mellanox.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).