From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161188AbcFHDcb (ORCPT ); Tue, 7 Jun 2016 23:32:31 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:47579 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1161119AbcFHDca (ORCPT ); Tue, 7 Jun 2016 23:32:30 -0400 Message-ID: <1465356742.18601.7.camel@mtksdaap41> Subject: Re: [alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation. From: Garlic Tseng To: Mark Brown CC: , , , , , , , , Date: Wed, 8 Jun 2016 11:32:22 +0800 In-Reply-To: <20160607163112.GD7510@sirena.org.uk> References: <1464929784-5489-1-git-send-email-garlic.tseng@mediatek.com> <1464929784-5489-7-git-send-email-garlic.tseng@mediatek.com> <20160607163112.GD7510@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-06-07 at 17:31 +0100, Mark Brown wrote: > On Fri, Jun 03, 2016 at 12:56:21PM +0800, Garlic Tseng wrote: > > > + if (val < 0 || val > MT2701_I2S_NUM) { > > + dev_err(afe->dev, "%s, num not available, num %d, val %d\n", > > + __func__, num, val); > > + return -1; > > Real error codes please. OK I'll fix it. > > > +static const struct snd_kcontrol_new mt2701_afe_multi_ch_out_asrc3[] = { > > + SOC_DAPM_SINGLE_AUTODISABLE("Multi ch asrc out3", PWR2_TOP_CON, 7, 1, > > + 1), > > +}; > > On/off controls should end in Switch. Do you means that the name should end in Switch? Something like "Multi ch asrc out3 Switch" (or maybe a shorter one) I'll fix it (if I don't misunderstand the comment) Thanks! > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel