From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932563AbcFHLUt (ORCPT ); Wed, 8 Jun 2016 07:20:49 -0400 Received: from ozlabs.org ([103.22.144.67]:39123 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750964AbcFHLUr (ORCPT ); Wed, 8 Jun 2016 07:20:47 -0400 Message-ID: <1465384845.13854.7.camel@ellerman.id.au> Subject: Re: [PATCH v3] powerpc: spinlock: Fix spin_unlock_wait() From: Michael Ellerman To: Peter Zijlstra Cc: linuxppc-dev@lists.ozlabs.org, Linux Kernel Mailing List , Benjamin Herrenschmidt , Paul Mackerras , "Paul E. McKenney" , Will Deacon , Boqun Feng Date: Wed, 08 Jun 2016 21:20:45 +1000 In-Reply-To: <20160606144659.GG30909@twins.programming.kicks-ass.net> References: <1465213340.2658.1.camel@ellerman.id.au> <20160606115655.GD30909@twins.programming.kicks-ass.net> <1465215445.2658.4.camel@ellerman.id.au> <20160606144659.GG30909@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-06-06 at 16:46 +0200, Peter Zijlstra wrote: > On Mon, Jun 06, 2016 at 10:17:25PM +1000, Michael Ellerman wrote: > > On Mon, 2016-06-06 at 13:56 +0200, Peter Zijlstra wrote: > > > On Mon, Jun 06, 2016 at 09:42:20PM +1000, Michael Ellerman wrote: > > > > > > Why the move to in-line this implementation? It looks like a fairly big > > > function. > > > > I agree it's not pretty. > > > I'm not beholden to v3 though if you hate it. > > I don't mind; its just that I am in a similar boat with qspinlock and > chose the other option. So I just figured I'd ask :-) OK. I'll go with inline and we'll see which version gets "cleaned-up" by a janitor first ;) cheers