From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424594AbcFHX30 (ORCPT ); Wed, 8 Jun 2016 19:29:26 -0400 Received: from mga01.intel.com ([192.55.52.88]:37205 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932342AbcFHX3Y (ORCPT ); Wed, 8 Jun 2016 19:29:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,441,1459839600"; d="scan'208";a="971842643" From: "Zanoni, Paulo R" To: "mmarek@suse.com" CC: "linux-kbuild@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "yamada.masahiro@socionext.com" , "mmarek@suse.cz" , "nicolas.pitre@linaro.org" Subject: Re: Regression in "kbuild: fix if_change and friends to consider argument order" Thread-Topic: Regression in "kbuild: fix if_change and friends to consider argument order" Thread-Index: AQHRwF1R1qIRFa3s/0KanTGyfUyyU5/eNUcAgAAFpwCAAAF+AIAADGmAgAALn4CAACzYgIAAgSGAgAGtXQA= Date: Wed, 8 Jun 2016 23:29:22 +0000 Message-ID: <1465428562.3885.75.camel@intel.com> References: <1465263518.3885.9.camel@intel.com> <5756960E.5020706@suse.com> <57569ACC.8050503@suse.cz> <5756A675.3080003@suse.cz> <1465308627.3885.61.camel@intel.com> <20160607215237.GA13237@sepie.suse.cz> In-Reply-To: <20160607215237.GA13237@sepie.suse.cz> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.1.155] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u58NTWlb013892 Em Ter, 2016-06-07 às 23:52 +0200, Michal Marek escreveu: > On Tue, Jun 07, 2016 at 02:10:28PM +0000, Zanoni, Paulo R wrote: > >  > > From b36fad65d61fffe4b662d4bfb1ed673c455a36a2 Mon Sep 17 00:00:00 > 2001 > From: Michal Marek > Date: Tue, 7 Jun 2016 11:57:02 +0200 > Subject: [PATCH] kbuild: Initialize exported variables > > The NOSTDINC_FLAGS variable is exported, so it needs to be cleared to > avoid duplicating its content when running make from within make > (e.g. > in the packaging targets). This became an issue after commit > 9c8fa9bc08f6 ("kbuild: fix if_change and friends to consider argument > order"), which no longer ignores the duplicate options. As Paulo > Zanoni > points out, the LDFLAGS_vmlinux variable has the same problem. > > Reported-by: "Zanoni, Paulo R" > Fixes: 9c8fa9bc08f6 ("kbuild: fix if_change and friends to consider > argument order") > Signed-off-by: Michal Marek Works for me. Tested-by: Paulo Zanoni Thanks a lot! > --- >  Makefile | 2 ++ >  1 file changed, 2 insertions(+) > > diff --git a/Makefile b/Makefile > index 0f70de63cfdb..af0c463e908f 100644 > --- a/Makefile > +++ b/Makefile > @@ -363,11 +363,13 @@ CHECK = sparse >   >  CHECKFLAGS     := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ \ >     -Wbitwise -Wno-return-void $(CF) > +NOSTDINC_FLAGS  = >  CFLAGS_MODULE   = >  AFLAGS_MODULE   = >  LDFLAGS_MODULE  = >  CFLAGS_KERNEL = >  AFLAGS_KERNEL = > +LDFLAGS_vmlinux = >  CFLAGS_GCOV = -fprofile-arcs -ftest-coverage -fno-tree-loop- > im -Wno-maybe-uninitialized >  CFLAGS_KCOV = -fsanitize-coverage=trace-pc >