From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424587AbcFIFiO (ORCPT ); Thu, 9 Jun 2016 01:38:14 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:42753 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161697AbcFIFiM (ORCPT ); Thu, 9 Jun 2016 01:38:12 -0400 Message-ID: <1465450690.5365.145.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH] target: Fix for hang of Ordered task in TCM From: "Nicholas A. Bellinger" To: "Bryant G. Ly" Cc: mikecyr@linux.vnet.ibm.com, rjui@broadcom.com, sbranden@broadcom.com, jonmason@broadcom.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, seroyer@linux.vnet.ibm.com Date: Wed, 08 Jun 2016 22:38:10 -0700 In-Reply-To: <1465415022-79833-1-git-send-email-bryantly@linux.vnet.ibm.com> References: <1464067904.22249.53.camel@haakon3.risingtidesystems.com> <1465415022-79833-1-git-send-email-bryantly@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-06-08 at 14:43 -0500, Bryant G. Ly wrote: > > Hi Nic, > > So I was testing the ibmvscsi target driver and I ran into some problems > again with UA stuff and it looks like you didnt remove the UA checks from > target_setup_cmd_from_cdb? Was that intentional? I thought we agreed to move > it completely to target_execute_cmd and not have both? > > Let me know. > Ah yes, the version of the patch I've been using for future target-core developments was missing the removal in target_setup_cmd_from_cdb(). Applied the proper version to target-pending/master here: https://git.kernel.org/cgit/linux/kernel/git/nab/target-pending.git/commit/?id=15ce22fa491aa3bab7acd89ac40a9fc27aeed915 Thanks for the heads up!