* [PATCH] pci: make bus_attr_resource_alignemnt static
@ 2016-06-09 10:42 Ben Dooks
2016-06-11 0:21 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2016-06-09 10:42 UTC (permalink / raw)
To: linux-kernel; +Cc: Ben Dooks, Bjorn Helgaas, linux-pci, linux-kernel
The symbol bus_attr_resource_alignment is not exported or declared
elsewhere, so make it static to fix the following warning:
drivers/pci/pci.c:4900:1: warning: symbol 'bus_attr_resource_alignment' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/pci/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index c8b4dbd..9add285 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -4897,7 +4897,7 @@ static ssize_t pci_resource_alignment_store(struct bus_type *bus,
return pci_set_resource_alignment_param(buf, count);
}
-BUS_ATTR(resource_alignment, 0644, pci_resource_alignment_show,
+static BUS_ATTR(resource_alignment, 0644, pci_resource_alignment_show,
pci_resource_alignment_store);
static int __init pci_resource_alignment_sysfs_init(void)
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pci: make bus_attr_resource_alignemnt static
2016-06-09 10:42 [PATCH] pci: make bus_attr_resource_alignemnt static Ben Dooks
@ 2016-06-11 0:21 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2016-06-11 0:21 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-kernel, Bjorn Helgaas, linux-pci, linux-kernel
On Thu, Jun 09, 2016 at 11:42:13AM +0100, Ben Dooks wrote:
> The symbol bus_attr_resource_alignment is not exported or declared
> elsewhere, so make it static to fix the following warning:
>
> drivers/pci/pci.c:4900:1: warning: symbol 'bus_attr_resource_alignment' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Applied to pci/misc for v4.8, thanks, Ben.
> ---
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/pci/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index c8b4dbd..9add285 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -4897,7 +4897,7 @@ static ssize_t pci_resource_alignment_store(struct bus_type *bus,
> return pci_set_resource_alignment_param(buf, count);
> }
>
> -BUS_ATTR(resource_alignment, 0644, pci_resource_alignment_show,
> +static BUS_ATTR(resource_alignment, 0644, pci_resource_alignment_show,
> pci_resource_alignment_store);
>
> static int __init pci_resource_alignment_sysfs_init(void)
> --
> 2.8.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-11 0:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-09 10:42 [PATCH] pci: make bus_attr_resource_alignemnt static Ben Dooks
2016-06-11 0:21 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).