From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751664AbcFITju (ORCPT ); Thu, 9 Jun 2016 15:39:50 -0400 Received: from mail-qg0-f66.google.com ([209.85.192.66]:35294 "EHLO mail-qg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751574AbcFITjr (ORCPT ); Thu, 9 Jun 2016 15:39:47 -0400 From: Chris Cesare To: abbotti@mev.co.uk Cc: hsweeten@visionengravers.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Chris Cesare Subject: [PATCH v2 2/2] staging: comedi: serial2002: Fix unnecessary cast styling issue Date: Thu, 9 Jun 2016 15:39:03 -0400 Message-Id: <1465501143-10445-3-git-send-email-chris.cesare@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1465501143-10445-1-git-send-email-chris.cesare@gmail.com> References: <57593890.2060800@mev.co.uk> <1465501143-10445-1-git-send-email-chris.cesare@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org checkpatch.pl warns that a cast of 1 to (long long) is unnecessary. Remove the cast and also add code to check and make sure that maxdata_list[chan] is not shifted too far, as suggested by Ian Abbott. Signed-off-by Chris Cesare --- drivers/staging/comedi/drivers/serial2002.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/serial2002.c b/drivers/staging/comedi/drivers/serial2002.c index b777946..0d33e52 100644 --- a/drivers/staging/comedi/drivers/serial2002.c +++ b/drivers/staging/comedi/drivers/serial2002.c @@ -379,7 +379,10 @@ static int serial2002_setup_subdevice(struct comedi_subdevice *s, range_table_list[chan] = (const struct comedi_lrange *)&range[j]; } - maxdata_list[chan] = ((long long)1 << cfg[j].bits) - 1; + if (cfg[j].bits < 32) + maxdata_list[chan] = (1u << cfg[j].bits) - 1; + else + maxdata_list[chan] = 0xffffffff; chan++; } } -- 2.7.4