From: Eric Dumazet <eric.dumazet@gmail.com>
To: Su Xuemin <suxm@chinanetcenter.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH v4] udp reuseport: fix packet of same flow hashed to different socket
Date: Sun, 12 Jun 2016 20:13:31 -0700 [thread overview]
Message-ID: <1465787611.7945.142.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <1465786970-10157-1-git-send-email-suxm@chinanetcenter.com>
On Mon, 2016-06-13 at 11:02 +0800, Su Xuemin wrote:
> From: "Su, Xuemin" <suxm@chinanetcenter.com>
>
> There is a corner case in which udp packets belonging to a same
> flow are hashed to different socket when hslot->count changes from 10
> to 11:
...
> Signed-off-by: Su, Xuemin <suxm@chinanetcenter.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> I use this tree to generate the patch:
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>
> net/ipv4/udp.c | 73 +++++++++++++---------------------------------------------
> net/ipv6/udp.c | 71 +++++++++++++-------------------------------------------
> 2 files changed, 32 insertions(+), 112 deletions(-)
Very nice simplification of UDP stack, thanks a lot for finalizing this.
next prev parent reply other threads:[~2016-06-13 3:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 3:02 [PATCH v4] udp reuseport: fix packet of same flow hashed to different socket Su Xuemin
2016-06-13 3:13 ` Eric Dumazet [this message]
2016-06-14 22:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465787611.7945.142.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=suxm@chinanetcenter.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).