From: Sinan Kaya <okaya@codeaurora.org>
To: kvm@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org,
jcm@redhat.com, alex.williamson@redhat.com,
eric.auger@linaro.org
Cc: linux-acpi@vger.kernel.org, agross@codeaurora.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sinan Kaya <okaya@codeaurora.org>,
Baptiste Reynal <b.reynal@virtualopensystems.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH V7 8/9] vfio: platform: check reset call return code during open
Date: Mon, 13 Jun 2016 00:26:40 -0400 [thread overview]
Message-ID: <1465792001-27960-9-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1465792001-27960-1-git-send-email-okaya@codeaurora.org>
Open call is ignoring the return code from reset call and can
potentially continue even though reset call failed.
If reset_required module parameter is set, this patch is going
to validate the return code and will abort open if reset fails.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
drivers/vfio/platform/vfio_platform_common.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
index d84c399..d3141e7 100644
--- a/drivers/vfio/platform/vfio_platform_common.c
+++ b/drivers/vfio/platform/vfio_platform_common.c
@@ -264,6 +264,8 @@ static int vfio_platform_open(void *device_data)
mutex_lock(&driver_lock);
if (!vdev->refcnt) {
+ const char *extra_dbg = NULL;
+
ret = vfio_platform_regions_init(vdev);
if (ret)
goto err_reg;
@@ -272,7 +274,12 @@ static int vfio_platform_open(void *device_data)
if (ret)
goto err_irq;
- vfio_platform_call_reset(vdev, NULL);
+ ret = vfio_platform_call_reset(vdev, &extra_dbg);
+ if (ret && vdev->reset_required) {
+ dev_warn(vdev->device, "reset driver is required and reset call failed in open (%d) %s\n",
+ ret, extra_dbg ? extra_dbg : "");
+ goto err_rst;
+ }
}
vdev->refcnt++;
@@ -280,6 +287,8 @@ static int vfio_platform_open(void *device_data)
mutex_unlock(&driver_lock);
return 0;
+err_rst:
+ vfio_platform_irq_cleanup(vdev);
err_irq:
vfio_platform_regions_cleanup(vdev);
err_reg:
--
1.8.2.1
next prev parent reply other threads:[~2016-06-13 4:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1465792001-27960-1-git-send-email-okaya@codeaurora.org>
2016-06-13 4:26 ` [PATCH V7 1/9] vfio: platform: rename reset function Sinan Kaya
2016-06-13 4:26 ` [PATCH V7 2/9] vfio: platform: move reset call to a common function Sinan Kaya
2016-06-13 4:26 ` [PATCH V7 3/9] vfio: platform: determine reset capability Sinan Kaya
2016-06-13 4:26 ` [PATCH V7 4/9] vfio: platform: add support for ACPI probe Sinan Kaya
2016-06-13 4:26 ` [PATCH V7 5/9] vfio: platform: add extra debug info argument to call reset Sinan Kaya
2016-06-13 4:26 ` [PATCH V7 6/9] vfio: platform: call _RST method when using ACPI Sinan Kaya
2016-06-23 18:59 ` Alex Williamson
2016-06-23 19:07 ` Alex Williamson
2016-06-23 19:14 ` Sinan Kaya
2016-07-13 19:39 ` Sinan Kaya
2016-07-13 20:11 ` Alex Williamson
2016-06-13 4:26 ` [PATCH V7 7/9] vfio, platform: make reset driver a requirement by default Sinan Kaya
2016-06-16 8:15 ` Auger Eric
2016-06-16 17:08 ` Sinan Kaya
2016-06-13 4:26 ` Sinan Kaya [this message]
2016-06-15 20:08 ` [PATCH V7 8/9] vfio: platform: check reset call return code during open Auger Eric
2016-06-13 4:26 ` [PATCH V7 9/9] vfio: platform: check reset call return code during release Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465792001-27960-9-git-send-email-okaya@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=alex.williamson@redhat.com \
--cc=b.reynal@virtualopensystems.com \
--cc=cov@codeaurora.org \
--cc=eric.auger@linaro.org \
--cc=jcm@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).