From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424576AbcFMPQt (ORCPT ); Mon, 13 Jun 2016 11:16:49 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:34719 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423555AbcFMPQq (ORCPT ); Mon, 13 Jun 2016 11:16:46 -0400 Message-ID: <1465831003.7945.161.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [PATCH v1 1/1] ipv4: Prevent malformed UFO fragments in ip_append_page From: Eric Dumazet To: Steven Caron Cc: Hannes Frederic Sowa , Cong Wang , "linux-kernel@vger.kernel.org" , Linux Kernel Network Developers Date: Mon, 13 Jun 2016 08:16:43 -0700 In-Reply-To: <6A051441C8B95A448E49718A747690B901CA76C84F@gbplmail03.genband.com> References: <6A051441C8B95A448E49718A747690B901CA76C84F@gbplmail03.genband.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-06-13 at 14:01 +0000, Steven Caron wrote: > As the ip fragment offset field counts 8-byte chunks, non-final ip > fragments must be multiples of 8 bytes of payload. Depending on the > mtu and ip option sizes, ip_append_page wasn't respecting this, > notably when running NFS under UDP. > > Signed-off-by: Steven Caron > --- Acked-by: Eric Dumazet