From: "Jiang, Dave" <dave.jiang@intel.com>
To: "Allen.Hubbe@emc.com" <Allen.Hubbe@emc.com>,
"logang@deltatee.com" <logang@deltatee.com>,
"jdmason@kudzu.us" <jdmason@kudzu.us>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"shuahkh@osg.samsung.com" <shuahkh@osg.samsung.com>,
"sudipm.mukherjee@gmail.com" <sudipm.mukherjee@gmail.com>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-ntb@googlegroups.com" <linux-ntb@googlegroups.com>
Subject: Re: [PATCH 1/8] ntb_perf: Schedule based on time not on performance
Date: Mon, 13 Jun 2016 18:05:34 +0000 [thread overview]
Message-ID: <1465841117.16234.248.camel@intel.com> (raw)
In-Reply-To: <03a622a20a667b17046fbd45bb952f8dbd235653.1465598632.git.logang@deltatee.com>
On Fri, 2016-06-10 at 16:54 -0600, Logan Gunthorpe wrote:
> When debugging performance problems, if some issue causes the ntb
> hardware to be significantly slower than expected, ntb_perf will
> hang requiring a reboot because it only schedules once every 4GB.
>
> Instead, schedule based on jiffies so it will not hang the CPU if
> the transfer is slow.
>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Acked-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/ntb/test/ntb_perf.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ntb/test/ntb_perf.c
> b/drivers/ntb/test/ntb_perf.c
> index 4368519..5008ccf 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -273,6 +273,7 @@ static int perf_move_data(struct pthr_ctx *pctx,
> char __iomem *dst, char *src,
> char __iomem *tmp = dst;
> u64 perf, diff_us;
> ktime_t kstart, kstop, kdiff;
> + unsigned long last_sleep = jiffies;
>
> chunks = div64_u64(win_size, buf_size);
> total_chunks = div64_u64(total, buf_size);
> @@ -288,8 +289,9 @@ static int perf_move_data(struct pthr_ctx *pctx,
> char __iomem *dst, char *src,
> } else
> tmp += buf_size;
>
> - /* Probably should schedule every 4GB to prevent
> soft hang. */
> - if (((copied % SZ_4G) == 0) && !use_dma) {
> + /* Probably should schedule every 5s to prevent soft
> hang. */
> + if (unlikely((jiffies - last_sleep) > 5 * HZ)) {
> + last_sleep = jiffies;
> set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(1);
> }
> --
> 2.1.4
>
next prev parent reply other threads:[~2016-06-13 18:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1465598632.git.logang@deltatee.com>
[not found] ` <e447cedb6197b62f141e7688ed2329c259f33eb9.1465598632.git.logang@deltatee.com>
2016-06-11 2:27 ` [PATCH 6/8] ntb_tool: Add link status file to debugfs Allen Hubbe
2016-06-11 15:28 ` Logan Gunthorpe
2016-06-12 1:28 ` Allen Hubbe
2016-06-14 15:45 ` Allen Hubbe
2016-06-14 15:48 ` Logan Gunthorpe
2016-06-14 15:54 ` Allen Hubbe
[not found] ` <d9488f2c946644c2b1258a78929d3543747283ec.1465598632.git.logang@deltatee.com>
2016-06-11 2:35 ` [PATCH 5/8] ntb_tool: BUG: Ensure the buffer size is large enough to return all spads Allen Hubbe
2016-06-11 15:29 ` Logan Gunthorpe
[not found] ` <a326e5cfecc9c780e97d9ce1665d13474b7367c3.1465598632.git.logang@deltatee.com>
2016-06-11 2:46 ` [PATCH 7/8] ntb_pingpong: Add a debugfs file to get the ping count Allen Hubbe
2016-06-11 15:30 ` Logan Gunthorpe
[not found] ` <03a622a20a667b17046fbd45bb952f8dbd235653.1465598632.git.logang@deltatee.com>
2016-06-13 18:05 ` Jiang, Dave [this message]
[not found] ` <65833d43bfcc3e37cbd136fa2a033b8948982629.1465598632.git.logang@deltatee.com>
2016-06-13 18:16 ` [PATCH 2/8] ntb_perf: Improve thread handling to increase robustness Jiang, Dave
[not found] ` <c859fa29b84c39cb952611904ecbf0ca02077840.1465598632.git.logang@deltatee.com>
2016-06-13 20:09 ` [PATCH 3/8] ntb_perf: Return results by reading the run file Jiang, Dave
[not found] ` <71664260d670af5f24beb9c825791802659f3cd2.1465598632.git.logang@deltatee.com>
2016-06-13 20:14 ` [PATCH 4/8] ntb_perf: Wait for link before running test Jiang, Dave
[not found] ` <773161e84a4447a0a91edb42fe18171819ef2319.1465598632.git.logang@deltatee.com>
2016-06-14 14:06 ` [PATCH 8/8] ntb_test: Add a selftest script for the NTB subsystem Jon Mason
2016-06-14 14:16 ` Shuah Khan
2016-06-14 15:45 ` Logan Gunthorpe
2016-06-14 15:47 ` Allen Hubbe
2016-06-14 15:49 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465841117.16234.248.camel@intel.com \
--to=dave.jiang@intel.com \
--cc=Allen.Hubbe@emc.com \
--cc=arnd@arndb.de \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=logang@deltatee.com \
--cc=shuahkh@osg.samsung.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).