From: "João Paulo Rechi Vita" <jprvita@gmail.com>
To: Darren Hart <dvhart@infradead.org>,
Corentin Chary <corentin.chary@gmail.com>
Cc: platform-driver-x86@vger.kernel.org,
acpi4asus-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux@endlessm.com,
"João Paulo Rechi Vita" <jprvita@endlessm.com>
Subject: [PATCH 6/7] asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UF
Date: Mon, 13 Jun 2016 16:57:35 -0400 [thread overview]
Message-ID: <1465851456-1421-7-git-send-email-jprvita@endlessm.com> (raw)
In-Reply-To: <1465851456-1421-1-git-send-email-jprvita@endlessm.com>
The Asus X456UF has an airplane-mode indicator LED and the WMI WLAN user
bit set, so asus-wmi uses ASUS_WMI_DEVID_WLAN_LED (0x00010002) to store
the wlan state, which has a side-effect of driving the airplane mode
indicator LED in an inverted fashion.
quirk_no_rfkill prevents asus-wmi from registering RFKill switches at
all for this laptop and allows asus-wireless to drive the LED through
the ASHS ACPI device. This laptop already has a quirk for setting
WAPF=4, so this commit creates a new quirk, quirk_no_rfkill_wapf4, which
both disables rfkill and sets WAPF=4.
Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
Reported-by: Carlo Caione <carlo@endlessm.com>
---
drivers/platform/x86/asus-nb-wmi.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index 7b5c444..87cd60b 100644
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -82,6 +82,11 @@ static struct quirk_entry quirk_no_rfkill = {
.no_rfkill = true,
};
+static struct quirk_entry quirk_no_rfkill_wapf4 = {
+ .wapf = 4,
+ .no_rfkill = true,
+};
+
static int dmi_matched(const struct dmi_system_id *dmi)
{
quirks = dmi->driver_data;
@@ -146,7 +151,7 @@ static const struct dmi_system_id asus_quirks[] = {
DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
DMI_MATCH(DMI_PRODUCT_NAME, "X456UF"),
},
- .driver_data = &quirk_asus_wapf4,
+ .driver_data = &quirk_no_rfkill_wapf4,
},
{
.callback = dmi_matched,
--
2.5.0
next prev parent reply other threads:[~2016-06-13 20:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 20:57 [PATCH 0/7] asus-wireless: LED control João Paulo Rechi Vita
2016-06-13 20:57 ` [PATCH 1/7] asus-wireless: Toggle airplane mode LED João Paulo Rechi Vita
2016-06-13 20:57 ` [PATCH 2/7] asus-wmi: Create quirk for airplane_mode LED João Paulo Rechi Vita
2016-06-19 7:13 ` Corentin Chary
2016-06-13 20:57 ` [PATCH 3/7] asus-wmi: Add quirk_no_rfkill for the Asus N552VW João Paulo Rechi Vita
2016-06-13 20:57 ` [PATCH 4/7] asus-wmi: Add quirk_no_rfkill for the Asus U303LB João Paulo Rechi Vita
2016-06-13 20:57 ` [PATCH 5/7] asus-wmi: Add quirk_no_rfkill for the Asus Z550MA João Paulo Rechi Vita
2016-06-13 20:57 ` João Paulo Rechi Vita [this message]
2016-06-13 20:57 ` [PATCH 7/7] asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UA João Paulo Rechi Vita
2016-07-01 23:07 ` Darren Hart
2016-06-19 7:19 ` [PATCH 0/7] asus-wireless: LED control Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465851456-1421-7-git-send-email-jprvita@endlessm.com \
--to=jprvita@gmail.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=dvhart@infradead.org \
--cc=jprvita@endlessm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).