From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1424220AbcFNCTx (ORCPT <rfc822;w@1wt.eu>);
	Mon, 13 Jun 2016 22:19:53 -0400
Received: from mailgw01.mediatek.com ([218.249.47.110]:34972 "EHLO
	mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1422950AbcFNCTu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 13 Jun 2016 22:19:50 -0400
Message-ID: <1465870780.19154.0.camel@mhfsdcap03>
Subject: Re: [PATCH v3,2/5] dt-bindings: mt8173-mtu3: add devicetree bindings
From: chunfeng yun <chunfeng.yun@mediatek.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        "Alan Stern" <stern@rowland.harvard.edu>,
        Rob Herring <robh+dt@kernel.org>,
        "Mark Rutland" <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        Pawel Moll <pawel.moll@arm.com>, Kumar Gala <galak@codeaurora.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Alan Cooper <alcooperx@gmail.com>, <linux-usb@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>
Date: Tue, 14 Jun 2016 10:19:40 +0800
In-Reply-To: <878tyd761u.fsf@linux.intel.com>
References: <1465543962-11678-1-git-send-email-chunfeng.yun@mediatek.com>
	 <1465543962-11678-3-git-send-email-chunfeng.yun@mediatek.com>
	 <878tyd761u.fsf@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2016-06-10 at 12:21 +0300, Felipe Balbi wrote:
> Hi,
> 
> Chunfeng Yun <chunfeng.yun@mediatek.com> writes:
> > + - enable-manual-drd : supports manual dual-role switch via sysfs; only used
> > +	when receptacle is TYPE-A and also wants to support dual-role mode.
> 
> sorry, but this manual-drd can't be accepted. You should rely on a DT
> property for this and you shouldn't expose it to sysfs. Use DebugFS for
> that.
I will make use of debugfs instead
Thanks a lot
> 
>