* [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO detection
@ 2016-06-14 14:04 ` Roger Quadros
2016-06-15 1:57 ` Chanwoo Choi
2016-06-15 8:12 ` Roger Quadros
0 siblings, 2 replies; 5+ messages in thread
From: Roger Quadros @ 2016-06-14 14:04 UTC (permalink / raw)
To: myungjoo.ham, cw00.choi
Cc: balbi, nm, grygorii.strashko, linux-kernel, linux-omap, Roger Quadros
If USB cable is connected prior to boot, we don't get any interrupts
so we must manually check the VBUS state and report it during probe.
If we don't do it then USB controller will never know that peripheral
cable was connected till the user unplugs and replugs the cable.
Fixes: b7aad8e2685b ("extcon: palmas: Add the support for VBUS detection by using GPIO")
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
drivers/extcon/extcon-palmas.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
index 8b3226d..caff46c 100644
--- a/drivers/extcon/extcon-palmas.c
+++ b/drivers/extcon/extcon-palmas.c
@@ -360,6 +360,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
palmas_enable_irq(palmas_usb);
/* perform initial detection */
+ if (palmas_usb->enable_gpio_vbus_detection)
+ palmas_vbus_irq_handler(palmas_usb->gpio_vbus_irq, palmas_usb);
palmas_gpio_id_detect(&palmas_usb->wq_detectid.work);
device_set_wakeup_capable(&pdev->dev, true);
return 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO detection
2016-06-14 14:04 ` [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO detection Roger Quadros
@ 2016-06-15 1:57 ` Chanwoo Choi
2016-06-15 6:47 ` Roger Quadros
2016-06-15 8:12 ` Roger Quadros
1 sibling, 1 reply; 5+ messages in thread
From: Chanwoo Choi @ 2016-06-15 1:57 UTC (permalink / raw)
To: Roger Quadros, myungjoo.ham
Cc: balbi, nm, grygorii.strashko, linux-kernel, linux-omap
On 2016년 06월 14일 23:04, Roger Quadros wrote:
> If USB cable is connected prior to boot, we don't get any interrupts
> so we must manually check the VBUS state and report it during probe.
> If we don't do it then USB controller will never know that peripheral
> cable was connected till the user unplugs and replugs the cable.
>
> Fixes: b7aad8e2685b ("extcon: palmas: Add the support for VBUS detection by using GPIO")
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/extcon/extcon-palmas.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index 8b3226d..caff46c 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -360,6 +360,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
>
> palmas_enable_irq(palmas_usb);
> /* perform initial detection */
> + if (palmas_usb->enable_gpio_vbus_detection)
> + palmas_vbus_irq_handler(palmas_usb->gpio_vbus_irq, palmas_usb);
> palmas_gpio_id_detect(&palmas_usb->wq_detectid.work);
> device_set_wakeup_capable(&pdev->dev, true);
> return 0;
>
Applied it.
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO detection
2016-06-15 1:57 ` Chanwoo Choi
@ 2016-06-15 6:47 ` Roger Quadros
2016-06-15 7:54 ` Chanwoo Choi
0 siblings, 1 reply; 5+ messages in thread
From: Roger Quadros @ 2016-06-15 6:47 UTC (permalink / raw)
To: Chanwoo Choi, myungjoo.ham
Cc: balbi, nm, grygorii.strashko, linux-kernel, linux-omap
On 15/06/16 04:57, Chanwoo Choi wrote:
> On 2016년 06월 14일 23:04, Roger Quadros wrote:
>> If USB cable is connected prior to boot, we don't get any interrupts
>> so we must manually check the VBUS state and report it during probe.
>> If we don't do it then USB controller will never know that peripheral
>> cable was connected till the user unplugs and replugs the cable.
>>
>> Fixes: b7aad8e2685b ("extcon: palmas: Add the support for VBUS detection by using GPIO")
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>> drivers/extcon/extcon-palmas.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
>> index 8b3226d..caff46c 100644
>> --- a/drivers/extcon/extcon-palmas.c
>> +++ b/drivers/extcon/extcon-palmas.c
>> @@ -360,6 +360,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
>>
>> palmas_enable_irq(palmas_usb);
>> /* perform initial detection */
>> + if (palmas_usb->enable_gpio_vbus_detection)
>> + palmas_vbus_irq_handler(palmas_usb->gpio_vbus_irq, palmas_usb);
>> palmas_gpio_id_detect(&palmas_usb->wq_detectid.work);
>> device_set_wakeup_capable(&pdev->dev, true);
>> return 0;
>>
>
> Applied it.
Thanks. But this is a bug fix and must go in v4.7-rc
as well as stable v4.6+.
Can you please add
Cc: stable@vger.kernel.org # v4.6+
--
cheers,
-roger
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO detection
2016-06-15 6:47 ` Roger Quadros
@ 2016-06-15 7:54 ` Chanwoo Choi
0 siblings, 0 replies; 5+ messages in thread
From: Chanwoo Choi @ 2016-06-15 7:54 UTC (permalink / raw)
To: Roger Quadros, myungjoo.ham
Cc: balbi, nm, grygorii.strashko, linux-kernel, linux-omap
On 2016년 06월 15일 15:47, Roger Quadros wrote:
> On 15/06/16 04:57, Chanwoo Choi wrote:
>> On 2016년 06월 14일 23:04, Roger Quadros wrote:
>>> If USB cable is connected prior to boot, we don't get any interrupts
>>> so we must manually check the VBUS state and report it during probe.
>>> If we don't do it then USB controller will never know that peripheral
>>> cable was connected till the user unplugs and replugs the cable.
>>>
>>> Fixes: b7aad8e2685b ("extcon: palmas: Add the support for VBUS detection by using GPIO")
>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>> ---
>>> drivers/extcon/extcon-palmas.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
>>> index 8b3226d..caff46c 100644
>>> --- a/drivers/extcon/extcon-palmas.c
>>> +++ b/drivers/extcon/extcon-palmas.c
>>> @@ -360,6 +360,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
>>>
>>> palmas_enable_irq(palmas_usb);
>>> /* perform initial detection */
>>> + if (palmas_usb->enable_gpio_vbus_detection)
>>> + palmas_vbus_irq_handler(palmas_usb->gpio_vbus_irq, palmas_usb);
>>> palmas_gpio_id_detect(&palmas_usb->wq_detectid.work);
>>> device_set_wakeup_capable(&pdev->dev, true);
>>> return 0;
>>>
>>
>> Applied it.
>
> Thanks. But this is a bug fix and must go in v4.7-rc
> as well as stable v4.6+.
OK. I'll send the pull request for this patch.
>
> Can you please add
>
> Cc: stable@vger.kernel.org # v4.6+
If we should add the 'stable@verger.kernel.org',
this patch should be sent to mailing list.
So, I think that you better to send this patch including stable mailing list.
And then, I'll send pull request which apply this patch to 4.7-rc.
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO detection
2016-06-14 14:04 ` [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO detection Roger Quadros
2016-06-15 1:57 ` Chanwoo Choi
@ 2016-06-15 8:12 ` Roger Quadros
1 sibling, 0 replies; 5+ messages in thread
From: Roger Quadros @ 2016-06-15 8:12 UTC (permalink / raw)
To: myungjoo.ham, cw00.choi
Cc: balbi, nm, grygorii.strashko, linux-kernel, linux-omap, rogerq, stable
If USB cable is connected prior to boot, we don't get any interrupts
so we must manually check the VBUS state and report it during probe.
If we don't do it then USB controller will never know that peripheral
cable was connected till the user unplugs and replugs the cable.
Fixes: b7aad8e2685b ("extcon: palmas: Add the support for VBUS detection by using GPIO")
Cc: stable@vger.kernel.org # v4.6+
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
drivers/extcon/extcon-palmas.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
index 8b3226d..caff46c 100644
--- a/drivers/extcon/extcon-palmas.c
+++ b/drivers/extcon/extcon-palmas.c
@@ -360,6 +360,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
palmas_enable_irq(palmas_usb);
/* perform initial detection */
+ if (palmas_usb->enable_gpio_vbus_detection)
+ palmas_vbus_irq_handler(palmas_usb->gpio_vbus_irq, palmas_usb);
palmas_gpio_id_detect(&palmas_usb->wq_detectid.work);
device_set_wakeup_capable(&pdev->dev, true);
return 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-15 8:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20160614140603epcas1p25c5893caf8e0f15d89fbc022d05f2a6f@epcas1p2.samsung.com>
2016-06-14 14:04 ` [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO detection Roger Quadros
2016-06-15 1:57 ` Chanwoo Choi
2016-06-15 6:47 ` Roger Quadros
2016-06-15 7:54 ` Chanwoo Choi
2016-06-15 8:12 ` Roger Quadros
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).