linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] x86/platform/intel-mid: Make vertical indentation consistent
Date: Tue, 14 Jun 2016 18:47:30 +0300	[thread overview]
Message-ID: <1465919250.30123.74.camel@linux.intel.com> (raw)
In-Reply-To: <20160614153324.GC28601@gmail.com>

On Tue, 2016-06-14 at 17:33 +0200, Ingo Molnar wrote:
> How about this as well, on top of yours?

Looks definitely good to me! Thanks!

> 
> =================>
> 
> Make vertical alignment really consistent across this header, plus fix
> various 
> uglies like unnecessary parentheses and C comments from definition
> values.
> 
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
> ---
>  arch/x86/include/asm/intel-mid.h |   45 ++++++++++++++++++++---------
> ----------
>  1 file changed, 24 insertions(+), 21 deletions(-)
> 
> Index: tip/arch/x86/include/asm/intel-mid.h
> ===================================================================
> --- tip.orig/arch/x86/include/asm/intel-mid.h
> +++ tip/arch/x86/include/asm/intel-mid.h
> @@ -74,7 +74,7 @@ struct intel_mid_ops {
>  	[cpuid] = get_##cpuname##_ops
>  
>  /* Maximum number of CPU ops */
> -#define MAX_CPU_OPS(a)		(sizeof(a)/sizeof(void *))
> +#define MAX_CPU_OPS(a)			(sizeof(a)/sizeof(void
> *))
>  
>  /*
>   * For every new cpu addition, a weak get_<cpuname>_ops() function
> needs be
> @@ -100,8 +100,8 @@ static inline bool intel_mid_has_msic(vo
>  
>  #else /* !CONFIG_X86_INTEL_MID */
>  
> -#define intel_mid_identify_cpu()	(0)
> -#define intel_mid_has_msic()		(0)
> +#define intel_mid_identify_cpu()	0
> +#define intel_mid_has_msic()		0
>  
>  #endif /* !CONFIG_X86_INTEL_MID */
>  
> @@ -117,35 +117,38 @@ extern enum intel_mid_timer_options inte
>   * Penwell uses spread spectrum clock, so the freq number is not
> exactly
>   * the same as reported by MSR based on SDM.
>   */
> -#define FSB_FREQ_83SKU		83200
> -#define FSB_FREQ_100SKU		99840
> -#define FSB_FREQ_133SKU		133000
> -
> -#define FSB_FREQ_167SKU		167000
> -#define FSB_FREQ_200SKU		200000
> -#define FSB_FREQ_267SKU		267000
> -#define FSB_FREQ_333SKU		333000
> -#define FSB_FREQ_400SKU		400000
> +#define FSB_FREQ_83SKU			83200
> +#define FSB_FREQ_100SKU			99840
> +#define FSB_FREQ_133SKU			133000
> +
> +#define FSB_FREQ_167SKU			167000
> +#define FSB_FREQ_200SKU			200000
> +#define FSB_FREQ_267SKU			267000
> +#define FSB_FREQ_333SKU			333000
> +#define FSB_FREQ_400SKU			400000
>  
>  /* Bus Select SoC Fuse value */
> -#define BSEL_SOC_FUSE_MASK	0x7
> -#define BSEL_SOC_FUSE_001	0x1 /* FSB 133MHz */
> -#define BSEL_SOC_FUSE_101	0x5 /* FSB 100MHz */
> -#define BSEL_SOC_FUSE_111	0x7 /* FSB 83MHz */
> +#define BSEL_SOC_FUSE_MASK		0x7
> +/* FSB 133MHz: */
> +#define BSEL_SOC_FUSE_001		0x1
> +/* FSB 100MHz: */
> +#define BSEL_SOC_FUSE_101		0x5
> +/* FSB 83MHz: */
> +#define BSEL_SOC_FUSE_111		0x7
>  
> -#define SFI_MTMR_MAX_NUM	8
> -#define SFI_MRTC_MAX		8
> +#define SFI_MTMR_MAX_NUM		8
> +#define SFI_MRTC_MAX			8
>  
>  extern void intel_scu_devices_create(void);
>  extern void intel_scu_devices_destroy(void);
>  
>  /* VRTC timer */
> -#define MRST_VRTC_MAP_SZ	(1024)
> -/* #define MRST_VRTC_PGOFFSET	(0xc00) */
> +#define MRST_VRTC_MAP_SZ		1024
> +/* #define MRST_VRTC_PGOFFSET	0xc00 */
>  
>  extern void intel_mid_rtc_init(void);
>  
>  /* the offset for the mapping of global gpio pin to irq */
> -#define INTEL_MID_IRQ_OFFSET	0x100
> +#define INTEL_MID_IRQ_OFFSET		0x100
>  
>  #endif /* _ASM_X86_INTEL_MID_H */

-- 

Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

      reply	other threads:[~2016-06-14 15:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14 14:33 Andy Shevchenko
2016-06-14 15:33 ` Ingo Molnar
2016-06-14 15:47   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465919250.30123.74.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH v1 1/1] x86/platform/intel-mid: Make vertical indentation consistent' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).