From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935215AbcJTLhj (ORCPT ); Thu, 20 Oct 2016 07:37:39 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:51083 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934242AbcJTLhh (ORCPT ); Thu, 20 Oct 2016 07:37:37 -0400 Subject: Re: [alsa-devel] [RFC PATCH 2/2] ASoC: samsung: Print a one-time message if the snow driver's probe defers To: Sylwester Nawrocki References: <1476897666-13974-1-git-send-email-javier@osg.samsung.com> <1476897666-13974-3-git-send-email-javier@osg.samsung.com> <29147d0b-ecf7-726a-b12b-f93d548f0c99@samsung.com> <06ba6563-2792-cb08-694e-4582618ae7fb@osg.samsung.com> <7a730a84-ce97-2148-87d9-64211a1aaa6b@samsung.com> Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Sangbeom Kim , Takashi Iwai , Liam Girdwood , Krzysztof Kozlowski , Mark Brown From: Javier Martinez Canillas Message-ID: <1465966b-0c24-e23c-0f66-69cae77c50c9@osg.samsung.com> Date: Thu, 20 Oct 2016 08:37:29 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <7a730a84-ce97-2148-87d9-64211a1aaa6b@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Sylwester, On 10/20/2016 08:27 AM, Sylwester Nawrocki wrote: > On 10/20/2016 12:41 PM, Javier Martinez Canillas wrote: >> I see no relevant changes in exynos_defconfig between v4.7..v4.8 and >> also no changes in drivers/Makefile that could cause things to be >> initialized on a different order. > > I remember this > > commit 6eb1c9496b81680f2cd2e0eda06c531317e2e28d > clk: probe common clock drivers earlier > > going in recently, but it's rather dubious it could cause such trouble. > Yes, I'm aware of this change (and in fact it broke MMC in the Peach Pi Chromebook) but that commit landed in v4.9-rc1, not v4.8. > Anyway, I'd try to add some debug prints to samsung_i2s_probe() to see > what's the issue with the CPU DAI registration. > Sure, I'm busy with other stuff now but I'll dig again this next week. >> But I thought the patches had merits on its own since probe deferral >> can make a driver probe many times and the error logs were noisy. I >> wasn't sure though and that's why are marked as RFC. > > In general I wouldn't be disabling those err logs unless proper > EPROBE_DEFER handling is added on related error paths and we can > differentiate between probe deferral and real unrecoverable errors > and can disable logging only for EPROBE_DEFER cases. > Yes, the sound core change (patch 1/2) is only for the EPROBE_DEFER path. >>> As far as the error log is concerned, I would just not print anything >>> in snow_probe() when register_card() returns EPROBE_DEFER. >>> >> >> I believe it may be useful to know that a driver's probe is deferring >> due a missing dependency but have no strong opinion and can remove the >> message. > > I'd rather rely on core code to inform about missing resources when > registering components. Otherwise booting unnecessarily takes more > time when there is more probe deferring logs printed on the console. > Fair enough. > > -- > Thanks, > Sylwester > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America