From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933133AbcFOVMq (ORCPT ); Wed, 15 Jun 2016 17:12:46 -0400 Received: from lb2-smtp-cloud6.xs4all.net ([194.109.24.28]:42122 "EHLO lb2-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932235AbcFOVMo (ORCPT ); Wed, 15 Jun 2016 17:12:44 -0400 Message-ID: <1466025158.28441.16.camel@tiscali.nl> Subject: Re: linux-next: build failure after merge of the akpm-current tree From: Paul Bolle To: Josh Poimboeuf Cc: Andrew Morton , Arnd Bergmann , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 15 Jun 2016 23:12:38 +0200 In-Reply-To: <20160615140311.l2s7pkxuvybskcbc@treble> References: <20160506145810.04a319d3@canb.auug.org.au> <20160505224429.3b8f3837bcb0281932cfe03f@linux-foundation.org> <1465983212.9515.35.camel@tiscali.nl> <20160615140311.l2s7pkxuvybskcbc@treble> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 (3.16.5-3.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Josh, On wo, 2016-06-15 at 09:03 -0500, Josh Poimboeuf wrote: > I agree it looks like a false positive, though the code is a bit > convoluted, so I'm not surprised that gcc might get confused. Agree. > How about initializing opt to 0? I'm unconvinced. Especially since this only shows up in 64 bits builds. > --- a/net/netfilter/ipvs/ip_vs_sync.c > +++ b/net/netfilter/ipvs/ip_vs_sync.c > static inline int ip_vs_proc_sync_conn(struct netns_ipvs *ipvs, __u8 > - struct ip_vs_sync_conn_options opt; > + struct ip_vs_sync_conn_options opt = {0}; You forgot to append /* I give up */ here. More common would be to use /* silence GCC */ Thanks, Paul Bolle