From: He Kuang <hekuang@huawei.com>
To: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<alexander.shishkin@linux.intel.com>, <hekuang@huawei.com>,
<wangnan0@huawei.com>, <adrian.hunter@intel.com>,
<ak@linux.intel.com>, <maddy@linux.vnet.ibm.com>, <bp@suse.de>,
<dsahern@gmail.com>, <linux@horizon.com>, <jolsa@redhat.com>,
<namhyung@kernel.org>, <linux@rasmusvillemoes.dk>,
<yury.norov@gmail.com>, <mpe@ellerman.id.au>
Cc: <linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>
Subject: [PATCH 2/2] tools include: Fix wrong macro definitions for cpu_to_le* for big endian
Date: Thu, 16 Jun 2016 01:32:09 +0000 [thread overview]
Message-ID: <1466040729-100926-3-git-send-email-hekuang@huawei.com> (raw)
In-Reply-To: <1466040729-100926-1-git-send-email-hekuang@huawei.com>
From: Wang Nan <wangnan0@huawei.com>
The cpu_to_le* macros in kernel.h are defined without considering
endianese. This patch includes "byteoder/generic.h" instead to fix the
bug, and removes redundant le64_to_cpu definition in intel-bts.c.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Signed-off-by: He Kuang <hekuang@huawei.com>
---
tools/include/linux/kernel.h | 5 ++---
tools/perf/util/intel-bts.c | 5 -----
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/tools/include/linux/kernel.h b/tools/include/linux/kernel.h
index 76df535..6145e41 100644
--- a/tools/include/linux/kernel.h
+++ b/tools/include/linux/kernel.h
@@ -64,11 +64,10 @@
#endif
/*
- * Both need more care to handle endianness
+ * Need more care to handle endianness
* (Don't use bitmap_copy_le() for now)
*/
-#define cpu_to_le64(x) (x)
-#define cpu_to_le32(x) (x)
+#include <linux/byteorder/generic.h>
static inline int
vscnprintf(char *buf, size_t size, const char *fmt, va_list args)
diff --git a/tools/perf/util/intel-bts.c b/tools/perf/util/intel-bts.c
index 9df9960..0e632c4 100644
--- a/tools/perf/util/intel-bts.c
+++ b/tools/perf/util/intel-bts.c
@@ -40,11 +40,6 @@
#define INTEL_BTS_ERR_NOINSN 5
#define INTEL_BTS_ERR_LOST 9
-#if __BYTE_ORDER == __BIG_ENDIAN
-#define le64_to_cpu bswap_64
-#else
-#define le64_to_cpu
-#endif
struct intel_bts {
struct auxtrace auxtrace;
--
1.8.5.2
next prev parent reply other threads:[~2016-06-16 1:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 11:42 [PATCH] tools/perf: fix the word selected in find_*_bit Madhavan Srinivasan
2016-06-15 12:44 ` George Spelvin
2016-06-16 7:21 ` Madhavan Srinivasan
2016-06-15 19:51 ` Yury Norov
2016-06-15 21:11 ` Yury Norov
2016-06-15 21:29 ` Arnaldo Carvalho de Melo
2016-06-16 1:27 ` [PATCH] tools include: Fix wrong macro definitions for cpu_to_le* for big endian He Kuang
2016-06-16 1:32 ` He Kuang
2016-06-16 1:32 ` [PATCH 1/2] tools include: Sync byteorder/generic.h He Kuang
2016-06-16 6:39 ` Jiri Olsa
2016-06-16 1:32 ` He Kuang [this message]
2016-06-16 6:21 ` [PATCH 2/2] tools include: Fix wrong macro definitions for cpu_to_le* for big endian kbuild test robot
2016-06-16 6:39 ` Jiri Olsa
2016-06-16 1:35 ` [PATCH] tools/perf: fix the word selected in find_*_bit Hekuang
2016-06-16 13:11 ` Madhavan Srinivasan
2016-06-16 7:15 ` Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466040729-100926-3-git-send-email-hekuang@huawei.com \
--to=hekuang@huawei.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@suse.de \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=linux@rasmusvillemoes.dk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).