From: Garlic Tseng <garlic.tseng@mediatek.com>
To: Yingjoe Chen <yingjoe.chen@mediatek.com>
Cc: <broonie@kernel.org>, <tiwai@suse.de>,
<alsa-devel@alsa-project.org>, <ir.lian@mediatek.com>,
<srv_heupstream@mediatek.com>, <linux-kernel@vger.kernel.org>,
<koro.chen@mediatek.com>, <linux-mediatek@lists.infradead.org>,
<PC.Liao@mediatek.com>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [alsa-devel] [PATCH v4 3/9] ASoC: mediatek: let mt8173 use mediatek common structure
Date: Thu, 16 Jun 2016 09:40:11 +0800 [thread overview]
Message-ID: <1466041211.27083.3.camel@mtksdaap41> (raw)
In-Reply-To: <1465988242.30493.6.camel@mtksdaap41>
Hi Yingjoe, thanks for comments.
> > +config SND_SOC_MEDIATEK
> > + tristate "SND_SOC_MEDIATEK"
> > + depends on ARCH_MEDIATEK
> > + help
> > + This adds ASoC driver for Mediatek boards
> > + that can be used with other codecs.
> > + Select Y if you have such device.
> > + If unsure select "N".
> > +
> > config SND_SOC_MT8173
> > tristate "ASoC support for Mediatek MT8173 chip"
> > depends on ARCH_MEDIATEK
> > + select SND_SOC_MEDIATEK
> > help
> > This adds ASoC platform driver support for Mediatek MT8173 chip
> > that can be used with other codecs.
>
> It seems both SND_SOC_MT8173 and SND_SOC_MT2701 select SND_SOC_MEDIATEK,
> and enabling only SND_SOC_MEDIATEK itself is not really useful. Do we
> need to make SND_SOC_MEDIATEK user configurable option?
I'll make the config not user configurable, something like:
+config SND_SOC_MEDIATEK
+ tristate
>
> If it is, we should at least have a proper config prompt instead of just
> "SND_SOC_MEDIATEK".
>
>
> > @@ -49,3 +59,4 @@ config SND_SOC_MT8173_RT5650_RT5676
> > with the RT5650 and RT5676 codecs.
> > Select Y if you have such device.
> > If unsure select "N".
> > +
>
> nit: This change is not necessary.
I'll fix it, thanks.
>
> Joe.C
>
>
next prev parent reply other threads:[~2016-06-16 1:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 7:26 [alsa-devel] [PATCH v4 0/9] ASoC: Mediatek: Add support for MT2701 SOC Garlic Tseng
2016-06-13 7:26 ` [alsa-devel] [PATCH v4 1/9] ASoC: mediatek: Refine mt8173 driver and change config option Garlic Tseng
2016-06-13 7:26 ` [alsa-devel] [PATCH v4 2/9] ASoC: mediatek: implement mediatek common structure Garlic Tseng
2016-06-29 19:16 ` Applied "ASoC: mediatek: implement mediatek common structure" to the asoc tree Mark Brown
2016-06-13 7:26 ` [alsa-devel] [PATCH v4 3/9] ASoC: mediatek: let mt8173 use mediatek common structure Garlic Tseng
2016-06-15 10:57 ` Yingjoe Chen
2016-06-16 1:40 ` Garlic Tseng [this message]
2016-06-13 7:26 ` [alsa-devel] [PATCH v4 4/9] ASoC: mediatek: add documents for mt2701 Garlic Tseng
2016-06-13 7:26 ` [alsa-devel] [PATCH v4 5/9] ASoC: mediatek: add structure define and clock control for 2701 Garlic Tseng
2016-06-13 7:26 ` [alsa-devel] [PATCH v4 6/9] ASoC: mediatek: add mt2701 platform driver implementation Garlic Tseng
2016-06-13 7:26 ` [alsa-devel] [PATCH v4 7/9] ASoC: bt-sco: extend rate and add a general compatible string Garlic Tseng
2016-06-13 7:26 ` [alsa-devel] [PATCH v4 8/9] ASoC: mediatek: add BT implementation Garlic Tseng
2016-06-13 7:26 ` [alsa-devel] [PATCH v4 9/9] ASoC: mediatek: Add mt2701-cs42448 driver and config option Garlic Tseng
2016-06-15 10:58 ` Yingjoe Chen
2016-06-16 1:41 ` Garlic Tseng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466041211.27083.3.camel@mtksdaap41 \
--to=garlic.tseng@mediatek.com \
--cc=PC.Liao@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ir.lian@mediatek.com \
--cc=koro.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=srv_heupstream@mediatek.com \
--cc=tiwai@suse.de \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).