From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753878AbcFPH64 (ORCPT ); Thu, 16 Jun 2016 03:58:56 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:54547 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751619AbcFPH6x (ORCPT ); Thu, 16 Jun 2016 03:58:53 -0400 X-Sasl-enc: ylX9aZAe76GSNE5kbowFGZxSjsXSlYmGqTA33DX/5Z1j 1466063932 Message-ID: <1466063928.3157.6.camel@themaw.net> Subject: Re: [PATCH] autofs: don't stuck in a loop if vfs_write returns an error From: Ian Kent To: Andrew Morton Cc: Andrei Vagin , autofs@vger.kernel.org, LKML Date: Thu, 16 Jun 2016 15:58:48 +0800 In-Reply-To: <20160610120720.60e26470d41b002db9218c10@linux-foundation.org> References: <1459487558-21258-1-git-send-email-avagin@gmail.com> <1459496266.2974.1.camel@themaw.net> <1464053664.3108.21.camel@themaw.net> <1464587527.3025.6.camel@themaw.net> <1465435406.3154.4.camel@themaw.net> <20160610120720.60e26470d41b002db9218c10@linux-foundation.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 (3.16.5-3.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-06-10 at 12:07 -0700, Andrew Morton wrote: > On Thu, 09 Jun 2016 09:23:26 +0800 Ian Kent wrote: > > > > I was getting ready to send these over to Andrew and found that opendir(3) > > > is > > > failing on a number of tests (51 of 230, 9 fails are expected) with 4.6.0. > > > > > > It's not the patches, yours or mine and it doesn't happen with 4.4.x > > > kernels. > > > > > > Looks like I'm going to have to bisect to work out what's going on and > > > that > > > will > > > take a while. > > > > The regression has been fixed now. > > > > Al Viro sent a patch for it to Linus yesterday, it's commit e6ec03a25f1 in > > the > > Linux tree. > > > > I can send my patches to Andrew (after re-testing) but any autofs related > > testing of linux.next will need the above commit. > > > > Andrew, surely this isn't the first time this type of problem has happened, > > how > > is it usually handled, what do I need to do to make this go smoothly? > > e6ec03a25f1 is in Linus's tree now so everything should be good. Everything was good. There's another autofs patch in Al's for-linus tree now and I don't know when it will go to Linus. That one will definitely cause merge conflicts. After thinking about it, it's probably best to defer the module rename series until after the next merge window, after all it's not urgent (apart from being needed for so long). I'll send over Andrei's patch alone soonish. Thanks all for your patience, Ian