From: Philipp Zabel <p.zabel@pengutronix.de>
To: Xinliang Liu <xinliang.liu@linaro.org>
Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org,
xuwei5@hisilicon.com, puck.chen@hisilicon.com,
saberlily.xia@hisilicon.com, kong.kongxinwei@hisilicon.com,
guodong.xu@linaro.org
Subject: Re: [PATCH v2 1/3] reset: hisilicon: Add media reset controller binding
Date: Thu, 16 Jun 2016 12:46:50 +0200 [thread overview]
Message-ID: <1466074010.3343.15.camel@pengutronix.de> (raw)
In-Reply-To: <20160616103000.239669-2-xinliang.liu@linaro.org>
Am Donnerstag, den 16.06.2016, 18:29 +0800 schrieb Xinliang Liu:
> Add compatible for media reset controller.
>
> Signed-off-by: Xinliang Liu <xinliang.liu@linaro.org>
> ---
> Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
> index e0b185a944ba..c25da39df707 100644
> --- a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
> +++ b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
> @@ -8,7 +8,9 @@ The reset controller registers are part of the system-ctl block on
> hi6220 SoC.
>
> Required properties:
> -- compatible: may be "hisilicon,hi6220-sysctrl"
> +- compatible: should be one of the following:
> + - "hisilicon,hi6220-sysctrl", "syscon" : For peripheral reset controller.
> + - "hisilicon,hi6220-mediactrl", "syscon" : For media reset controller.
This does more than the commit message says. Why do you add syscon here?
Do the sysctrl and mediactrl register ranges have bits other than reset
controls that will be used by other drivers via the syscon mechanism?
regards
Philipp
next prev parent reply other threads:[~2016-06-16 10:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 10:29 [PATCH v2 0/3] Add hi6220 media subsystem reset controller driver Xinliang Liu
2016-06-16 10:29 ` [PATCH v2 1/3] reset: hisilicon: Add media reset controller binding Xinliang Liu
2016-06-16 10:46 ` Philipp Zabel [this message]
2016-06-17 1:29 ` Xinliang Liu
2016-06-16 10:29 ` [PATCH v2 2/3] arm64: dts: hi6220: Add media subsystem reset dts Xinliang Liu
2016-06-16 10:30 ` [PATCH v2 3/3] reset: hisilicon: Add hi6220 media subsystem reset support Xinliang Liu
2016-06-16 10:52 ` Philipp Zabel
2016-06-17 1:49 ` Xinliang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466074010.3343.15.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=guodong.xu@linaro.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=puck.chen@hisilicon.com \
--cc=robh+dt@kernel.org \
--cc=saberlily.xia@hisilicon.com \
--cc=xinliang.liu@linaro.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).