* [PATCH] MIPS: Lantiq: fix build failure
@ 2016-06-16 20:46 Sudip Mukherjee
2016-06-17 8:46 ` John Crispin
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2016-06-16 20:46 UTC (permalink / raw)
To: John Crispin, Ralf Baechle; +Cc: linux-kernel, linux-mips, Sudip Mukherjee
Some configs of mips like xway_defconffig are failing with the error:
arch/mips/lantiq/irq.c:209:2: error: initialization from incompatible
pointer type [-Werror]
"icu",
^
arch/mips/lantiq/irq.c:209:2: error: (near initialization for
'ltq_irq_type.parent_device') [-Werror]
arch/mips/lantiq/irq.c:219:2: error: initialization from incompatible
pointer type [-Werror]
"eiu",
^
arch/mips/lantiq/irq.c:219:2: error: (near initialization for
'ltq_eiu_type.parent_device') [-Werror]
The first member of the "struct irq" is no longer a pointer for the
name.
Fixes: be45beb2df69 ("genirq: Add runtime power management support for IRQ chips")
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
build log can be seen at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/137992701
arch/mips/lantiq/irq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/lantiq/irq.c b/arch/mips/lantiq/irq.c
index ff17669e..02c0252 100644
--- a/arch/mips/lantiq/irq.c
+++ b/arch/mips/lantiq/irq.c
@@ -206,7 +206,7 @@ static void ltq_shutdown_eiu_irq(struct irq_data *d)
}
static struct irq_chip ltq_irq_type = {
- "icu",
+ .name = "icu",
.irq_enable = ltq_enable_irq,
.irq_disable = ltq_disable_irq,
.irq_unmask = ltq_enable_irq,
@@ -216,7 +216,7 @@ static struct irq_chip ltq_irq_type = {
};
static struct irq_chip ltq_eiu_type = {
- "eiu",
+ .name = "eiu",
.irq_startup = ltq_startup_eiu_irq,
.irq_shutdown = ltq_shutdown_eiu_irq,
.irq_enable = ltq_enable_irq,
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: Lantiq: fix build failure
2016-06-16 20:46 [PATCH] MIPS: Lantiq: fix build failure Sudip Mukherjee
@ 2016-06-17 8:46 ` John Crispin
0 siblings, 0 replies; 2+ messages in thread
From: John Crispin @ 2016-06-17 8:46 UTC (permalink / raw)
To: Sudip Mukherjee, Ralf Baechle; +Cc: linux-kernel, linux-mips
On 16/06/2016 22:46, Sudip Mukherjee wrote:
> Some configs of mips like xway_defconffig are failing with the error:
> arch/mips/lantiq/irq.c:209:2: error: initialization from incompatible
> pointer type [-Werror]
> "icu",
> ^
> arch/mips/lantiq/irq.c:209:2: error: (near initialization for
> 'ltq_irq_type.parent_device') [-Werror]
> arch/mips/lantiq/irq.c:219:2: error: initialization from incompatible
> pointer type [-Werror]
> "eiu",
> ^
> arch/mips/lantiq/irq.c:219:2: error: (near initialization for
> 'ltq_eiu_type.parent_device') [-Werror]
>
> The first member of the "struct irq" is no longer a pointer for the
> name.
>
> Fixes: be45beb2df69 ("genirq: Add runtime power management support for IRQ chips")
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Acked-by: John Crispin <john@phrozen.org>
> ---
>
> build log can be seen at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/137992701
>
> arch/mips/lantiq/irq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/lantiq/irq.c b/arch/mips/lantiq/irq.c
> index ff17669e..02c0252 100644
> --- a/arch/mips/lantiq/irq.c
> +++ b/arch/mips/lantiq/irq.c
> @@ -206,7 +206,7 @@ static void ltq_shutdown_eiu_irq(struct irq_data *d)
> }
>
> static struct irq_chip ltq_irq_type = {
> - "icu",
> + .name = "icu",
> .irq_enable = ltq_enable_irq,
> .irq_disable = ltq_disable_irq,
> .irq_unmask = ltq_enable_irq,
> @@ -216,7 +216,7 @@ static struct irq_chip ltq_irq_type = {
> };
>
> static struct irq_chip ltq_eiu_type = {
> - "eiu",
> + .name = "eiu",
> .irq_startup = ltq_startup_eiu_irq,
> .irq_shutdown = ltq_shutdown_eiu_irq,
> .irq_enable = ltq_enable_irq,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-17 8:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-16 20:46 [PATCH] MIPS: Lantiq: fix build failure Sudip Mukherjee
2016-06-17 8:46 ` John Crispin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).