linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] mailbox: pcc: Add PCC request and free channel declarations
@ 2016-06-16 21:09 Hoan Tran
  2016-06-23  0:49 ` Rafael J. Wysocki
  0 siblings, 1 reply; 3+ messages in thread
From: Hoan Tran @ 2016-06-16 21:09 UTC (permalink / raw)
  To: Ashwin Chaugule, Jassi Brar, Rafael J. Wysocki, Len Brown, pprakash
  Cc: Robert Moore, Lv Zheng, linux-acpi, linux-kernel, devel, lho,
	Duc Dang, Hoan Tran

Exports pcc_mbox_request_channel() and pcc_mbox_free_channel()
declarations into a pcc.h header file.

v2
 * Introduce pcc.h header file for pcc client methods

v1
 * Initial

Signed-off-by: Hoan Tran <hotran@apm.com>
---
 include/acpi/cppc_acpi.h |  7 +------
 include/acpi/pcc.h       | 29 +++++++++++++++++++++++++++++
 2 files changed, 30 insertions(+), 6 deletions(-)
 create mode 100644 include/acpi/pcc.h

diff --git a/include/acpi/cppc_acpi.h b/include/acpi/cppc_acpi.h
index 259683a..ab1da43 100644
--- a/include/acpi/cppc_acpi.h
+++ b/include/acpi/cppc_acpi.h
@@ -15,10 +15,9 @@
 #define _CPPC_ACPI_H
 
 #include <linux/acpi.h>
-#include <linux/mailbox_controller.h>
-#include <linux/mailbox_client.h>
 #include <linux/types.h>
 
+#include <acpi/pcc.h>
 #include <acpi/processor.h>
 
 /* Only support CPPCv2 for now. */
@@ -131,8 +130,4 @@ extern int cppc_set_perf(int cpu, struct cppc_perf_ctrls *perf_ctrls);
 extern int cppc_get_perf_caps(int cpu, struct cppc_perf_caps *caps);
 extern int acpi_get_psd_map(struct cpudata **);
 
-/* Methods to interact with the PCC mailbox controller. */
-extern struct mbox_chan *
-	pcc_mbox_request_channel(struct mbox_client *, unsigned int);
-
 #endif /* _CPPC_ACPI_H*/
diff --git a/include/acpi/pcc.h b/include/acpi/pcc.h
new file mode 100644
index 0000000..17a940a
--- /dev/null
+++ b/include/acpi/pcc.h
@@ -0,0 +1,29 @@
+/*
+ * PCC (Platform Communications Channel) methods
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; version 2
+ * of the License.
+ */
+
+#ifndef _PCC_H
+#define _PCC_H
+
+#include <linux/mailbox_controller.h>
+#include <linux/mailbox_client.h>
+
+#ifdef CONFIG_PCC
+extern struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *cl,
+						  int subspace_id);
+extern void pcc_mbox_free_channel(struct mbox_chan *chan);
+#else
+static inline struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *cl,
+							 int subspace_id)
+{
+	return NULL;
+}
+static inline void pcc_mbox_free_channel(struct mbox_chan *chan) { }
+#endif
+
+#endif /* _PCC_H */
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] mailbox: pcc: Add PCC request and free channel declarations
  2016-06-16 21:09 [PATCH v2] mailbox: pcc: Add PCC request and free channel declarations Hoan Tran
@ 2016-06-23  0:49 ` Rafael J. Wysocki
  2016-06-23 15:39   ` Prakash, Prashanth
  0 siblings, 1 reply; 3+ messages in thread
From: Rafael J. Wysocki @ 2016-06-23  0:49 UTC (permalink / raw)
  To: Hoan Tran, Ashwin Chaugule, pprakash
  Cc: Jassi Brar, Len Brown, Robert Moore, Lv Zheng, linux-acpi,
	linux-kernel, devel, lho, Duc Dang

On Thursday, June 16, 2016 02:09:38 PM Hoan Tran wrote:
> Exports pcc_mbox_request_channel() and pcc_mbox_free_channel()
> declarations into a pcc.h header file.
> 
> v2
>  * Introduce pcc.h header file for pcc client methods
> 
> v1
>  * Initial
> 
> Signed-off-by: Hoan Tran <hotran@apm.com>

Ashwin, Prakash, any comments anyone?

> ---
>  include/acpi/cppc_acpi.h |  7 +------
>  include/acpi/pcc.h       | 29 +++++++++++++++++++++++++++++
>  2 files changed, 30 insertions(+), 6 deletions(-)
>  create mode 100644 include/acpi/pcc.h
> 
> diff --git a/include/acpi/cppc_acpi.h b/include/acpi/cppc_acpi.h
> index 259683a..ab1da43 100644
> --- a/include/acpi/cppc_acpi.h
> +++ b/include/acpi/cppc_acpi.h
> @@ -15,10 +15,9 @@
>  #define _CPPC_ACPI_H
>  
>  #include <linux/acpi.h>
> -#include <linux/mailbox_controller.h>
> -#include <linux/mailbox_client.h>
>  #include <linux/types.h>
>  
> +#include <acpi/pcc.h>
>  #include <acpi/processor.h>
>  
>  /* Only support CPPCv2 for now. */
> @@ -131,8 +130,4 @@ extern int cppc_set_perf(int cpu, struct cppc_perf_ctrls *perf_ctrls);
>  extern int cppc_get_perf_caps(int cpu, struct cppc_perf_caps *caps);
>  extern int acpi_get_psd_map(struct cpudata **);
>  
> -/* Methods to interact with the PCC mailbox controller. */
> -extern struct mbox_chan *
> -	pcc_mbox_request_channel(struct mbox_client *, unsigned int);
> -
>  #endif /* _CPPC_ACPI_H*/
> diff --git a/include/acpi/pcc.h b/include/acpi/pcc.h
> new file mode 100644
> index 0000000..17a940a
> --- /dev/null
> +++ b/include/acpi/pcc.h
> @@ -0,0 +1,29 @@
> +/*
> + * PCC (Platform Communications Channel) methods
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; version 2
> + * of the License.
> + */
> +
> +#ifndef _PCC_H
> +#define _PCC_H
> +
> +#include <linux/mailbox_controller.h>
> +#include <linux/mailbox_client.h>
> +
> +#ifdef CONFIG_PCC
> +extern struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *cl,
> +						  int subspace_id);
> +extern void pcc_mbox_free_channel(struct mbox_chan *chan);
> +#else
> +static inline struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *cl,
> +							 int subspace_id)
> +{
> +	return NULL;
> +}
> +static inline void pcc_mbox_free_channel(struct mbox_chan *chan) { }
> +#endif
> +
> +#endif /* _PCC_H */
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] mailbox: pcc: Add PCC request and free channel declarations
  2016-06-23  0:49 ` Rafael J. Wysocki
@ 2016-06-23 15:39   ` Prakash, Prashanth
  0 siblings, 0 replies; 3+ messages in thread
From: Prakash, Prashanth @ 2016-06-23 15:39 UTC (permalink / raw)
  To: Rafael J. Wysocki, Hoan Tran, Ashwin Chaugule
  Cc: Jassi Brar, Len Brown, Robert Moore, Lv Zheng, linux-acpi,
	linux-kernel, devel, lho, Duc Dang

Hi Rafael,

On 6/22/2016 6:49 PM, Rafael J. Wysocki wrote:
> On Thursday, June 16, 2016 02:09:38 PM Hoan Tran wrote:
>> Exports pcc_mbox_request_channel() and pcc_mbox_free_channel()
>> declarations into a pcc.h header file.
>>
>> v2
>>  * Introduce pcc.h header file for pcc client methods
>>
>> v1
>>  * Initial
>>
>> Signed-off-by: Hoan Tran <hotran@apm.com>
> Ashwin, Prakash, any comments anyone?

This change looks good.

Thanks,
Prashanth

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-23 15:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-16 21:09 [PATCH v2] mailbox: pcc: Add PCC request and free channel declarations Hoan Tran
2016-06-23  0:49 ` Rafael J. Wysocki
2016-06-23 15:39   ` Prakash, Prashanth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).