From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755323AbcFQITU (ORCPT ); Fri, 17 Jun 2016 04:19:20 -0400 Received: from smarthost01d.mail.zen.net.uk ([212.23.1.7]:53748 "EHLO smarthost01d.mail.zen.net.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753942AbcFQITQ (ORCPT ); Fri, 17 Jun 2016 04:19:16 -0400 Message-ID: <1466151552.2841.10.camel@linaro.org> Subject: Re: [PATCH v2 3/3] firmware: scpi: add device power domain support using genpd From: "Jon Medhurst (Tixy)" To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ulf Hansson , Mathieu Poirier , Suzuki K Poulose , "Rafael J. Wysocki" , Kevin Hilman Date: Fri, 17 Jun 2016 09:19:12 +0100 In-Reply-To: <5762E8F1.1040401@arm.com> References: <1466073481-697-1-git-send-email-sudeep.holla@arm.com> <1466073481-697-4-git-send-email-sudeep.holla@arm.com> <1466099274.20208.65.camel@linaro.org> <5762E8F1.1040401@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-smarthost01d-IP: [82.69.122.217] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-06-16 at 18:59 +0100, Sudeep Holla wrote: > > On 16/06/16 18:47, Jon Medhurst (Tixy) wrote: > > On Thu, 2016-06-16 at 11:38 +0100, Sudeep Holla wrote: > > [...] > >> +enum scpi_power_domain_state { > >> + SCPI_PD_STATE_ON = 0, > >> + SCPI_PD_STATE_OFF = 3, > >> +}; > > > > The SCPI doc defines the meaning of these numbers (0 and 3) in the 'Juno > > specifics' chapter. So does these values need to come from device-tree > > to allow for other hardware or SCP implementations? > > > > Ah unfortunately true :(. I had not noticed that. But I would like to > check if this can be made as part of the standard protocol. Adding such > details to DT seems overkill and defeat of the whole purpose of the > standard protocol. Well. it seems to me the 'standard protocol' is whatever the current implementation of ARM's closed source SCP firmware is. It also seems to me that people are making things up as they go along, without a clue as to how to make things generic, robust and future proof. Basically, Status Normal ARM Fucked Up. -- Tixy