From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755302AbcFQIn1 (ORCPT ); Fri, 17 Jun 2016 04:43:27 -0400 Received: from mail.sigma-star.at ([95.130.255.111]:45996 "EHLO mail.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753942AbcFQInZ (ORCPT ); Fri, 17 Jun 2016 04:43:25 -0400 From: Richard Weinberger To: akpm@linux-foundation.org Cc: dhowells@redhat.com, David.Woodhouse@intel.com, hannes@cmpxchg.org, tj@kernel.org, ard.biesheuvel@linaro.org, pmladek@suse.com, rusty@rustcorp.com.au, arnd@arndb.de, linux-kernel@vger.kernel.org, Richard Weinberger , Al Viro Subject: [PATCH] Make COMPILE_TEST depend on !UML Date: Fri, 17 Jun 2016 10:43:15 +0200 Message-Id: <1466152995-28367-1-git-send-email-richard@nod.at> X-Mailer: git-send-email 2.7.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org UML is a bit special since it does not have iomem nor dma. That means a lot of drivers will not build if they miss a dependency on HAS_IOMEM. s390 used to have the same issues but since it gained PCI support UML is the only stranger. We are tired of patching dozens of new drivers after every merge window just to un-break allmod/yesconfig UML builds. One could argue that a decent driver has to know on what it depends and therefore a missing HAS_IOMEM dependency is a clear driver bug. But the dependency not obvious and not everyone does UML builds with COMPILE_TEST enabled when developing a device driver. A possible solution to make these builds succeed on UML would be providing stub functions for ioremap() and friends which fail upon runtime. Another one is simply disabling COMPILE_TEST for UML. Since it is the least hassle and does not force use to fake iomem support let's do the latter. Cc: Al Viro Acked-by: Arnd Bergmann Signed-off-by: Richard Weinberger --- init/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/init/Kconfig b/init/Kconfig index f755a60..eae1808 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -55,6 +55,7 @@ config CROSS_COMPILE config COMPILE_TEST bool "Compile also drivers which will not load" + depends on !UML default n help Some drivers can be compiled on a different platform than they are -- 2.7.3